| Message ID | 1470717525-22872-2-git-send-email-dja@axtens.net |
|---|---|
| State | Changes Requested |
| Headers | show |
On 09 Aug 14:38, Daniel Axtens wrote: > sqlparse 0.2 breaks django-debug-toolbar 1.4. > > Sadly, django-debug-toolbar has an unversioned dependency, so > sqlparse 0.2 gets pulled in and django-debug-toolbar breaks. > > django-debug-toolbar 1.5 unbreaks that, but breaks Django 1.7, > so we can't upgrade yet. > > Force sqlparse to be < 0.2 in requirements-test.txt > > We'll need to revisit this eventually, but it should hold for a > while. > > Signed-off-by: Daniel Axtens <dja@axtens.net> Added a note in the requirements file, but otherwise: Reviewed-by: Stephen Finucane <stephenfinucane@hotmail.com>
On 21 Aug 15:13, Stephen Finucane wrote: > On 09 Aug 14:38, Daniel Axtens wrote: > > sqlparse 0.2 breaks django-debug-toolbar 1.4. > > > > Sadly, django-debug-toolbar has an unversioned dependency, so > > sqlparse 0.2 gets pulled in and django-debug-toolbar breaks. > > > > django-debug-toolbar 1.5 unbreaks that, but breaks Django 1.7, > > so we can't upgrade yet. Thinking on this a little more, I think we should upgrade DDT to 1.5. Django 1.7 is EOL, so while we test against it we certainly don't need people working with it for development. I'll submit a patch to this end. > > Force sqlparse to be < 0.2 in requirements-test.txt > > > > We'll need to revisit this eventually, but it should hold for a > > while. > > > > Signed-off-by: Daniel Axtens <dja@axtens.net> > > Added a note in the requirements file, but otherwise: > > Reviewed-by: Stephen Finucane <stephenfinucane@hotmail.com> > _______________________________________________ > Patchwork mailing list > Patchwork@lists.ozlabs.org > https://lists.ozlabs.org/listinfo/patchwork
> sqlparse 0.2 breaks django-debug-toolbar 1.4. > > Sadly, django-debug-toolbar has an unversioned dependency, so > sqlparse 0.2 gets pulled in and django-debug-toolbar breaks. So it seems like sqlparse 0.2.1 has been released, which fixes this breakage. We probably do still need to add sqlparse to the production requirements, but we can now include a more recent version. Regards, Daniel > > django-debug-toolbar 1.5 unbreaks that, but breaks Django 1.7, > so we can't upgrade yet. > > Force sqlparse to be < 0.2 in requirements-test.txt > > We'll need to revisit this eventually, but it should hold for a > while. > > Signed-off-by: Daniel Axtens <dja@axtens.net> > --- > requirements-test.txt | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/requirements-test.txt b/requirements-test.txt > index cfc242f647f8..b4e8e85688fb 100644 > --- a/requirements-test.txt > +++ b/requirements-test.txt > @@ -4,3 +4,4 @@ python-dateutil>2.0,<3.0 > selenium>2.0,<3.0 > djangorestframework>=3.3,<3.4 > drf-nested-routers>=0.11.1,<0.12 > +sqlparse<0.2 > -- > 2.7.4
>> sqlparse 0.2 breaks django-debug-toolbar 1.4. >> >> Sadly, django-debug-toolbar has an unversioned dependency, so >> sqlparse 0.2 gets pulled in and django-debug-toolbar breaks. > > So it seems like sqlparse 0.2.1 has been released, which fixes this > breakage. Wait, no, it seems that it doesn't. Ignore that. > > We probably do still need to add sqlparse to the production > requirements, but we can now include a more recent version. > > Regards, > Daniel > >> >> django-debug-toolbar 1.5 unbreaks that, but breaks Django 1.7, >> so we can't upgrade yet. >> >> Force sqlparse to be < 0.2 in requirements-test.txt >> >> We'll need to revisit this eventually, but it should hold for a >> while. >> >> Signed-off-by: Daniel Axtens <dja@axtens.net> >> --- >> requirements-test.txt | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/requirements-test.txt b/requirements-test.txt >> index cfc242f647f8..b4e8e85688fb 100644 >> --- a/requirements-test.txt >> +++ b/requirements-test.txt >> @@ -4,3 +4,4 @@ python-dateutil>2.0,<3.0 >> selenium>2.0,<3.0 >> djangorestframework>=3.3,<3.4 >> drf-nested-routers>=0.11.1,<0.12 >> +sqlparse<0.2 >> -- >> 2.7.4
diff --git a/requirements-test.txt b/requirements-test.txt index cfc242f647f8..b4e8e85688fb 100644 --- a/requirements-test.txt +++ b/requirements-test.txt @@ -4,3 +4,4 @@ python-dateutil>2.0,<3.0 selenium>2.0,<3.0 djangorestframework>=3.3,<3.4 drf-nested-routers>=0.11.1,<0.12 +sqlparse<0.2
sqlparse 0.2 breaks django-debug-toolbar 1.4. Sadly, django-debug-toolbar has an unversioned dependency, so sqlparse 0.2 gets pulled in and django-debug-toolbar breaks. django-debug-toolbar 1.5 unbreaks that, but breaks Django 1.7, so we can't upgrade yet. Force sqlparse to be < 0.2 in requirements-test.txt We'll need to revisit this eventually, but it should hold for a while. Signed-off-by: Daniel Axtens <dja@axtens.net> --- requirements-test.txt | 1 + 1 file changed, 1 insertion(+)