| Message ID | 1470291041-4554-3-git-send-email-dja@axtens.net |
|---|---|
| State | Changes Requested |
| Headers | show |
On 04/08/16 16:10, Daniel Axtens wrote: > It tried to use the pbkdf2 hash as the password. Use the username instead, as that > is what create_user sets. > > Then it compared the test user username to testuser, rather than the username, which > is dynamically generated. Compare to the generated username. > > Signed-off-by: Daniel Axtens <dja@axtens.net> All looks good. Reviewed-by: Andrew Donnellan <andrew.donnellan@au1.ibm.com>
diff --git a/patchwork/tests/test_user_browser.py b/patchwork/tests/test_user_browser.py index 13503f50d959..d09b3413e737 100644 --- a/patchwork/tests/test_user_browser.py +++ b/patchwork/tests/test_user_browser.py @@ -36,7 +36,7 @@ class LoginTestCase(SeleniumTestCase): def test_login(self): self.get(reverse('auth_login')) self.enter_text('username', self.user.username) - self.enter_text('password', self.user.password) + self.enter_text('password', self.user.username) self.click('input[value="Login"]') dropdown = self.wait_until_visible('a.dropdown-toggle strong') - self.assertEqual(dropdown.text, 'testuser') + self.assertEqual(dropdown.text, self.user.username)
It tried to use the pbkdf2 hash as the password. Use the username instead, as that is what create_user sets. Then it compared the test user username to testuser, rather than the username, which is dynamically generated. Compare to the generated username. Signed-off-by: Daniel Axtens <dja@axtens.net> --- patchwork/tests/test_user_browser.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)