| Message ID | 1458841980-17014-16-git-send-email-stephen.finucane@intel.com |
|---|---|
| State | Superseded |
| Headers | show |
On 03/24/2016 12:53 PM, Stephen Finucane wrote: > Django 1.9 is the latest version so encourage devs to use this. Tests > are retained for all supported versions of Django (currently 1.6 to > 1.9). > > Signed-off-by: Stephen Finucane <stephen.finucane@intel.com> > --- > requirements-dev.txt | 2 +- > requirements-prod.txt | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/requirements-dev.txt b/requirements-dev.txt > index d52ce6f..704d2de 100644 > --- a/requirements-dev.txt > +++ b/requirements-dev.txt > @@ -1,2 +1,2 @@ > -Django<1.9,>=1.8 > +Django<1.10,>=1.9 > -r requirements-test.txt > diff --git a/requirements-prod.txt b/requirements-prod.txt > index 596eb6d..9ec9650 100644 > --- a/requirements-prod.txt > +++ b/requirements-prod.txt > @@ -1,2 +1,2 @@ > -Django<1.9,>=1.8 > +Django<1.10,>=1.9 > psycopg2==2.6.1 I know this has been debated somewhat in the past, but I wonder if 1.9 is a good "production" recommendation. The 1.8.X series is Django's LTS which will give people support for a year longer than 1.9 will. https://www.djangoproject.com/download/#supported-versions
On 24 Mar 14:48, Andy Doan wrote: > On 03/24/2016 12:53 PM, Stephen Finucane wrote: > >Django 1.9 is the latest version so encourage devs to use this. Tests > >are retained for all supported versions of Django (currently 1.6 to > >1.9). > > > >Signed-off-by: Stephen Finucane <stephen.finucane@intel.com> > >--- > > requirements-dev.txt | 2 +- > > requirements-prod.txt | 2 +- > > 2 files changed, 2 insertions(+), 2 deletions(-) > > > >diff --git a/requirements-dev.txt b/requirements-dev.txt > >index d52ce6f..704d2de 100644 > >--- a/requirements-dev.txt > >+++ b/requirements-dev.txt > >@@ -1,2 +1,2 @@ > >-Django<1.9,>=1.8 > >+Django<1.10,>=1.9 > > -r requirements-test.txt > >diff --git a/requirements-prod.txt b/requirements-prod.txt > >index 596eb6d..9ec9650 100644 > >--- a/requirements-prod.txt > >+++ b/requirements-prod.txt > >@@ -1,2 +1,2 @@ > >-Django<1.9,>=1.8 > >+Django<1.10,>=1.9 > > psycopg2==2.6.1 > > I know this has been debated somewhat in the past, but I wonder if > 1.9 is a good "production" recommendation. The 1.8.X series is > Django's LTS which will give people support for a year longer than > 1.9 will. > > https://www.djangoproject.com/download/#supported-versions I'm on the fence. The requirements file should really list all versions of Django we support, though this is obviously not possible. I figured that, since we do have test targets to ensure backwards compatibility, we might as well use the latest and greatest. However, Django 1.8 is, as you say, LTS, and it may be as good an option as any on which to base our development on. How about we list all supported upstream versions of, e.g. 'Django>=1.8,<1.10'? This is kind of like what Postorius does [1], though we will simply encourage people not to use 1.6/1.7 rather than drop support for these versions entirely yet. Stephen [1] https://gitlab.com/mailman/postorius/blob/b020644/setup.py#L37
On 03/25/2016 06:45 AM, Finucane, Stephen wrote: > On 24 Mar 14:48, Andy Doan wrote: >> On 03/24/2016 12:53 PM, Stephen Finucane wrote: >>> Django 1.9 is the latest version so encourage devs to use this. Tests >>> are retained for all supported versions of Django (currently 1.6 to >>> 1.9). >>> >>> Signed-off-by: Stephen Finucane <stephen.finucane@intel.com> >>> --- >>> requirements-dev.txt | 2 +- >>> requirements-prod.txt | 2 +- >>> 2 files changed, 2 insertions(+), 2 deletions(-) >>> >>> diff --git a/requirements-dev.txt b/requirements-dev.txt >>> index d52ce6f..704d2de 100644 >>> --- a/requirements-dev.txt >>> +++ b/requirements-dev.txt >>> @@ -1,2 +1,2 @@ >>> -Django<1.9,>=1.8 >>> +Django<1.10,>=1.9 >>> -r requirements-test.txt >>> diff --git a/requirements-prod.txt b/requirements-prod.txt >>> index 596eb6d..9ec9650 100644 >>> --- a/requirements-prod.txt >>> +++ b/requirements-prod.txt >>> @@ -1,2 +1,2 @@ >>> -Django<1.9,>=1.8 >>> +Django<1.10,>=1.9 >>> psycopg2==2.6.1 >> >> I know this has been debated somewhat in the past, but I wonder if >> 1.9 is a good "production" recommendation. The 1.8.X series is >> Django's LTS which will give people support for a year longer than >> 1.9 will. >> >> https://www.djangoproject.com/download/#supported-versions > > I'm on the fence. The requirements file should really list all versions > of Django we support, though this is obviously not possible. I figured > that, since we do have test targets to ensure backwards compatibility, > we might as well use the latest and greatest. However, Django 1.8 is, > as you say, LTS, and it may be as good an option as any on which to > base our development on. > > How about we list all supported upstream versions of, e.g. > 'Django>=1.8,<1.10'? This is kind of like what Postorius does [1], > though we will simply encourage people not to use 1.6/1.7 rather > than drop support for these versions entirely yet. +1. It was a big decision for my team to finally abandon our distro's LTS django in favor of the Django team's LTS on PyPi (for all our django apps). However, it was just becoming too painful and causing unnecessary technical debt.
diff --git a/requirements-dev.txt b/requirements-dev.txt index d52ce6f..704d2de 100644 --- a/requirements-dev.txt +++ b/requirements-dev.txt @@ -1,2 +1,2 @@ -Django<1.9,>=1.8 +Django<1.10,>=1.9 -r requirements-test.txt diff --git a/requirements-prod.txt b/requirements-prod.txt index 596eb6d..9ec9650 100644 --- a/requirements-prod.txt +++ b/requirements-prod.txt @@ -1,2 +1,2 @@ -Django<1.9,>=1.8 +Django<1.10,>=1.9 psycopg2==2.6.1
Django 1.9 is the latest version so encourage devs to use this. Tests are retained for all supported versions of Django (currently 1.6 to 1.9). Signed-off-by: Stephen Finucane <stephen.finucane@intel.com> --- requirements-dev.txt | 2 +- requirements-prod.txt | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)