diff mbox

[v2,1/4] pwclient: dict.iteritems() is deprecated in Python 3

Message ID 1445038743-50857-1-git-send-email-computersforpeace@gmail.com
State Accepted
Delegated to: Stephen Finucane
Headers show

Commit Message

Brian Norris Oct. 16, 2015, 11:39 p.m. UTC 
Just use dict.items(), since there are few fields and we don't really
care about the extra copying.

Signed-off-by: Brian Norris <computersforpeace@gmail.com>
Reviewed-by: Mike Frysinger <vapier@chromium.org>
---
v2: unchanged

 patchwork/bin/pwclient | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Stephen Finucane Oct. 20, 2015, 12:09 a.m. UTC | #1 
> Just use dict.items(), since there are few fields and we don't really
> care about the extra copying.
> 
> Signed-off-by: Brian Norris <computersforpeace@gmail.com>
> Reviewed-by: Mike Frysinger <vapier@chromium.org>

Reviewed-by: Stephen Finucane <stephen.finucane@intel.com>
Stephen Finucane Oct. 20, 2015, 12:56 a.m. UTC | #2 
> > Just use dict.items(), since there are few fields and we don't really

> > care about the extra copying.

> >

> > Signed-off-by: Brian Norris <computersforpeace@gmail.com>

> > Reviewed-by: Mike Frysinger <vapier@chromium.org>

> 

> Reviewed-by: Stephen Finucane <stephen.finucane@intel.com>


Merged. Thanks :)
diff mbox

Patch

diff --git a/patchwork/bin/pwclient b/patchwork/bin/pwclient
index d2b95e5d148d..236b237ddeb3 100755
--- a/patchwork/bin/pwclient
+++ b/patchwork/bin/pwclient
@@ -237,7 +237,7 @@  def action_info(rpc, patch_id):
     s = "Information for patch id %d" % (patch_id)
     print(s)
     print('-' * len(s))
-    for key, value in sorted(patch.iteritems()):
+    for key, value in sorted(patch.items()):
         print("- %- 14s: %s" % (key, unicode(value).encode("utf-8")))
 
 def action_get(rpc, patch_id):