From patchwork Mon Oct 12 18:54:38 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Finucane X-Patchwork-Id: 529383 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4FB431402A1 for ; Tue, 13 Oct 2015 06:24:31 +1100 (AEDT) Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 345DC1A3322 for ; Tue, 13 Oct 2015 06:24:31 +1100 (AEDT) X-Original-To: patchwork@lists.ozlabs.org Delivered-To: patchwork@lists.ozlabs.org Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by lists.ozlabs.org (Postfix) with ESMTP id 094151A0FC8 for ; Tue, 13 Oct 2015 05:54:54 +1100 (AEDT) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga101.fm.intel.com with ESMTP; 12 Oct 2015 11:54:53 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.17,674,1437462000"; d="scan'208";a="809267410" Received: from irvmail001.ir.intel.com ([163.33.26.43]) by fmsmga001.fm.intel.com with ESMTP; 12 Oct 2015 11:54:46 -0700 Received: from sivswdev01.ir.intel.com (sivswdev01.ir.intel.com [10.237.217.45]) by irvmail001.ir.intel.com (8.14.3/8.13.6/MailSET/Hub) with ESMTP id t9CIskoL021606; Mon, 12 Oct 2015 19:54:46 +0100 Received: from sivswdev01.ir.intel.com (localhost [127.0.0.1]) by sivswdev01.ir.intel.com with ESMTP id t9CIskrr013879; Mon, 12 Oct 2015 19:54:46 +0100 Received: (from sfinucan@localhost) by sivswdev01.ir.intel.com with id t9CIskvu013875; Mon, 12 Oct 2015 19:54:46 +0100 From: Stephen Finucane To: patchwork@lists.ozlabs.org Subject: [PATCH v2 5/6] views/xmlrpc: Remove unneeded '""' parameters Date: Mon, 12 Oct 2015 19:54:38 +0100 Message-Id: <1444676079-13294-6-git-send-email-stephen.finucane@intel.com> X-Mailer: git-send-email 2.0.0 In-Reply-To: <1444676079-13294-1-git-send-email-stephen.finucane@intel.com> References: <1444676079-13294-1-git-send-email-stephen.finucane@intel.com> X-BeenThere: patchwork@lists.ozlabs.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Patchwork development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: patchwork-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org Sender: "Patchwork" These don't make semantic sense: if a user didn't provide a parameter then we should check for None. Signed-off-by: Stephen Finucane --- patchwork/views/xmlrpc.py | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/patchwork/views/xmlrpc.py b/patchwork/views/xmlrpc.py index 6bebe88..806f640 100644 --- a/patchwork/views/xmlrpc.py +++ b/patchwork/views/xmlrpc.py @@ -347,7 +347,7 @@ def pw_rpc_version(): @xmlrpc_method() -def project_list(search_str='', max_count=0): +def project_list(search_str=None, max_count=0): """List projects matching a given linkname filter. Filter projects by linkname. Projects are compared to the search @@ -364,7 +364,7 @@ def project_list(search_str='', max_count=0): of all projects if no filter given. """ try: - if len(search_str) > 0: + if search_str: projects = Project.objects.filter(linkname__icontains=search_str) else: projects = Project.objects.all() @@ -398,7 +398,7 @@ def project_get(project_id): @xmlrpc_method() -def person_list(search_str="", max_count=0): +def person_list(search_str=None, max_count=0): """List persons matching a given name or email filter. Filter persons by name and email. Persons are compared to the @@ -415,7 +415,7 @@ def person_list(search_str="", max_count=0): of all persons if no filter given. """ try: - if len(search_str) > 0: + if search_str: people = (Person.objects.filter(name__icontains=search_str) | Person.objects.filter(email__icontains=search_str)) else: @@ -731,7 +731,7 @@ def patch_set(user, patch_id, params): @xmlrpc_method() -def state_list(search_str='', max_count=0): +def state_list(search_str=None, max_count=0): """List states matching a given name filter. Filter states by name. States are compared to the search string @@ -746,7 +746,7 @@ def state_list(search_str='', max_count=0): of all states if no filter given. """ try: - if len(search_str) > 0: + if search_str: states = State.objects.filter(name__icontains=search_str) else: states = State.objects.all()