diff mbox

[v2,5/6] views/xmlrpc: Remove unneeded '""' parameters

Message ID 1444676079-13294-6-git-send-email-stephen.finucane@intel.com
State Accepted
Headers show

Commit Message

Stephen Finucane Oct. 12, 2015, 6:54 p.m. UTC 
These don't make semantic sense: if a user didn't provide a parameter
then we should check for None.

Signed-off-by: Stephen Finucane <stephen.finucane@intel.com>
---
 patchwork/views/xmlrpc.py | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

Comments

Stephen Finucane Oct. 26, 2015, 9:05 p.m. UTC | #1 
> These don't make semantic sense: if a user didn't provide a parameter
> then we should check for None.
> 
> Signed-off-by: Stephen Finucane <stephen.finucane@intel.com>

Merged.
diff mbox

Patch

diff --git a/patchwork/views/xmlrpc.py b/patchwork/views/xmlrpc.py
index 6bebe88..806f640 100644
--- a/patchwork/views/xmlrpc.py
+++ b/patchwork/views/xmlrpc.py
@@ -347,7 +347,7 @@  def pw_rpc_version():
 
 
 @xmlrpc_method()
-def project_list(search_str='', max_count=0):
+def project_list(search_str=None, max_count=0):
     """List projects matching a given linkname filter.
 
     Filter projects by linkname. Projects are compared to the search
@@ -364,7 +364,7 @@  def project_list(search_str='', max_count=0):
         of all projects if no filter given.
     """
     try:
-        if len(search_str) > 0:
+        if search_str:
             projects = Project.objects.filter(linkname__icontains=search_str)
         else:
             projects = Project.objects.all()
@@ -398,7 +398,7 @@  def project_get(project_id):
 
 
 @xmlrpc_method()
-def person_list(search_str="", max_count=0):
+def person_list(search_str=None, max_count=0):
     """List persons matching a given name or email filter.
 
     Filter persons by name and email. Persons are compared to the
@@ -415,7 +415,7 @@  def person_list(search_str="", max_count=0):
         of all persons if no filter given.
     """
     try:
-        if len(search_str) > 0:
+        if search_str:
             people = (Person.objects.filter(name__icontains=search_str) |
                       Person.objects.filter(email__icontains=search_str))
         else:
@@ -731,7 +731,7 @@  def patch_set(user, patch_id, params):
 
 
 @xmlrpc_method()
-def state_list(search_str='', max_count=0):
+def state_list(search_str=None, max_count=0):
     """List states matching a given name filter.
 
     Filter states by name. States are compared to the search string
@@ -746,7 +746,7 @@  def state_list(search_str='', max_count=0):
         of all states if no filter given.
     """
     try:
-        if len(search_str) > 0:
+        if search_str:
             states = State.objects.filter(name__icontains=search_str)
         else:
             states = State.objects.all()