| Message ID | 1443276388-10502-2-git-send-email-damien.lespiau@intel.com |
|---|---|
| State | Superseded |
| Headers | show |
> DEFAULT_FROM_EMAIL is actually a django setting, not a patchwork one. > > Signed-off-by: Damien Lespiau <damien.lespiau@intel.com> Since this is a purely syntactical change, I'm going to be pedantic and say 'email' should be title-case. > +# Email Pending that change... Acked-by: Stephen Finucane <stephen.finucane@intel.com>
On Sun, Sep 27, 2015 at 11:07:55PM +0100, Finucane, Stephen wrote: > > DEFAULT_FROM_EMAIL is actually a django setting, not a patchwork one. > > > > Signed-off-by: Damien Lespiau <damien.lespiau@intel.com> > > Since this is a purely syntactical change, I'm going to be pedantic > and say 'email' should be title-case. Sigh. These kind of things really aren't very productive.
> On Sun, Sep 27, 2015 at 11:07:55PM +0100, Finucane, Stephen wrote: > > > DEFAULT_FROM_EMAIL is actually a django setting, not a patchwork one. > > > > > > Signed-off-by: Damien Lespiau <damien.lespiau@intel.com> > > > > Since this is a purely syntactical change, I'm going to be pedantic > > and say 'email' should be title-case. > > Sigh. These kind of things really aren't very productive. Sorry, I know it's time consuming but someone has to do this stuff :( > -- > Damien
On Mon, Sep 28, 2015 at 02:55:27PM +0100, Finucane, Stephen wrote: > > On Sun, Sep 27, 2015 at 11:07:55PM +0100, Finucane, Stephen wrote: > > > > DEFAULT_FROM_EMAIL is actually a django setting, not a patchwork one. > > > > > > > > Signed-off-by: Damien Lespiau <damien.lespiau@intel.com> > > > > > > Since this is a purely syntactical change, I'm going to be pedantic > > > and say 'email' should be title-case. > > > > Sigh. These kind of things really aren't very productive. > > Sorry, I know it's time consuming but someone has to do this stuff :( That's where I disagree. I don't think anyone has to nitpick on capitalization of a one word comment.
> On Mon, Sep 28, 2015 at 02:55:27PM +0100, Finucane, Stephen wrote: > > > On Sun, Sep 27, 2015 at 11:07:55PM +0100, Finucane, Stephen wrote: > > > > > DEFAULT_FROM_EMAIL is actually a django setting, not a patchwork > one. > > > > > > > > > > Signed-off-by: Damien Lespiau <damien.lespiau@intel.com> > > > > > > > > Since this is a purely syntactical change, I'm going to be pedantic > > > > and say 'email' should be title-case. > > > > > > Sigh. These kind of things really aren't very productive. > > > > Sorry, I know it's time consuming but someone has to do this stuff :( > > That's where I disagree. I don't think anyone has to nitpick on > capitalization of a one word comment. To some people it's nitpicking, to others (like me) it's due diligence. There's nothing wrong with either viewpoint: it just depends on what side of the fence you fall down on. However, I hope a small, semantic change like this is a small price to pay for keeping the only guy doing you a solid and regularly reviewing your patches happy? > -- > Damien
> > On Mon, Sep 28, 2015 at 02:55:27PM +0100, Finucane, Stephen wrote: > > > > On Sun, Sep 27, 2015 at 11:07:55PM +0100, Finucane, Stephen wrote: > > > > > > DEFAULT_FROM_EMAIL is actually a django setting, not a patchwork > > one. > > > > > > > > > > > > Signed-off-by: Damien Lespiau <damien.lespiau@intel.com> > > > > > > > > > > Since this is a purely syntactical change, I'm going to be pedantic > > > > > and say 'email' should be title-case. > > > > > > > > Sigh. These kind of things really aren't very productive. > > > > > > Sorry, I know it's time consuming but someone has to do this stuff :( > > > > That's where I disagree. I don't think anyone has to nitpick on > > capitalization of a one word comment. > > To some people it's nitpicking, to others (like me) it's due diligence. > There's nothing wrong with either viewpoint: it just depends on what side > of the fence you fall down on. However, I hope a small, semantic change > like this is a small price to pay for keeping the only guy doing you a > solid and regularly reviewing your patches happy? And thanks for doing it, BTW: I do appreciate it :) > > -- > > Damien > _______________________________________________ > Patchwork mailing list > Patchwork@lists.ozlabs.org > https://lists.ozlabs.org/listinfo/patchwork
diff --git a/patchwork/settings/base.py b/patchwork/settings/base.py index d00245d..d47cd6d 100644 --- a/patchwork/settings/base.py +++ b/patchwork/settings/base.py @@ -64,6 +64,9 @@ TEMPLATE_DIRS = ( os.path.join(ROOT_DIR, 'templates'), ) +# email + +DEFAULT_FROM_EMAIL = 'Patchwork <patchwork@patchwork.example.com>' # # Auth settings @@ -99,7 +102,6 @@ STATICFILES_DIRS = [ # DEFAULT_PATCHES_PER_PAGE = 100 -DEFAULT_FROM_EMAIL = 'Patchwork <patchwork@patchwork.example.com>' CONFIRMATION_VALIDITY_DAYS = 7
DEFAULT_FROM_EMAIL is actually a django setting, not a patchwork one. Signed-off-by: Damien Lespiau <damien.lespiau@intel.com> --- patchwork/settings/base.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)