| Message ID | 1440440620-25937-13-git-send-email-damien.lespiau@intel.com |
|---|---|
| State | Changes Requested |
| Headers | show |
The rewording of this leads to potentially poor UX. If, for example, your project is called 'patchwork' then the title bar button reads "About patchwork" - rather confusing, no? More importantly, seeing as we've already given the project name in two places: the title bar and the breadcrumb bar. How much context do people need? The current generic "Project Info" currently used is a better option. Stephen
On Wed, Sep 09, 2015 at 03:41:46PM +0100, Finucane, Stephen wrote: > The rewording of this leads to potentially poor UX. If, for example, > your project is called 'patchwork' then the title bar button reads > "About patchwork" - rather confusing, no? More importantly, seeing as > we've already given the project name in two places: the title bar and > the breadcrumb bar. How much context do people need? The current > generic "Project Info" currently used is a better option. I'm wondering if making the project name in the title bar a link to the info page wouldn't be enough.
diff --git a/templates/base.html b/templates/base.html index 30f94d4..844640a 100644 --- a/templates/base.html +++ b/templates/base.html @@ -36,6 +36,11 @@ </div> <div class="collapse navbar-collapse" id="navbar-collapse"> <ul class="nav navbar-nav navbar-right"> +{% if project %} + <li><a href="{% url 'patchwork.views.project.project' project_id=project.linkname %}" + >about {{ project.linkname }}</a></li> + <li><p class="navbar-text">|</p></li> +{% endif %} {% if user.is_authenticated %} <li><p class="navbar-text">Logged in as <a href="{% url 'patchwork.views.user.profile' %}" ><strong>{{ user.username }}</strong></a></p></li> @@ -62,9 +67,6 @@ : <a href="{% url 'patchwork.views.patch.list' project_id=project.linkname %}" >patches</a> - : - <a href="{% url 'patchwork.views.project.project' project_id=project.linkname %}" - >project info</a> {% if other_projects %} : <a href="{% url 'patchwork.views.projects' %}"
The goal is still to have a proper breadcrumb bar. One more little step towards it. Signed-off-by: Damien Lespiau <damien.lespiau@intel.com> --- templates/base.html | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-)