diff mbox series

[ovs-dev] automake: Make system tests dependent of ovn-macro.

Message ID 20240326115618.3433176-1-xsimonar@redhat.com
State Accepted
Headers show
Series [ovs-dev] automake: Make system tests dependent of ovn-macro. | expand

Checks

Context Check Description
ovsrobot/apply-robot success apply and check: success
ovsrobot/github-robot-_Build_and_Test success github build: passed
ovsrobot/github-robot-_ovn-kubernetes success github build: passed

Commit Message

Xavier Simonart March 26, 2024, 11:56 a.m. UTC
So system testsuite will be recompiled when ovn-macro is changed.

Signed-off-by: Xavier Simonart <xsimonar@redhat.com>
---
 tests/automake.mk | 1 +
 1 file changed, 1 insertion(+)

Comments

Ales Musil March 28, 2024, 8:37 a.m. UTC | #1
On Tue, Mar 26, 2024 at 12:56 PM Xavier Simonart <xsimonar@redhat.com>
wrote:

> So system testsuite will be recompiled when ovn-macro is changed.
>
> Signed-off-by: Xavier Simonart <xsimonar@redhat.com>
> ---
>  tests/automake.mk | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/tests/automake.mk b/tests/automake.mk
> index f6f0f0e33..1fdc89835 100644
> --- a/tests/automake.mk
> +++ b/tests/automake.mk
> @@ -21,6 +21,7 @@ EXTRA_DIST += \
>  COMMON_MACROS_AT = \
>         tests/ovsdb-macros.at \
>         tests/ovs-macros.at \
> +       tests/ovn-macros.at \
>         tests/ofproto-macros.at
>
>  TESTSUITE_AT = \
> --
> 2.31.1
>
> _______________________________________________
> dev mailing list
> dev@openvswitch.org
> https://mail.openvswitch.org/mailman/listinfo/ovs-dev
>
>
Ran into this multiple times, but always forgot to fix it, thanks!

Acked-by: Ales Musil <amusil@redhat.com>
Mark Michelson April 4, 2024, 8:24 p.m. UTC | #2
Thank you Xavier and Ales.

I pushed this change to main and all branches back to 23.06.

On 3/28/24 04:37, Ales Musil wrote:
> On Tue, Mar 26, 2024 at 12:56 PM Xavier Simonart <xsimonar@redhat.com>
> wrote:
> 
>> So system testsuite will be recompiled when ovn-macro is changed.
>>
>> Signed-off-by: Xavier Simonart <xsimonar@redhat.com>
>> ---
>>   tests/automake.mk | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/tests/automake.mk b/tests/automake.mk
>> index f6f0f0e33..1fdc89835 100644
>> --- a/tests/automake.mk
>> +++ b/tests/automake.mk
>> @@ -21,6 +21,7 @@ EXTRA_DIST += \
>>   COMMON_MACROS_AT = \
>>          tests/ovsdb-macros.at \
>>          tests/ovs-macros.at \
>> +       tests/ovn-macros.at \
>>          tests/ofproto-macros.at
>>
>>   TESTSUITE_AT = \
>> --
>> 2.31.1
>>
>> _______________________________________________
>> dev mailing list
>> dev@openvswitch.org
>> https://mail.openvswitch.org/mailman/listinfo/ovs-dev
>>
>>
> Ran into this multiple times, but always forgot to fix it, thanks!
> 
> Acked-by: Ales Musil <amusil@redhat.com>
>
diff mbox series

Patch

diff --git a/tests/automake.mk b/tests/automake.mk
index f6f0f0e33..1fdc89835 100644
--- a/tests/automake.mk
+++ b/tests/automake.mk
@@ -21,6 +21,7 @@  EXTRA_DIST += \
 COMMON_MACROS_AT = \
 	tests/ovsdb-macros.at \
 	tests/ovs-macros.at \
+	tests/ovn-macros.at \
 	tests/ofproto-macros.at
 
 TESTSUITE_AT = \