| Message ID | 20240325165842.509044-2-jtanenba@redhat.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [ovs-dev,1/2] Merge QoS logical pipelines | expand |
| Context | Check | Description |
|---|---|---|
| ovsrobot/apply-robot | warning | apply and check: warning |
| ovsrobot/github-robot-_Build_and_Test | success | github build: passed |
| ovsrobot/github-robot-_ovn-kubernetes | success | github build: passed |
On Mon, Mar 25, 2024 at 5:59 PM Jacob Tanenbaum <jtanenba@redhat.com> wrote: Hi Jacob, thank you for the patch. Please address the 0-day bot concerns in v2. commit: 1807499 changed the testing to get the table numbers themselves. > We use the following tag to indicate that the commit is fixing some previous one: Fixes: 180749965eda ("tests: Use the ovn-debug binary to determine table numbers.") This tag goes before the Signed-off-by and you can easily get it by running: git log -1 --pretty=format:"Fixes: %h (\"%s\")" --abbrev=12 <TAG> > The table number was left in here. This patch corrects that and removes > the table number. > > Signed-off-by: Jacob Tanenbaum <jtanenba@redhat.com> > --- > tests/ovn.at | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tests/ovn.at b/tests/ovn.at > index f04b74210..762b12a7b 100644 > --- a/tests/ovn.at > +++ b/tests/ovn.at > @@ -37684,7 +37684,7 @@ tpa=$(ip_to_hex 10 0 0 10) > send_garp 1 1 $eth_src $eth_dst $spa $tpa > > OVS_WAIT_UNTIL([test 1 = `cat hv1/ovn-controller.log | grep "pinctrl > received packet-in" | \ > -grep opcode=BIND_VPORT | grep OF_Table_ID=28 | wc -l`]) > +grep opcode=BIND_VPORT | grep OF_Table_ID=$(ovn-debug > lflow-stage-to-oftable ls_in_arp_rsp) | wc -l`]) > There is one more at https://github.com/ovn-org/ovn/blob/dc52bf70cb7e066fdb84d88622d7f380eda18e8c/tests/ovn.at#L22074, please address that one too. > > sleep_controller hv1 > > -- > 2.42.0 > > _______________________________________________ > dev mailing list > dev@openvswitch.org > https://mail.openvswitch.org/mailman/listinfo/ovs-dev > > Thanks, Ales
diff --git a/tests/ovn.at b/tests/ovn.at index f04b74210..762b12a7b 100644 --- a/tests/ovn.at +++ b/tests/ovn.at @@ -37684,7 +37684,7 @@ tpa=$(ip_to_hex 10 0 0 10) send_garp 1 1 $eth_src $eth_dst $spa $tpa OVS_WAIT_UNTIL([test 1 = `cat hv1/ovn-controller.log | grep "pinctrl received packet-in" | \ -grep opcode=BIND_VPORT | grep OF_Table_ID=28 | wc -l`]) +grep opcode=BIND_VPORT | grep OF_Table_ID=$(ovn-debug lflow-stage-to-oftable ls_in_arp_rsp) | wc -l`]) sleep_controller hv1
commit: 1807499 changed the testing to get the table numbers themselves. The table number was left in here. This patch corrects that and removes the table number. Signed-off-by: Jacob Tanenbaum <jtanenba@redhat.com> --- tests/ovn.at | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)