diff mbox series

[ovs-dev,11/15] tests: fixed "send gratuitous ARP for NAT rules on HA distributed router"

Message ID 20230918164714.3144984-12-xsimonar@redhat.com
State Accepted
Headers show
Series Fixed another set of flaky Unit Tests | expand

Checks

Context Check Description
ovsrobot/apply-robot success apply and check: success
ovsrobot/github-robot-_Build_and_Test success github build: passed
ovsrobot/github-robot-_ovn-kubernetes fail github build: failed

Commit Message

Xavier Simonart Sept. 18, 2023, 4:47 p.m. UTC 
Fixes: 0c89c0fddb4f ("tests: fixed another flake in "send gratuitous ARP for NAT rules on HA distributed router"")

Signed-off-by: Xavier Simonart <xsimonar@redhat.com>
---
 tests/ovn.at | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)
diff mbox series

Patch

diff --git a/tests/ovn.at b/tests/ovn.at
index 8ebf55580..d4e0016e5 100644
--- a/tests/ovn.at
+++ b/tests/ovn.at
@@ -13824,9 +13824,6 @@  AT_CHECK([grep $garp hv3_br_phys_tx | sort], [0], [])
 
 # at this point, we invert the priority of the gw chassis between hv2 and hv3
 
-# Reset hv2/br-phys_n1 before inverting gw chassis, as otherwise packets might
-# be reset (while not resetting hv1/snoopvif because not yet sent).
-as hv2 reset_pcap_file br-phys_n1 hv2/br-phys_n1
 ovn-nbctl --wait=hv \
           --id=@gc0 create Gateway_Chassis \
                     name=outside_gw1 chassis_name=hv2 priority=1 -- \
@@ -13834,6 +13831,11 @@  ovn-nbctl --wait=hv \
                     name=outside_gw2 chassis_name=hv3 priority=10 -- \
           set Logical_Router_Port lrp0 'gateway_chassis=[@gc0,@gc1]'
 
+# We expect not to receive garp on hv2 after inverting the priority.
+# Hence  reset hv2 after inverting priority as otherwise a garp might
+# be received on hv2 between the reset and the priority change.
+
+as hv2 reset_pcap_file br-phys_n1 hv2/br-phys_n1
 as hv3 reset_pcap_file br-phys_n1 hv3/br-phys_n1
 as hv1 reset_pcap_file snoopvif hv1/snoopvif