From patchwork Wed Aug 16 22:26:25 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ilya Maximets X-Patchwork-Id: 1822060 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=openvswitch.org (client-ip=2605:bc80:3010::137; helo=smtp4.osuosl.org; envelope-from=ovs-dev-bounces@openvswitch.org; receiver=patchwork.ozlabs.org) Received: from smtp4.osuosl.org (smtp4.osuosl.org [IPv6:2605:bc80:3010::137]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4RR2lx2rQ6z1ygD for ; Thu, 17 Aug 2023 08:26:05 +1000 (AEST) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id A81C042174; Wed, 16 Aug 2023 22:26:02 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org A81C042174 X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id QVpj5bzI9kzx; Wed, 16 Aug 2023 22:26:01 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [IPv6:2605:bc80:3010:104::8cd3:938]) by smtp4.osuosl.org (Postfix) with ESMTPS id 88F7C42152; Wed, 16 Aug 2023 22:25:59 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org 88F7C42152 Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 5579DC0DD6; Wed, 16 Aug 2023 22:25:57 +0000 (UTC) X-Original-To: ovs-dev@openvswitch.org Delivered-To: ovs-dev@lists.linuxfoundation.org Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by lists.linuxfoundation.org (Postfix) with ESMTP id 95B71C0032 for ; Wed, 16 Aug 2023 22:25:56 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id 62BD04214B for ; Wed, 16 Aug 2023 22:25:56 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org 62BD04214B X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id IVi5Y0hNnrOF for ; Wed, 16 Aug 2023 22:25:55 +0000 (UTC) Received: from relay1-d.mail.gandi.net (relay1-d.mail.gandi.net [217.70.183.193]) by smtp4.osuosl.org (Postfix) with ESMTPS id EB4C74206F for ; Wed, 16 Aug 2023 22:25:54 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org EB4C74206F Received: by mail.gandi.net (Postfix) with ESMTPSA id F0A97240002; Wed, 16 Aug 2023 22:25:52 +0000 (UTC) From: Ilya Maximets To: ovs-dev@openvswitch.org Date: Thu, 17 Aug 2023 00:26:25 +0200 Message-Id: <20230816222627.3873712-2-i.maximets@ovn.org> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20230816222627.3873712-1-i.maximets@ovn.org> References: <20230816222627.3873712-1-i.maximets@ovn.org> MIME-Version: 1.0 X-GND-Sasl: i.maximets@ovn.org Cc: Ilya Maximets Subject: [ovs-dev] [PATCH ovn 1/3] m4: Replace obsolete AC_HELP_STRING with AS_HELP_STRING. X-BeenThere: ovs-dev@openvswitch.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: ovs-dev-bounces@openvswitch.org Sender: "dev" AS_HELP_STRING is a direct replacement for AC_HELP_STRING. It is available since autoconf 2.57a. OVN requires 2.63, so AS_HELP_STRING can be freely used. This fixes the following warning on systems with 2.70+: $ ./boot.sh ... configure.ac:88: warning: The macro `AC_HELP_STRING' is obsolete. configure.ac:88: You should run autoupdate. ... Signed-off-by: Ilya Maximets --- acinclude.m4 | 14 +++++++------- m4/ovn.m4 | 16 ++++++++-------- 2 files changed, 15 insertions(+), 15 deletions(-) diff --git a/acinclude.m4 b/acinclude.m4 index 3e4a54086..4198120bc 100644 --- a/acinclude.m4 +++ b/acinclude.m4 @@ -18,7 +18,7 @@ dnl OVS_ENABLE_WERROR AC_DEFUN([OVS_ENABLE_WERROR], [AC_ARG_ENABLE( [Werror], - [AC_HELP_STRING([--enable-Werror], [Add -Werror to CFLAGS])], + [AS_HELP_STRING([--enable-Werror], [Add -Werror to CFLAGS])], [], [enable_Werror=no]) AC_CONFIG_COMMANDS_PRE( [if test "X$enable_Werror" = Xyes; then @@ -54,7 +54,7 @@ AC_DEFUN([OVS_CHECK_DDLOG], [ AC_ARG_VAR([DDLOG_HOME], [Root of the DDlog installation]) AC_ARG_WITH( [ddlog], - [AC_HELP_STRING([--with-ddlog[[=INSTALLDIR|LIBDIR]]], [Enables DDlog])], + [AS_HELP_STRING([--with-ddlog[[=INSTALLDIR|LIBDIR]]], [Enables DDlog])], [DDLOG_PATH=$PATH if test "$withval" = yes; then # --with-ddlog: $DDLOG_HOME must be set @@ -321,7 +321,7 @@ AC_DEFUN([OVS_ENABLE_SPARSE], AC_ARG_ENABLE( [sparse], - [AC_HELP_STRING([--enable-sparse], [Run "sparse" by default])], + [AS_HELP_STRING([--enable-sparse], [Run "sparse" by default])], [], [enable_sparse=no]) AM_CONDITIONAL([ENABLE_SPARSE_BY_DEFAULT], [test $enable_sparse = yes])]) @@ -400,10 +400,10 @@ dnl dnl Check for OVS sources AC_DEFUN([OVN_CHECK_OVS], [ AC_ARG_WITH([ovs-source], - [AC_HELP_STRING([--with-ovs-source=/path/to/ovs/src/dir], + [AS_HELP_STRING([--with-ovs-source=/path/to/ovs/src/dir], [Specify the OVS src directory])]) AC_ARG_WITH([ovs-build], - [AC_HELP_STRING([--with-ovs-build=/path/to/ovs/build/dir], + [AS_HELP_STRING([--with-ovs-build=/path/to/ovs/build/dir], [Specify the OVS build directory])]) AC_MSG_CHECKING([for OVS source directory]) @@ -449,7 +449,7 @@ AC_DEFUN([OVN_CHECK_VIF_PLUG_PROVIDER], [ AC_ARG_VAR([VIF_PLUG_PROVIDER]) AC_ARG_WITH( [vif-plug-provider], - [AC_HELP_STRING([--with-vif-plug-provider=/path/to/provider/repository], + [AS_HELP_STRING([--with-vif-plug-provider=/path/to/provider/repository], [Specify path to a configured and built VIF plug provider repository])], [if test "$withval" = yes; then if test -z "$VIF_PLUG_PROVIDER"; then @@ -482,7 +482,7 @@ dnl Enable built-in plug providers AC_DEFUN([OVN_ENABLE_VIF_PLUG], [ AC_ARG_ENABLE( [vif-plug-providers], - [AC_HELP_STRING([--enable-vif-plug-providers], [Enable building of built-in VIF plug providers])], + [AS_HELP_STRING([--enable-vif-plug-providers], [Enable building of built-in VIF plug providers])], [], [enable_vif_plug=no]) AM_CONDITIONAL([ENABLE_VIF_PLUG], [test "$enable_vif_plug" != no]) if test "$enable_vif_plug" != no; then diff --git a/m4/ovn.m4 b/m4/ovn.m4 index a92f4ceda..902865c58 100644 --- a/m4/ovn.m4 +++ b/m4/ovn.m4 @@ -21,7 +21,7 @@ AC_DEFUN([OVN_CHECK_COVERAGE], [AC_REQUIRE([AC_PROG_CC]) AC_ARG_ENABLE( [coverage], - [AC_HELP_STRING([--enable-coverage], + [AS_HELP_STRING([--enable-coverage], [Enable gcov coverage tool.])], [case "${enableval}" in (yes) coverage=true ;; @@ -50,7 +50,7 @@ dnl Checks for --enable-ndebug and defines NDEBUG if it is specified. AC_DEFUN([OVS_CHECK_NDEBUG], [AC_ARG_ENABLE( [ndebug], - [AC_HELP_STRING([--enable-ndebug], + [AS_HELP_STRING([--enable-ndebug], [Disable debugging features for max performance])], [case "${enableval}" in (yes) ndebug=true ;; @@ -197,7 +197,7 @@ dnl Checks for OpenSSL. AC_DEFUN([OVS_CHECK_OPENSSL], [AC_ARG_ENABLE( [ssl], - [AC_HELP_STRING([--disable-ssl], [Disable OpenSSL support])], + [AS_HELP_STRING([--disable-ssl], [Disable OpenSSL support])], [case "${enableval}" in (yes) ssl=true ;; (no) ssl=false ;; @@ -249,7 +249,7 @@ dnl Checks for the directory in which to store the PKI. AC_DEFUN([OVS_CHECK_PKIDIR], [AC_ARG_WITH( [pkidir], - AC_HELP_STRING([--with-pkidir=DIR], + AS_HELP_STRING([--with-pkidir=DIR], [PKI hierarchy directory [[LOCALSTATEDIR/lib/openvswitch/pki]]]), [PKIDIR=$withval], [PKIDIR='${localstatedir}/lib/openvswitch/pki']) @@ -259,7 +259,7 @@ dnl Checks for the directory in which to store pidfiles. AC_DEFUN([OVN_CHECK_RUNDIR], [AC_ARG_WITH( [rundir], - AC_HELP_STRING([--with-rundir=DIR], + AS_HELP_STRING([--with-rundir=DIR], [directory used for pidfiles [[LOCALSTATEDIR/run/ovn]]]), [OVN_RUNDIR=$withval], @@ -270,7 +270,7 @@ dnl Checks for the directory in which to store logs. AC_DEFUN([OVN_CHECK_LOGDIR], [AC_ARG_WITH( [logdir], - AC_HELP_STRING([--with-logdir=DIR], + AS_HELP_STRING([--with-logdir=DIR], [directory used for logs [[LOCALSTATEDIR/log/PACKAGE]]]), [LOGDIR=$withval], [LOGDIR='${localstatedir}/log/${PACKAGE}']) @@ -280,7 +280,7 @@ dnl Checks for the directory in which to store the OVN database. AC_DEFUN([OVN_CHECK_DBDIR], [AC_ARG_WITH( [dbdir], - AC_HELP_STRING([--with-dbdir=DIR], + AS_HELP_STRING([--with-dbdir=DIR], [directory used for conf.db [[SYSCONFDIR/PACKAGE]]]), [DBDIR=$withval], [DBDIR='${sysconfdir}/${PACKAGE}']) @@ -581,7 +581,7 @@ dnl Checks for --enable-ddlog-fast-build and updates DDLOG_EXTRA_RUSTFLAGS. AC_DEFUN([OVS_CHECK_DDLOG_FAST_BUILD], [AC_ARG_ENABLE( [ddlog_fast_build], - [AC_HELP_STRING([--enable-ddlog-fast-build], + [AS_HELP_STRING([--enable-ddlog-fast-build], [Build ddlog programs faster, but generate slower code])], [case "${enableval}" in (yes) ddlog_fast_build=true ;;