| Message ID | 20230814135401.2677054-1-dceara@redhat.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [ovs-dev] NEWS: Add note about L4_SYM being used by default for ECMP. | expand |
| Context | Check | Description |
|---|---|---|
| ovsrobot/apply-robot | success | apply and check: success |
| ovsrobot/github-robot-_Build_and_Test | success | github build: passed |
| ovsrobot/github-robot-_ovn-kubernetes | fail | github build: failed |
On Mon, Aug 14, 2023 at 6:54 AM Dumitru Ceara <dceara@redhat.com> wrote: > > Fixes: 596ea7acbe68 ("ovn-controller: Detect and use L4_SYM dp-hash if available.") > Signed-off-by: Dumitru Ceara <dceara@redhat.com> > --- > NEWS | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/NEWS b/NEWS > index 8275877f99..f99334c1b8 100644 > --- a/NEWS > +++ b/NEWS > @@ -10,6 +10,9 @@ Post v23.06.0 > - To allow optimizing ovn-controller's monitor conditions for the regular > VIF case, ovn-controller now unconditionally monitors all sub-ports > (ports with parent_port set). > + - ECMP routes use L4_SYM dp-hash by default if the datapath supports it. > + Existing sessions might get re-hashed to a different ECMP path when > + OVN detects the algorithm support in the datapath. nit: probably add "during the upgrade" to avoid misunderstanding. Acked-by: Han Zhou <hzhou@ovn.org> > > OVN v23.06.0 - 01 Jun 2023 > -------------------------- > -- > 2.31.1 >
On 8/14/23 12:25, Han Zhou wrote: > On Mon, Aug 14, 2023 at 6:54 AM Dumitru Ceara <dceara@redhat.com> wrote: >> >> Fixes: 596ea7acbe68 ("ovn-controller: Detect and use L4_SYM dp-hash if > available.") >> Signed-off-by: Dumitru Ceara <dceara@redhat.com> >> --- >> NEWS | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/NEWS b/NEWS >> index 8275877f99..f99334c1b8 100644 >> --- a/NEWS >> +++ b/NEWS >> @@ -10,6 +10,9 @@ Post v23.06.0 >> - To allow optimizing ovn-controller's monitor conditions for the > regular >> VIF case, ovn-controller now unconditionally monitors all sub-ports >> (ports with parent_port set). >> + - ECMP routes use L4_SYM dp-hash by default if the datapath supports > it. >> + Existing sessions might get re-hashed to a different ECMP path when >> + OVN detects the algorithm support in the datapath. > > nit: probably add "during the upgrade" to avoid misunderstanding. > > Acked-by: Han Zhou <hzhou@ovn.org> I updated the sentence to be "Existing sessions might get re-hashed to a different ECMP path when OVN detects the algorithm support in the datapath during an upgrade or restart of ovn-controller." I pushed the change to main. Thanks Dumitru and Han. > >> >> OVN v23.06.0 - 01 Jun 2023 >> -------------------------- >> -- >> 2.31.1 >> > _______________________________________________ > dev mailing list > dev@openvswitch.org > https://mail.openvswitch.org/mailman/listinfo/ovs-dev
On 8/14/23 21:01, Mark Michelson wrote: > On 8/14/23 12:25, Han Zhou wrote: >> On Mon, Aug 14, 2023 at 6:54 AM Dumitru Ceara <dceara@redhat.com> wrote: >>> >>> Fixes: 596ea7acbe68 ("ovn-controller: Detect and use L4_SYM dp-hash if >> available.") >>> Signed-off-by: Dumitru Ceara <dceara@redhat.com> >>> --- >>> NEWS | 3 +++ >>> 1 file changed, 3 insertions(+) >>> >>> diff --git a/NEWS b/NEWS >>> index 8275877f99..f99334c1b8 100644 >>> --- a/NEWS >>> +++ b/NEWS >>> @@ -10,6 +10,9 @@ Post v23.06.0 >>> - To allow optimizing ovn-controller's monitor conditions for the >> regular >>> VIF case, ovn-controller now unconditionally monitors all >>> sub-ports >>> (ports with parent_port set). >>> + - ECMP routes use L4_SYM dp-hash by default if the datapath supports >> it. >>> + Existing sessions might get re-hashed to a different ECMP path when >>> + OVN detects the algorithm support in the datapath. >> >> nit: probably add "during the upgrade" to avoid misunderstanding. >> >> Acked-by: Han Zhou <hzhou@ovn.org> > > I updated the sentence to be "Existing sessions might get re-hashed to a > different ECMP path when OVN detects the algorithm support in the > datapath during an upgrade or restart of ovn-controller." > > I pushed the change to main. Thanks Dumitru and Han. > Thanks, Han, Mark!
diff --git a/NEWS b/NEWS index 8275877f99..f99334c1b8 100644 --- a/NEWS +++ b/NEWS @@ -10,6 +10,9 @@ Post v23.06.0 - To allow optimizing ovn-controller's monitor conditions for the regular VIF case, ovn-controller now unconditionally monitors all sub-ports (ports with parent_port set). + - ECMP routes use L4_SYM dp-hash by default if the datapath supports it. + Existing sessions might get re-hashed to a different ECMP path when + OVN detects the algorithm support in the datapath. OVN v23.06.0 - 01 Jun 2023 --------------------------
Fixes: 596ea7acbe68 ("ovn-controller: Detect and use L4_SYM dp-hash if available.") Signed-off-by: Dumitru Ceara <dceara@redhat.com> --- NEWS | 3 +++ 1 file changed, 3 insertions(+)