diff mbox series

[ovs-dev] ovn-controller docs: fix typo in ovn-monitor-all description

Message ID 20230505084003.4028115-1-odivlad@gmail.com
State Accepted
Headers show
Series [ovs-dev] ovn-controller docs: fix typo in ovn-monitor-all description | expand

Checks

Context Check Description
ovsrobot/apply-robot success apply and check: success
ovsrobot/github-robot-_Build_and_Test success github build: passed
ovsrobot/github-robot-_ovn-kubernetes success github build: passed

Commit Message

Vladislav Odintsov May 5, 2023, 8:40 a.m. UTC
Make it more clear that ovn-monitor-all option has effect on OVN Southbound
database rather than local OVS.

Reported-at: https://mail.openvswitch.org/pipermail/ovs-discuss/2023-May/052421.html
Reported-by: Ilya Maximets <i.maximets@ovn.org>
Signed-off-by: Vladislav Odintsov <odivlad@gmail.com>
---
 controller/ovn-controller.8.xml | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

Comments

Simon Horman May 16, 2023, 3:46 p.m. UTC | #1
On Fri, May 05, 2023 at 11:40:03AM +0300, Vladislav Odintsov wrote:
> Make it more clear that ovn-monitor-all option has effect on OVN Southbound
> database rather than local OVS.
> 
> Reported-at: https://mail.openvswitch.org/pipermail/ovs-discuss/2023-May/052421.html
> Reported-by: Ilya Maximets <i.maximets@ovn.org>
> Signed-off-by: Vladislav Odintsov <odivlad@gmail.com>

Reviewed-by: Simon Horman <simon.horman@corigine.com>
Dumitru Ceara May 17, 2023, 3:07 p.m. UTC | #2
On 5/16/23 17:46, Simon Horman wrote:
> On Fri, May 05, 2023 at 11:40:03AM +0300, Vladislav Odintsov wrote:
>> Make it more clear that ovn-monitor-all option has effect on OVN Southbound
>> database rather than local OVS.
>>
>> Reported-at: https://mail.openvswitch.org/pipermail/ovs-discuss/2023-May/052421.html
>> Reported-by: Ilya Maximets <i.maximets@ovn.org>
>> Signed-off-by: Vladislav Odintsov <odivlad@gmail.com>
> 
> Reviewed-by: Simon Horman <simon.horman@corigine.com>
> 

Thanks, Vladislav, Simon and Ilya!  I applied this to the main branch
and backported it to all stable branches down to 22.03 LTS.

Regards,
Dumitru
diff mbox series

Patch

diff --git a/controller/ovn-controller.8.xml b/controller/ovn-controller.8.xml
index ab52e2d34..7c0855603 100644
--- a/controller/ovn-controller.8.xml
+++ b/controller/ovn-controller.8.xml
@@ -121,11 +121,11 @@ 
           that is needed in the current chassis.
         </p>
         <p>
-          It is more optimal to set it to <code>true</code> in use cases when
-          the chassis would anyway need to monitor most of the records in
-          <var>ovs-database</var>, which would save the overhead of conditions
-          processing, especially for server side.  Typically, set it to
-          <code>true</code> for environments that all workloads need to be
+          It is more efficient to set it to <code>true</code> in use cases
+          where the chassis would anyway need to monitor most of the records in
+          <var>OVN Southbound</var> database, which would save the overhead of
+          conditions processing, especially for server side.  Typically, set it
+          to <code>true</code> for environments that all workloads need to be
           reachable from each other.
         </p>
         <p>