diff mbox series

[ovs-dev,branch-21.12,1/2] system-ovn: fix CoPP test failures

Message ID 20230110220313.3525167-1-odivlad@gmail.com
State Accepted
Headers show
Series [ovs-dev,branch-21.12,1/2] system-ovn: fix CoPP test failures | expand

Checks

Context Check Description
ovsrobot/apply-robot warning apply and check: warning
ovsrobot/github-robot-_Build_and_Test fail github build: failed
ovsrobot/github-robot-_ovn-kubernetes fail github build: failed

Commit Message

Vladislav Odintsov Jan. 10, 2023, 10:03 p.m. UTC 
From: Lorenzo Bianconi <lorenzo.bianconi@redhat.com>

Meter bucket configuration has been fixed in ovs commit
7d742b509dd7 ("openvswitch: meter: remove rate from the
bucket size calculation"). Fix CoPP system test failures due to new ovs
datapath behaviour.

Reported-at: https://bugzilla.redhat.com/show_bug.cgi?id=2073060
Signed-off-by: Lorenzo Bianconi <lorenzo.bianconi@redhat.com>
Acked-by: Dumitru Ceara <dceara@redhat.com>
Signed-off-by: Numan Siddique <numans@ovn.org>
(cherry picked from commit e922c05dbb0c0ca70c98bd0b24833248ff5d458b)
Signed-off-by: Vladislav Odintsov <odivlad@gmail.com>
---
 tests/system-ovn.at | 24 ++++++++++++------------
 1 file changed, 12 insertions(+), 12 deletions(-)

Comments

0-day Robot Jan. 10, 2023, 10:25 p.m. UTC | #1 
Bleep bloop.  Greetings Vladislav Odintsov, I am a robot and I have tried out your patch.
Thanks for your contribution.

I encountered some error that I wasn't expecting.  See the details below.


checkpatch:
WARNING: Unexpected sign-offs from developers who are not authors or co-authors or committers: Numan Siddique <numans@ovn.org>, Vladislav Odintsov <odivlad@gmail.com>
Lines checked: 103, Warnings: 1, Errors: 0


Please check this out.  If you feel there has been an error, please email aconole@redhat.com

Thanks,
0-day Robot
diff mbox series

Patch

diff --git a/tests/system-ovn.at b/tests/system-ovn.at
index bdd8790b0..c9c0f3948 100644
--- a/tests/system-ovn.at
+++ b/tests/system-ovn.at
@@ -6945,10 +6945,10 @@  p = IP(src="192.168.1.2", dst="192.168.1.1") / UDP(dport = 12345) / Raw(b"X"*64)
 send (p, iface='sw01', loop = 0, verbose = 0, count = 20)
 EOF
 
-# 1pps + 1 burst size
+# 1pps
 OVS_WAIT_UNTIL([
     n_reject=$(grep unreachable reject.pcap | wc -l)
-    test "${n_reject}" = "2"
+    test "${n_reject}" = "1"
 ])
 kill $(pidof tcpdump)
 rm -f reject.pcap
@@ -6961,10 +6961,10 @@  p = IP(src="192.168.1.2", dst="192.168.1.1") / UDP(dport = 12345) / Raw(b"X"*64)
 send (p, iface='sw01', loop = 0, verbose = 0, count = 100)
 EOF
 
-# 10pps + 1 burst size
+# 10pps
 OVS_WAIT_UNTIL([
     n_reject=$(grep unreachable reject.pcap | wc -l)
-    test "${n_reject}" = "20"
+    test "${n_reject}" = "10"
 ])
 
 kill $(pidof tcpdump)
@@ -6996,10 +6996,10 @@  p = IP(src="192.168.1.2", dst="172.16.1.100") / TCP(dport = 80, flags="S") / Raw
 send (p, iface='sw01', loop = 0, verbose = 0, count = 100)
 EOF
 
-# 1pps + 1 burst size
+# 1pps
 OVS_WAIT_UNTIL([
     n_arp=$(grep ARP arp.pcap | wc -l)
-    test "${n_arp}" = "2"
+    test "${n_arp}" = "1"
 ])
 kill $(pidof tcpdump)
 
@@ -7015,10 +7015,10 @@  p = IP(src="192.168.1.2", dst="172.16.1.100", ttl=1) / TCP(dport = 8080, flags="
 send (p, iface='sw01', loop = 0, verbose = 0, count = 100)
 EOF
 
-# 1pps + 1 burst size
+# 1pps
 OVS_WAIT_UNTIL([
     n_icmp=$(grep ICMP icmp.pcap | wc -l)
-    test "${n_icmp}" = "2"
+    test "${n_icmp}" = "1"
 ])
 kill $(pidof tcpdump)
 
@@ -7030,7 +7030,7 @@  bfd: bfd-meter
 
 check ovn-nbctl --bfd lr-route-add R1 240.0.0.0/8 172.16.1.50 rp-public
 printf "%08x" $(ovn-sbctl get bfd . disc) > /tmp/disc
-NS_EXEC([server], [tcpdump -l -n -i s1 udp port 3784 -Q in > bfd.pcap &])
+NS_EXEC([server], [tcpdump -l -nn -i s1 udp port 3784 and ip[[29]]==0x90 -Q in > bfd.pcap &])
 ip netns exec server scapy -H <<-EOF
 import binascii
 f = open("/tmp/disc", "r")
@@ -7043,10 +7043,10 @@  f.close()
 EOF
 rm /tmp/disc
 
-# 1pps + 1 burst size
+# 1pps
 OVS_WAIT_UNTIL([
-    n_tcp_rst=$(grep Final bfd.pcap | wc -l)
-    test "${n_tcp_rst}" = "2"
+    n_bfd=$(grep 3784 bfd.pcap | wc -l)
+    test "${n_bfd}" = "1"
 ])
 kill $(pidof tcpdump)