| Message ID | 20220810080426.799785-1-dceara@redhat.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [ovs-dev] system-ovn: Fix the "Load balancer for container ports" test. | expand |
| Context | Check | Description |
|---|---|---|
| ovsrobot/apply-robot | success | apply and check: success |
| ovsrobot/github-robot-_Build_and_Test | success | github build: passed |
| ovsrobot/github-robot-_ovn-kubernetes | fail | github build: failed |
On 8/10/22 10:04, Dumitru Ceara wrote: > It doesn't really need the load balancer applied on the logical router. > As a matter of fact, load balancers are not supported on distributed > routers without distributed gateway ports: > > https://github.com/ovn-org/ovn/blob/4dc4bc7fdb848bcc626becbd2c80ffef8a39ff9a/ovn-nb.xml#L2223 > > Signed-off-by: Dumitru Ceara <dceara@redhat.com> > --- Acked-by: Dumitru Ceara <dceara@redhat.com> Thanks!
On 8/10/22 10:13, Dumitru Ceara wrote: > On 8/10/22 10:04, Dumitru Ceara wrote: >> It doesn't really need the load balancer applied on the logical router. >> As a matter of fact, load balancers are not supported on distributed >> routers without distributed gateway ports: >> >> https://github.com/ovn-org/ovn/blob/4dc4bc7fdb848bcc626becbd2c80ffef8a39ff9a/ovn-nb.xml#L2223 >> >> Signed-off-by: Dumitru Ceara <dceara@redhat.com> >> --- > > > Acked-by: Dumitru Ceara <dceara@redhat.com> > > Thanks! I obviously replied to the wrong email, I apologize. Please disregard this ack. Sorry for the noise.
On Wed, Aug 10, 2022 at 10:04 AM Dumitru Ceara <dceara@redhat.com> wrote: > It doesn't really need the load balancer applied on the logical router. > As a matter of fact, load balancers are not supported on distributed > routers without distributed gateway ports: > > > https://github.com/ovn-org/ovn/blob/4dc4bc7fdb848bcc626becbd2c80ffef8a39ff9a/ovn-nb.xml#L2223 > > Signed-off-by: Dumitru Ceara <dceara@redhat.com> > --- > tests/system-ovn.at | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/tests/system-ovn.at b/tests/system-ovn.at > index 2ba71df0f..851117f55 100644 > --- a/tests/system-ovn.at > +++ b/tests/system-ovn.at > @@ -5513,7 +5513,6 @@ ovn-nbctl lb-add lb0 "30.0.0.10:80" "20.0.0.4:80" > > ovn-nbctl ls-lb-add sw1 lb0 > ovn-nbctl ls-lb-add sw2 lb0 > -ovn-nbctl lr-lb-add lr0 lb0 > > ADD_NAMESPACES(sw0-p1-lbc) > ADD_VETH(sw0-p1-lbc, sw0-p1-lbc, br-int, "10.0.0.3/24", > "10:54:00:00:00:03", \ > -- > 2.31.1 > > _______________________________________________ > dev mailing list > dev@openvswitch.org > https://mail.openvswitch.org/mailman/listinfo/ovs-dev > > Makes sense. Acked-by: Ales Musil <amusil@redhat.com> Regards, Ales
On Wed, Aug 10, 2022 at 8:17 PM Ales Musil <amusil@redhat.com> wrote: > > On Wed, Aug 10, 2022 at 10:04 AM Dumitru Ceara <dceara@redhat.com> wrote: > > > It doesn't really need the load balancer applied on the logical router. > > As a matter of fact, load balancers are not supported on distributed > > routers without distributed gateway ports: > > > > > > https://github.com/ovn-org/ovn/blob/4dc4bc7fdb848bcc626becbd2c80ffef8a39ff9a/ovn-nb.xml#L2223 Unrelated to this patch - Looks like this section needs some fixes in documentation. We now support multiple distributed gateway ports. > > > > Signed-off-by: Dumitru Ceara <dceara@redhat.com> > > --- > > tests/system-ovn.at | 1 - > > 1 file changed, 1 deletion(-) > > > > diff --git a/tests/system-ovn.at b/tests/system-ovn.at > > index 2ba71df0f..851117f55 100644 > > --- a/tests/system-ovn.at > > +++ b/tests/system-ovn.at > > @@ -5513,7 +5513,6 @@ ovn-nbctl lb-add lb0 "30.0.0.10:80" "20.0.0.4:80" > > > > ovn-nbctl ls-lb-add sw1 lb0 > > ovn-nbctl ls-lb-add sw2 lb0 > > -ovn-nbctl lr-lb-add lr0 lb0 > > > > ADD_NAMESPACES(sw0-p1-lbc) > > ADD_VETH(sw0-p1-lbc, sw0-p1-lbc, br-int, "10.0.0.3/24", > > "10:54:00:00:00:03", \ > > -- > > 2.31.1 > > > > _______________________________________________ > > dev mailing list > > dev@openvswitch.org > > https://mail.openvswitch.org/mailman/listinfo/ovs-dev > > > > > Makes sense. > > Acked-by: Ales Musil <amusil@redhat.com> Thanks. Applied to main. Numan > > Regards, > Ales > > -- > > Ales Musil > > Senior Software Engineer - OVN Core > > Red Hat EMEA <https://www.redhat.com> > > amusil@redhat.com IM: amusil > <https://red.ht/sig> > _______________________________________________ > dev mailing list > dev@openvswitch.org > https://mail.openvswitch.org/mailman/listinfo/ovs-dev >
On 8/15/22 05:36, Numan Siddique wrote: > On Wed, Aug 10, 2022 at 8:17 PM Ales Musil <amusil@redhat.com> wrote: >> >> On Wed, Aug 10, 2022 at 10:04 AM Dumitru Ceara <dceara@redhat.com> wrote: >> >>> It doesn't really need the load balancer applied on the logical router. >>> As a matter of fact, load balancers are not supported on distributed >>> routers without distributed gateway ports: >>> >>> >>> https://github.com/ovn-org/ovn/blob/4dc4bc7fdb848bcc626becbd2c80ffef8a39ff9a/ovn-nb.xml#L2223 > > Unrelated to this patch - > Looks like this section needs some fixes in documentation. We now > support multiple distributed gateway ports. > Aside from the section on NAT do you see anything else that needs an update? For LBs it's accurate, we don't support LBs applied routers with more than one distributed gateway port: https://github.com/ovn-org/ovn/blob/1871fdd8e7dd61c4ce96879fa09d37d460d82e42/northd/northd.c#L4148 https://github.com/ovn-org/ovn/blob/1871fdd8e7dd61c4ce96879fa09d37d460d82e42/northd/northd.c#L10006 >>> >>> Signed-off-by: Dumitru Ceara <dceara@redhat.com> >>> --- >>> tests/system-ovn.at | 1 - >>> 1 file changed, 1 deletion(-) >>> >>> diff --git a/tests/system-ovn.at b/tests/system-ovn.at >>> index 2ba71df0f..851117f55 100644 >>> --- a/tests/system-ovn.at >>> +++ b/tests/system-ovn.at >>> @@ -5513,7 +5513,6 @@ ovn-nbctl lb-add lb0 "30.0.0.10:80" "20.0.0.4:80" >>> >>> ovn-nbctl ls-lb-add sw1 lb0 >>> ovn-nbctl ls-lb-add sw2 lb0 >>> -ovn-nbctl lr-lb-add lr0 lb0 >>> >>> ADD_NAMESPACES(sw0-p1-lbc) >>> ADD_VETH(sw0-p1-lbc, sw0-p1-lbc, br-int, "10.0.0.3/24", >>> "10:54:00:00:00:03", \ >>> -- >>> 2.31.1 >>> >>> _______________________________________________ >>> dev mailing list >>> dev@openvswitch.org >>> https://mail.openvswitch.org/mailman/listinfo/ovs-dev >>> >>> >> Makes sense. >> >> Acked-by: Ales Musil <amusil@redhat.com> > > Thanks. Applied to main. > Thanks Ales and Numan! Regards, Dumitru
diff --git a/tests/system-ovn.at b/tests/system-ovn.at index 2ba71df0f..851117f55 100644 --- a/tests/system-ovn.at +++ b/tests/system-ovn.at @@ -5513,7 +5513,6 @@ ovn-nbctl lb-add lb0 "30.0.0.10:80" "20.0.0.4:80" ovn-nbctl ls-lb-add sw1 lb0 ovn-nbctl ls-lb-add sw2 lb0 -ovn-nbctl lr-lb-add lr0 lb0 ADD_NAMESPACES(sw0-p1-lbc) ADD_VETH(sw0-p1-lbc, sw0-p1-lbc, br-int, "10.0.0.3/24", "10:54:00:00:00:03", \
It doesn't really need the load balancer applied on the logical router. As a matter of fact, load balancers are not supported on distributed routers without distributed gateway ports: https://github.com/ovn-org/ovn/blob/4dc4bc7fdb848bcc626becbd2c80ffef8a39ff9a/ovn-nb.xml#L2223 Signed-off-by: Dumitru Ceara <dceara@redhat.com> --- tests/system-ovn.at | 1 - 1 file changed, 1 deletion(-)