| Message ID | 20220224230723.1662183-1-numans@ovn.org |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [ovs-dev] ovs: Bump submodule to stable branch-2.17. | expand |
| Context | Check | Description |
|---|---|---|
| ovsrobot/apply-robot | success | apply and check: success |
| ovsrobot/github-robot-_ovn-kubernetes | success | github build: passed |
| ovsrobot/github-robot-_Build_and_Test | fail | github build: failed |
On Thu, Feb 24, 2022 at 3:07 PM <numans@ovn.org> wrote: > > From: Numan Siddique <numans@ovn.org> > > The following commits are required for OVN: > > 498cedc48 reconnect: Fix broken inactivity probe if there is no other reason to wake up. > 8b5136a89 ovsdb-idl: Fix use-after-free when destroying an IDL loop. > 88705f1ba ovsdb-idlc: Avoid accessing member within NULL idl index cursors. > 4638cb58f ovsdb-idl: Only process successful txn in ovsdb_idl_loop_run. > 17cedcb2d ovsdb-idl: ovsdb_idl_loop_destroy must also destroy the committing txn. > 553f566d9 ovsdb-cs: Fix ignoring of the last id from the initial monitor reply. > > Since OVN 22.03 will be an LTS release, it is better to use stable OVS > version. > > [1] - 498cedc483f3("reconnect: Fix broken inactivity probe if there is > no other reason to wakeup.") Probably delete this line since it is already mentioned in the list above? Acked-by: Han Zhou <hzhou@ovn.org> > > Signed-off-by: Numan Siddique <numans@ovn.org> > --- > ovs | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/ovs b/ovs > index 91e1ff5dd..498cedc48 160000 > --- a/ovs > +++ b/ovs > @@ -1 +1 @@ > -Subproject commit 91e1ff5dde396fbcc8623ac0726066e970e6de15 > +Subproject commit 498cedc483f3239c839c55b4d9f2261b61fb6ace > -- > 2.34.1 > > _______________________________________________ > dev mailing list > dev@openvswitch.org > https://mail.openvswitch.org/mailman/listinfo/ovs-dev
On Fri, Feb 25, 2022 at 2:00 AM Han Zhou <hzhou@ovn.org> wrote: > > On Thu, Feb 24, 2022 at 3:07 PM <numans@ovn.org> wrote: > > > > From: Numan Siddique <numans@ovn.org> > > > > The following commits are required for OVN: > > > > 498cedc48 reconnect: Fix broken inactivity probe if there is no other > reason to wake up. > > 8b5136a89 ovsdb-idl: Fix use-after-free when destroying an IDL loop. > > 88705f1ba ovsdb-idlc: Avoid accessing member within NULL idl index > cursors. > > 4638cb58f ovsdb-idl: Only process successful txn in ovsdb_idl_loop_run. > > 17cedcb2d ovsdb-idl: ovsdb_idl_loop_destroy must also destroy the > committing txn. > > 553f566d9 ovsdb-cs: Fix ignoring of the last id from the initial > monitor reply. > > > > Since OVN 22.03 will be an LTS release, it is better to use stable OVS > > version. > > > > [1] - 498cedc483f3("reconnect: Fix broken inactivity probe if there is > > no other reason to wakeup.") > > Probably delete this line since it is already mentioned in the list above? Yes. There is no need of it. > > Acked-by: Han Zhou <hzhou@ovn.org> Thanks. I applied the patch to the main branch updating the commit message. Numan > > > > > Signed-off-by: Numan Siddique <numans@ovn.org> > > --- > > ovs | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/ovs b/ovs > > index 91e1ff5dd..498cedc48 160000 > > --- a/ovs > > +++ b/ovs > > @@ -1 +1 @@ > > -Subproject commit 91e1ff5dde396fbcc8623ac0726066e970e6de15 > > +Subproject commit 498cedc483f3239c839c55b4d9f2261b61fb6ace > > -- > > 2.34.1 > > > > _______________________________________________ > > dev mailing list > > dev@openvswitch.org > > https://mail.openvswitch.org/mailman/listinfo/ovs-dev > _______________________________________________ > dev mailing list > dev@openvswitch.org > https://mail.openvswitch.org/mailman/listinfo/ovs-dev >
On 2/25/22 16:19, Numan Siddique wrote: > On Fri, Feb 25, 2022 at 2:00 AM Han Zhou <hzhou@ovn.org> wrote: >> >> On Thu, Feb 24, 2022 at 3:07 PM <numans@ovn.org> wrote: >>> >>> From: Numan Siddique <numans@ovn.org> >>> >>> The following commits are required for OVN: >>> >>> 498cedc48 reconnect: Fix broken inactivity probe if there is no other >> reason to wake up. >>> 8b5136a89 ovsdb-idl: Fix use-after-free when destroying an IDL loop. >>> 88705f1ba ovsdb-idlc: Avoid accessing member within NULL idl index >> cursors. >>> 4638cb58f ovsdb-idl: Only process successful txn in ovsdb_idl_loop_run. >>> 17cedcb2d ovsdb-idl: ovsdb_idl_loop_destroy must also destroy the >> committing txn. >>> 553f566d9 ovsdb-cs: Fix ignoring of the last id from the initial >> monitor reply. >>> >>> Since OVN 22.03 will be an LTS release, it is better to use stable OVS >>> version. >>> >>> [1] - 498cedc483f3("reconnect: Fix broken inactivity probe if there is >>> no other reason to wakeup.") >> >> Probably delete this line since it is already mentioned in the list above? > > Yes. There is no need of it. >> >> Acked-by: Han Zhou <hzhou@ovn.org> > > Thanks. I applied the patch to the main branch updating the commit message. We should, probably, also backport to at least 21.12, since these are actual bug fixes that impacts OVN operation. Especially, the 'reconnect' one. What do you think? Best regards, Ilya Maximets.
On 2/25/22 10:26, Ilya Maximets wrote: > On 2/25/22 16:19, Numan Siddique wrote: >> On Fri, Feb 25, 2022 at 2:00 AM Han Zhou <hzhou@ovn.org> wrote: >>> >>> On Thu, Feb 24, 2022 at 3:07 PM <numans@ovn.org> wrote: >>>> >>>> From: Numan Siddique <numans@ovn.org> >>>> >>>> The following commits are required for OVN: >>>> >>>> 498cedc48 reconnect: Fix broken inactivity probe if there is no other >>> reason to wake up. >>>> 8b5136a89 ovsdb-idl: Fix use-after-free when destroying an IDL loop. >>>> 88705f1ba ovsdb-idlc: Avoid accessing member within NULL idl index >>> cursors. >>>> 4638cb58f ovsdb-idl: Only process successful txn in ovsdb_idl_loop_run. >>>> 17cedcb2d ovsdb-idl: ovsdb_idl_loop_destroy must also destroy the >>> committing txn. >>>> 553f566d9 ovsdb-cs: Fix ignoring of the last id from the initial >>> monitor reply. >>>> >>>> Since OVN 22.03 will be an LTS release, it is better to use stable OVS >>>> version. >>>> >>>> [1] - 498cedc483f3("reconnect: Fix broken inactivity probe if there is >>>> no other reason to wakeup.") >>> >>> Probably delete this line since it is already mentioned in the list above? >> >> Yes. There is no need of it. >>> >>> Acked-by: Han Zhou <hzhou@ovn.org> >> >> Thanks. I applied the patch to the main branch updating the commit message. > > We should, probably, also backport to at least 21.12, since these > are actual bug fixes that impacts OVN operation. Especially, the > 'reconnect' one. > > What do you think? > > Best regards, Ilya Maximets. > Sounds reasonable to me.
On Fri, Feb 25, 2022 at 1:20 PM Mark Michelson <mmichels@redhat.com> wrote: > > On 2/25/22 10:26, Ilya Maximets wrote: > > On 2/25/22 16:19, Numan Siddique wrote: > >> On Fri, Feb 25, 2022 at 2:00 AM Han Zhou <hzhou@ovn.org> wrote: > >>> > >>> On Thu, Feb 24, 2022 at 3:07 PM <numans@ovn.org> wrote: > >>>> > >>>> From: Numan Siddique <numans@ovn.org> > >>>> > >>>> The following commits are required for OVN: > >>>> > >>>> 498cedc48 reconnect: Fix broken inactivity probe if there is no other > >>> reason to wake up. > >>>> 8b5136a89 ovsdb-idl: Fix use-after-free when destroying an IDL loop. > >>>> 88705f1ba ovsdb-idlc: Avoid accessing member within NULL idl index > >>> cursors. > >>>> 4638cb58f ovsdb-idl: Only process successful txn in ovsdb_idl_loop_run. > >>>> 17cedcb2d ovsdb-idl: ovsdb_idl_loop_destroy must also destroy the > >>> committing txn. > >>>> 553f566d9 ovsdb-cs: Fix ignoring of the last id from the initial > >>> monitor reply. > >>>> > >>>> Since OVN 22.03 will be an LTS release, it is better to use stable OVS > >>>> version. > >>>> > >>>> [1] - 498cedc483f3("reconnect: Fix broken inactivity probe if there is > >>>> no other reason to wakeup.") > >>> > >>> Probably delete this line since it is already mentioned in the list above? > >> > >> Yes. There is no need of it. > >>> > >>> Acked-by: Han Zhou <hzhou@ovn.org> > >> > >> Thanks. I applied the patch to the main branch updating the commit message. > > > > We should, probably, also backport to at least 21.12, since these > > are actual bug fixes that impacts OVN operation. Especially, the > > 'reconnect' one. > > > > What do you think? > > > > Best regards, Ilya Maximets. > > > > Sounds reasonable to me. Sounds good. I'll backport it. Numan > > _______________________________________________ > dev mailing list > dev@openvswitch.org > https://mail.openvswitch.org/mailman/listinfo/ovs-dev >
diff --git a/ovs b/ovs index 91e1ff5dd..498cedc48 160000 --- a/ovs +++ b/ovs @@ -1 +1 @@ -Subproject commit 91e1ff5dde396fbcc8623ac0726066e970e6de15 +Subproject commit 498cedc483f3239c839c55b4d9f2261b61fb6ace