diff mbox series

[ovs-dev] Set additional header in DNS message explicitly

Message ID 20220208144611.947066-1-numans@ovn.org
State Accepted
Headers show
Series [ovs-dev] Set additional header in DNS message explicitly | expand

Checks

Context Check Description
ovsrobot/apply-robot success apply and check: success
ovsrobot/github-robot-_ovn-kubernetes success github build: passed
ovsrobot/github-robot-_Build_and_Test fail github build: failed

Commit Message

Numan Siddique Feb. 8, 2022, 2:46 p.m. UTC 
From: Sven Haardiek <sven.haardiek@uni-muenster.de>

Some DNS Queries include an optional RR in the additional record section of
DNS, so simply copying the non-zero DNS Header for the additional records, but
not adding any leads to broken DNS packages.

This patch explicitly sets the additional records entry in the DNS header to 0.

Closes #114
Submitted-at: https://github.com/ovn-org/ovn/pull/115
Signed-off-by: Sven Haardiek <sven.haardiek@uni-muenster.de>
---
 controller/pinctrl.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

Numan Siddique Feb. 10, 2022, 5:28 p.m. UTC | #1 
On Tue, Feb 8, 2022 at 9:46 AM <numans@ovn.org> wrote:
>
> From: Sven Haardiek <sven.haardiek@uni-muenster.de>
>
> Some DNS Queries include an optional RR in the additional record section of
> DNS, so simply copying the non-zero DNS Header for the additional records, but
> not adding any leads to broken DNS packages.
>
> This patch explicitly sets the additional records entry in the DNS header to 0.
>
> Closes #114
> Submitted-at: https://github.com/ovn-org/ovn/pull/115
> Signed-off-by: Sven Haardiek <sven.haardiek@uni-muenster.de>

Thanks for the PR.

I applied to the main branch and backported util branch-21.03

Numan

> ---
>  controller/pinctrl.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/controller/pinctrl.c b/controller/pinctrl.c
> index 293aecea2..fd0bccdb6 100644
> --- a/controller/pinctrl.c
> +++ b/controller/pinctrl.c
> @@ -3023,8 +3023,9 @@ pinctrl_handle_dns_lookup(
>      /* Set the response bit to 1 in the flags. */
>      out_dns_header->lo_flag |= 0x80;
>
> -    /* Set the answer RR. */
> +    /* Set the answer RRs. */
>      out_dns_header->ancount = htons(ancount);
> +    out_dns_header->arcount = 0;
>
>      /* Copy the Query section. */
>      dp_packet_put(&pkt_out, dp_packet_data(pkt_in), dp_packet_size(pkt_in));
> --
> 2.34.1
>
> _______________________________________________
> dev mailing list
> dev@openvswitch.org
> https://mail.openvswitch.org/mailman/listinfo/ovs-dev
>
diff mbox series

Patch

diff --git a/controller/pinctrl.c b/controller/pinctrl.c
index 293aecea2..fd0bccdb6 100644
--- a/controller/pinctrl.c
+++ b/controller/pinctrl.c
@@ -3023,8 +3023,9 @@  pinctrl_handle_dns_lookup(
     /* Set the response bit to 1 in the flags. */
     out_dns_header->lo_flag |= 0x80;
 
-    /* Set the answer RR. */
+    /* Set the answer RRs. */
     out_dns_header->ancount = htons(ancount);
+    out_dns_header->arcount = 0;
 
     /* Copy the Query section. */
     dp_packet_put(&pkt_out, dp_packet_data(pkt_in), dp_packet_size(pkt_in));