| Message ID | 20211111223825.1757021-2-hzhou@ovn.org |
|---|---|
| State | Accepted |
| Headers | show |
| Series | uuid-based conjunction id generation. | expand |
| Context | Check | Description |
|---|---|---|
| ovsrobot/apply-robot | success | apply and check: success |
| ovsrobot/github-robot-_Build_and_Test | fail | github build: failed |
| ovsrobot/github-robot-_ovn-kubernetes | fail | github build: failed |
On Thu, Nov 11, 2021 at 5:39 PM Han Zhou <hzhou@ovn.org> wrote: > > In commit fadbc04f38db it changed the lflow-cache behavior but forgot to > update the commment. > > Fixes: fadbc04f38db ("ovn-controller: Fix incremental processing for logical port references.") > Signed-off-by: Han Zhou <hzhou@ovn.org> Acked-by: Numan Siddique <numans@ovn.org> Numan > --- > controller/lflow-cache.h | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/controller/lflow-cache.h b/controller/lflow-cache.h > index 6166fa7c5..553e05f8e 100644 > --- a/controller/lflow-cache.h > +++ b/controller/lflow-cache.h > @@ -32,8 +32,9 @@ struct lflow_cache; > * - Caches > * (1) Conjunction ID offset if the logical flow has port group/address > * set references. > - * (2) expr tree if the logical flow has is_chassis_resident() match. > - * (3) expr matches if (1) and (2) are false. > + * (2) expr tree if the logical flow doesn't have port group/address set > + * references but has other references (such as lport). > + * (3) expr matches if the logical flow doesn't have any references. > */ > enum lflow_cache_type { > LCACHE_T_CONJ_ID, /* Only conjunction id offset is cached. */ > -- > 2.30.2 > > _______________________________________________ > dev mailing list > dev@openvswitch.org > https://mail.openvswitch.org/mailman/listinfo/ovs-dev >
diff --git a/controller/lflow-cache.h b/controller/lflow-cache.h index 6166fa7c5..553e05f8e 100644 --- a/controller/lflow-cache.h +++ b/controller/lflow-cache.h @@ -32,8 +32,9 @@ struct lflow_cache; * - Caches * (1) Conjunction ID offset if the logical flow has port group/address * set references. - * (2) expr tree if the logical flow has is_chassis_resident() match. - * (3) expr matches if (1) and (2) are false. + * (2) expr tree if the logical flow doesn't have port group/address set + * references but has other references (such as lport). + * (3) expr matches if the logical flow doesn't have any references. */ enum lflow_cache_type { LCACHE_T_CONJ_ID, /* Only conjunction id offset is cached. */
In commit fadbc04f38db it changed the lflow-cache behavior but forgot to update the commment. Fixes: fadbc04f38db ("ovn-controller: Fix incremental processing for logical port references.") Signed-off-by: Han Zhou <hzhou@ovn.org> --- controller/lflow-cache.h | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)