| Message ID | 20211109100033.882525-1-frode.nordahl@canonical.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [ovs-dev] ovn-nb: Document LRP gateway_mtu option | expand |
| Context | Check | Description |
|---|---|---|
| ovsrobot/apply-robot | warning | apply and check: warning |
| ovsrobot/github-robot-_Build_and_Test | success | github build: passed |
| ovsrobot/github-robot-_ovn-kubernetes | fail | github build: failed |
Bleep bloop. Greetings Frode Nordahl, I am a robot and I have tried out your patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
WARNING: Line is 113 characters long (recommended limit is 79)
#29 FILE: ovn-nb.xml:2824:
<column name="options" key="gateway_mtu" type='{"type": "integer", "minInteger": 68, "maxInteger": 65535}'>
Lines checked: 45, Warnings: 1, Errors: 0
Please check this out. If you feel there has been an error, please email aconole@redhat.com
Thanks,
0-day Robot
On Tue, Nov 9, 2021 at 11:21 AM 0-day Robot <robot@bytheb.org> wrote: > > Bleep bloop. Greetings Frode Nordahl, I am a robot and I have tried out your patch. > Thanks for your contribution. > > I encountered some error that I wasn't expecting. See the details below. > > > checkpatch: > WARNING: Line is 113 characters long (recommended limit is 79) > #29 FILE: ovn-nb.xml:2824: > <column name="options" key="gateway_mtu" type='{"type": "integer", "minInteger": 68, "maxInteger": 65535}'> Indeed, v2 up here: https://patchwork.ozlabs.org/project/ovn/patch/20211109101158.887655-1-frode.nordahl@canonical.com/
diff --git a/ovn-nb.xml b/ovn-nb.xml index 036ffa64f..e4ec25038 100644 --- a/ovn-nb.xml +++ b/ovn-nb.xml @@ -2820,6 +2820,18 @@ prefix according to RFC3663 </p> </column> + + <column name="options" key="gateway_mtu" type='{"type": "integer", "minInteger": 68, "maxInteger": 65535}'> + <p> + If set, logical flows will be added to router pipeline to check + packet length. If packet length is greater than the value set, + ICMPv4 type 3 (Destination Unreachable) code 4 (Fragmentation Needed + and Don't Fragment was Set) or ICMPv6 type 2 (Packet Too Big) + code 0 (no route to destination) packets will be generated. + + This allows for Path MTU Discovery. + </p> + </column> </group> <group title="Attachment">
The Logical Router Port gateway_mtu option is currently only documented together with implementation details in the ovn-northd documentation. As this is CMS API we ought to document this as part of the OVN Northbound Database as well. Reported-at: https://github.com/ovn-org/ovn/issues/78 Fixes: 7d42c14 ("ovn: Generate ICMPv4 packet in router pipeline for larger packets") Signed-off-by: Frode Nordahl <frode.nordahl@canonical.com> --- ovn-nb.xml | 12 ++++++++++++ 1 file changed, 12 insertions(+)