| Message ID | 20210804085905.2432870-1-xsimonar@redhat.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [ovs-dev,v3,1/2] system-ovn.at: Fix flaky "load-balancing" test. | expand |
| Context | Check | Description |
|---|---|---|
| ovsrobot/apply-robot | success | apply and check: success |
| ovsrobot/github-robot-_Build_and_Test | success | github build: passed |
| ovsrobot/github-robot-_ovn-kubernetes | fail | github build: failed |
On 04/08/2021 09:59, Xavier Simonart wrote: > When running load-balancing test, tcpdump is executed in background. > When the backround tcpdump stops, it sends to stderr a message > (such as number of packets captured) which might be catched by the > following command (wget) causing the test to fail. > > Fixes: ebbcd8e8cc ("northd: add reject action for lb with no backends") > Reported-at: https://bugzilla.redhat.com/show_bug.cgi?id=1989517 > Signed-off-by: Xavier Simonart <xsimonar@redhat.com> > --- > tests/system-ovn.at | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tests/system-ovn.at b/tests/system-ovn.at > index 4288d80e5..2d21fb262 100644 > --- a/tests/system-ovn.at > +++ b/tests/system-ovn.at > @@ -1593,7 +1593,7 @@ OVS_WAIT_UNTIL([ > ovn-nbctl --reject lb-add lb3 30.0.0.10:80 "" > ovn-nbctl ls-lb-add foo lb3 > # Filter reset segments > -NS_CHECK_EXEC([foo1], [tcpdump -c 1 -neei foo1 ip[[33:1]]=0x14 > rst.pcap &]) > +NS_CHECK_EXEC([foo1], [tcpdump -c 1 -neei foo1 ip[[33:1]]=0x14 > rst.pcap 2>/dev/null &]) > sleep 1 > NS_CHECK_EXEC([foo1], [wget -q 30.0.0.10],[4]) > > Acked-by: Mark D. Gray <mark.d.gray@redhat.com>
On Thu, Aug 5, 2021 at 10:55 AM Mark Gray <mark.d.gray@redhat.com> wrote: > > On 04/08/2021 09:59, Xavier Simonart wrote: > > When running load-balancing test, tcpdump is executed in background. > > When the backround tcpdump stops, it sends to stderr a message > > (such as number of packets captured) which might be catched by the > > following command (wget) causing the test to fail. > > > > Fixes: ebbcd8e8cc ("northd: add reject action for lb with no backends") > > Reported-at: https://bugzilla.redhat.com/show_bug.cgi?id=1989517 > > Signed-off-by: Xavier Simonart <xsimonar@redhat.com> > > --- > > tests/system-ovn.at | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/tests/system-ovn.at b/tests/system-ovn.at > > index 4288d80e5..2d21fb262 100644 > > --- a/tests/system-ovn.at > > +++ b/tests/system-ovn.at > > @@ -1593,7 +1593,7 @@ OVS_WAIT_UNTIL([ > > ovn-nbctl --reject lb-add lb3 30.0.0.10:80 "" > > ovn-nbctl ls-lb-add foo lb3 > > # Filter reset segments > > -NS_CHECK_EXEC([foo1], [tcpdump -c 1 -neei foo1 ip[[33:1]]=0x14 > rst.pcap &]) > > +NS_CHECK_EXEC([foo1], [tcpdump -c 1 -neei foo1 ip[[33:1]]=0x14 > rst.pcap 2>/dev/null &]) > > sleep 1 > > NS_CHECK_EXEC([foo1], [wget -q 30.0.0.10],[4]) > > > > > > Acked-by: Mark D. Gray <mark.d.gray@redhat.com> Thanks Xavier for the patch and welcome to OVN. I added your name in the AUTHORS file and applied this patch to the main branch. Numan > > _______________________________________________ > dev mailing list > dev@openvswitch.org > https://mail.openvswitch.org/mailman/listinfo/ovs-dev >
diff --git a/tests/system-ovn.at b/tests/system-ovn.at index 4288d80e5..2d21fb262 100644 --- a/tests/system-ovn.at +++ b/tests/system-ovn.at @@ -1593,7 +1593,7 @@ OVS_WAIT_UNTIL([ ovn-nbctl --reject lb-add lb3 30.0.0.10:80 "" ovn-nbctl ls-lb-add foo lb3 # Filter reset segments -NS_CHECK_EXEC([foo1], [tcpdump -c 1 -neei foo1 ip[[33:1]]=0x14 > rst.pcap &]) +NS_CHECK_EXEC([foo1], [tcpdump -c 1 -neei foo1 ip[[33:1]]=0x14 > rst.pcap 2>/dev/null &]) sleep 1 NS_CHECK_EXEC([foo1], [wget -q 30.0.0.10],[4])
When running load-balancing test, tcpdump is executed in background. When the backround tcpdump stops, it sends to stderr a message (such as number of packets captured) which might be catched by the following command (wget) causing the test to fail. Fixes: ebbcd8e8cc ("northd: add reject action for lb with no backends") Reported-at: https://bugzilla.redhat.com/show_bug.cgi?id=1989517 Signed-off-by: Xavier Simonart <xsimonar@redhat.com> --- tests/system-ovn.at | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)