From patchwork Thu Jan 21 17:30:25 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ilya Maximets X-Patchwork-Id: 1429982 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=openvswitch.org (client-ip=140.211.166.138; helo=whitealder.osuosl.org; envelope-from=ovs-dev-bounces@openvswitch.org; receiver=) Received: from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4DM8YT3GYbz9sS8 for ; Fri, 22 Jan 2021 04:30:37 +1100 (AEDT) Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id 04A1C86C5B; Thu, 21 Jan 2021 17:30:36 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Se5zVEv1C8aT; Thu, 21 Jan 2021 17:30:35 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by whitealder.osuosl.org (Postfix) with ESMTP id 00E3286A39; Thu, 21 Jan 2021 17:30:34 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id DB43FC088B; Thu, 21 Jan 2021 17:30:34 +0000 (UTC) X-Original-To: ovs-dev@openvswitch.org Delivered-To: ovs-dev@lists.linuxfoundation.org Received: from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136]) by lists.linuxfoundation.org (Postfix) with ESMTP id E5333C013A for ; Thu, 21 Jan 2021 17:30:33 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id D3AC022EC1 for ; Thu, 21 Jan 2021 17:30:33 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id k64FyewNl+zt for ; Thu, 21 Jan 2021 17:30:32 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from relay9-d.mail.gandi.net (relay9-d.mail.gandi.net [217.70.183.199]) by silver.osuosl.org (Postfix) with ESMTPS id 6664921514 for ; Thu, 21 Jan 2021 17:30:32 +0000 (UTC) X-Originating-IP: 78.45.89.65 Received: from im-t490s.redhat.com (ip-78-45-89-65.net.upcbroadband.cz [78.45.89.65]) (Authenticated sender: i.maximets@ovn.org) by relay9-d.mail.gandi.net (Postfix) with ESMTPSA id 269B2FF80E; Thu, 21 Jan 2021 17:30:27 +0000 (UTC) From: Ilya Maximets To: ovs-dev@openvswitch.org Date: Thu, 21 Jan 2021 18:30:25 +0100 Message-Id: <20210121173025.413591-1-i.maximets@ovn.org> X-Mailer: git-send-email 2.26.2 MIME-Version: 1.0 Cc: Ilya Maximets Subject: [ovs-dev] [PATCH ovn] sandbox: Fix path to Sb DB socket for ovn-controller-vtep. X-BeenThere: ovs-dev@openvswitch.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: ovs-dev-bounces@openvswitch.org Sender: "dev" There was a race between commit ff4439dbdbc0 ("Build OVN using external OVS directory") and commit 381c9319b1f0 ("ovn-ic: Interconnection controller with AZ registeration.") Both touched sandbox code, but were accepted in the oppisite order to one they were prepared and sent to the mail list. This led to the case where new code from the first commit wasn't updated by the second one leaving ovn-controller-vtep with incorrect Southbound DB socket configuration, so it doesn't work inside the sandbox: sandbox/ovn-controller-vtep.log: |reconnect|INFO|unix:ovn/tutorial/sandbox/ovnsb_db.sock: connection attempt failed (No such file or directory) Fixes: 381c9319b1f0 ("ovn-ic: Interconnection controller with AZ registeration.") Signed-off-by: Ilya Maximets Acked-by: Han Zhou --- tutorial/ovs-sandbox | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tutorial/ovs-sandbox b/tutorial/ovs-sandbox index 1841776a4..525151a68 100755 --- a/tutorial/ovs-sandbox +++ b/tutorial/ovs-sandbox @@ -626,7 +626,7 @@ done rungdb $gdb_ovn_controller_vtep $gdb_ovn_controller_vtep_ex \ ovn-controller-vtep --detach --no-chdir --pidfile -vconsole:off \ $OVN_CTRLR_PKI --log-file -vsyslog:off \ - --ovnsb-db=unix:"$sandbox"/ovnsb_db.sock + --ovnsb-db="$OVN_SB_DB" cat <