Message ID | 20201120001724.2424494-11-i.maximets@ovn.org |
---|---|
State | Accepted |
Headers | show
Return-Path: <ovs-dev-bounces@openvswitch.org> X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=openvswitch.org (client-ip=140.211.166.137; helo=fraxinus.osuosl.org; envelope-from=ovs-dev-bounces@openvswitch.org; receiver=<UNKNOWN>) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=ovn.org Received: from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4CccbB34qbz9sVH for <incoming@patchwork.ozlabs.org>; Fri, 20 Nov 2020 11:18:30 +1100 (AEDT) Received: from localhost (localhost [127.0.0.1]) by fraxinus.osuosl.org (Postfix) with ESMTP id DCC4B86652; Fri, 20 Nov 2020 00:18:28 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from fraxinus.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id j_JCUbraj1xT; Fri, 20 Nov 2020 00:18:27 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by fraxinus.osuosl.org (Postfix) with ESMTP id 2C39586D5C; Fri, 20 Nov 2020 00:18:21 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 0DD44C1DA0; Fri, 20 Nov 2020 00:18:21 +0000 (UTC) X-Original-To: ovs-dev@openvswitch.org Delivered-To: ovs-dev@lists.linuxfoundation.org Received: from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133]) by lists.linuxfoundation.org (Postfix) with ESMTP id A86FCC0891 for <ovs-dev@openvswitch.org>; Fri, 20 Nov 2020 00:18:19 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by hemlock.osuosl.org (Postfix) with ESMTP id 5A2518753A for <ovs-dev@openvswitch.org>; Fri, 20 Nov 2020 00:18:19 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from hemlock.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id adoTgsYE76i6 for <ovs-dev@openvswitch.org>; Fri, 20 Nov 2020 00:18:12 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from relay1-d.mail.gandi.net (relay1-d.mail.gandi.net [217.70.183.193]) by hemlock.osuosl.org (Postfix) with ESMTPS id 2BB8B87564 for <ovs-dev@openvswitch.org>; Fri, 20 Nov 2020 00:18:11 +0000 (UTC) X-Originating-IP: 78.45.89.65 Received: from im-t490s.redhat.com (ip-78-45-89-65.net.upcbroadband.cz [78.45.89.65]) (Authenticated sender: i.maximets@ovn.org) by relay1-d.mail.gandi.net (Postfix) with ESMTPSA id 73925240004; Fri, 20 Nov 2020 00:18:09 +0000 (UTC) From: Ilya Maximets <i.maximets@ovn.org> To: ovs-dev@openvswitch.org Date: Fri, 20 Nov 2020 01:17:20 +0100 Message-Id: <20201120001724.2424494-11-i.maximets@ovn.org> X-Mailer: git-send-email 2.25.4 In-Reply-To: <20201120001724.2424494-1-i.maximets@ovn.org> References: <20201120001724.2424494-1-i.maximets@ovn.org> MIME-Version: 1.0 Cc: Manoj Sharma <manoj.sharma@nutanix.com>, Ilya Maximets <i.maximets@ovn.org> Subject: [ovs-dev] [PATCH ovn 10/14] actions: Fix leak of dynamic string on fwd group encoding failure. X-BeenThere: ovs-dev@openvswitch.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: <ovs-dev.openvswitch.org> List-Unsubscribe: <https://mail.openvswitch.org/mailman/options/ovs-dev>, <mailto:ovs-dev-request@openvswitch.org?subject=unsubscribe> List-Archive: <http://mail.openvswitch.org/pipermail/ovs-dev/> List-Post: <mailto:ovs-dev@openvswitch.org> List-Help: <mailto:ovs-dev-request@openvswitch.org?subject=help> List-Subscribe: <https://mail.openvswitch.org/mailman/listinfo/ovs-dev>, <mailto:ovs-dev-request@openvswitch.org?subject=subscribe> Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ovs-dev-bounces@openvswitch.org Sender: "dev" <ovs-dev-bounces@openvswitch.org> |
Series |
Pack of fixes for memory leaks.
|
expand
|
diff --git a/lib/actions.c b/lib/actions.c index ea949e1bd..99ce04197 100644 --- a/lib/actions.c +++ b/lib/actions.c @@ -3446,6 +3446,7 @@ encode_FWD_GROUP(const struct ovnact_fwd_group *fwd_group, if (fwd_group->liveness) { /* Find the openflow port number of the tunnel port */ if (!ep->tunnel_ofport(ep->aux, port_name, &ofport)) { + ds_destroy(&ds); return; }
CC: Manoj Sharma <manoj.sharma@nutanix.com> Fixes: edb240081518 ("Forwarding group to load balance l2 traffic with liveness detection") Signed-off-by: Ilya Maximets <i.maximets@ovn.org> --- lib/actions.c | 1 + 1 file changed, 1 insertion(+)