diff mbox series

[ovs-dev,1/2] pinctrl: Fix memory leak in controller_event_run().

Message ID 20201027223006.19043.24481.stgit@dceara.remote.csb
State Accepted
Headers show
Series Fix memory leaks due to controller events. | expand

Commit Message

Dumitru Ceara Oct. 27, 2020, 10:30 p.m. UTC 
Valgrind report:
==4689== 639 (96 direct, 543 indirect) bytes in 3 blocks are definitely lost in loss record 141 of 146
==4689==    at 0x4C29E63: malloc (vg_replace_malloc.c:309)
==4689==    by 0x51EEB3: xmalloc (util.c:138)
==4689==    by 0x485034: resize (hmap.c:100)
==4689==    by 0x4852BF: hmap_expand_at (hmap.c:175)
==4689==    by 0x511A8E: hmap_insert_at (hmap.h:283)
==4689==    by 0x512824: smap_add__ (smap.c:408)
==4689==    by 0x511D20: smap_add (smap.c:55)
==4689==    by 0x41B51E: controller_event_run (pinctrl.c:459)
==4689==    by 0x422CCD: pinctrl_run (pinctrl.c:3155)
==4689==    by 0x433511: main (ovn-controller.c:2588)

Fixes: be1eeb09d373 ("OVN: introduce Controller_Event table")
Signed-off-by: Dumitru Ceara <dceara@redhat.com>
---
 controller/pinctrl.c |    1 +
 1 file changed, 1 insertion(+)
diff mbox series

Patch

diff --git a/controller/pinctrl.c b/controller/pinctrl.c
index f15afc5..bc482c0 100644
--- a/controller/pinctrl.c
+++ b/controller/pinctrl.c
@@ -465,6 +465,7 @@  controller_event_run(struct ovsdb_idl_txn *ovnsb_idl_txn,
             sbrec_controller_event_set_seq_num(event, ++event_seq_num);
             sbrec_controller_event_set_event_info(event, &event_info);
             sbrec_controller_event_set_chassis(event, chassis);
+            smap_destroy(&event_info);
         }
     }