diff mbox series

[ovs-dev,3/6] ovn-fake-multinode-tests: Don't silently ignore test failures.

Message ID 168327875278.2609356.16807735194131032546.stgit@dceara.remote.csb
State Accepted
Headers show
Series Improve multi-node CI tests. | expand

Checks

Context Check Description
ovsrobot/apply-robot warning apply and check: warning
ovsrobot/github-robot-_Build_and_Test fail github build: failed
ovsrobot/github-robot-_ovn-kubernetes fail github build: failed

Commit Message

Dumitru Ceara May 5, 2023, 9:25 a.m. UTC 
Fixes: 6c6a7ad1c64a ("Add fake multinode system tests.")
Signed-off-by: Dumitru Ceara <dceara@redhat.com>
---
 .github/workflows/ovn-fake-multinode-tests.yml |   16 +++++++++-------
 1 file changed, 9 insertions(+), 7 deletions(-)
diff mbox series

Patch

diff --git a/.github/workflows/ovn-fake-multinode-tests.yml b/.github/workflows/ovn-fake-multinode-tests.yml
index 7a1f05d940..93ef2ed368 100644
--- a/.github/workflows/ovn-fake-multinode-tests.yml
+++ b/.github/workflows/ovn-fake-multinode-tests.yml
@@ -166,13 +166,15 @@  jobs:
         cd ovn
         ./.ci/linux-prepare.sh
         ./.ci/linux-build.sh
-        sudo make check-multinode  || :
-        sudo podman exec -it ovn-central ovn-nbctl show || :
-        sudo podman exec -it ovn-central ovn-sbctl show || :
-        sudo podman exec -it ovn-chassis-1 ovs-vsctl show || :
-        sudo podman exec -it ovn-chassis-1 ip netns || :
-        sudo podman exec -it ovn-chassis-1 cat /var/log/ovn/ovn-controller.log || :
-        sudo cat tests/multinode-testsuite.dir/1/multinode-testsuite.log || :
+        if ! sudo make check-multinode; then
+          sudo podman exec -it ovn-central ovn-nbctl show || :
+          sudo podman exec -it ovn-central ovn-sbctl show || :
+          sudo podman exec -it ovn-chassis-1 ovs-vsctl show || :
+          sudo podman exec -it ovn-chassis-1 ip netns || :
+          sudo podman exec -it ovn-chassis-1 cat /var/log/ovn/ovn-controller.log || :
+          sudo cat tests/multinode-testsuite.dir/multinode-testsuite.log || :
+          exit 1
+        fi
 
     - name: copy logs on failure
       if: failure() || cancelled()