diff mbox series

[ovs-dev] nbctl: Execute unixctl_server_run() regardless of IDL state.

Message ID 1608566295-1324-1-git-send-email-dceara@redhat.com
State Accepted
Headers show
Series [ovs-dev] nbctl: Execute unixctl_server_run() regardless of IDL state. | expand

Commit Message

Dumitru Ceara Dec. 21, 2020, 3:58 p.m. UTC
This allows users to interact with the ovn-nbctl daemon even before the
first time the IDL client successfully connects to the server.

Reported-at: https://mail.openvswitch.org/pipermail/ovs-dev/2020-December/378826.html
Reported-by: Girish Moodalbail <gmoodalbail@gmail.com>
Signed-off-by: Dumitru Ceara <dceara@redhat.com>
---
 utilities/ovn-nbctl.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

Numan Siddique Jan. 20, 2021, 6:12 a.m. UTC | #1
On Mon, Dec 21, 2020 at 9:28 PM Dumitru Ceara <dceara@redhat.com> wrote:

> This allows users to interact with the ovn-nbctl daemon even before the
> first time the IDL client successfully connects to the server.
>
> Reported-at:
> https://mail.openvswitch.org/pipermail/ovs-dev/2020-December/378826.html
> Reported-by: Girish Moodalbail <gmoodalbail@gmail.com>
> Signed-off-by: Dumitru Ceara <dceara@redhat.com>
>

Thanks Dumitru. I applied this patch to master.

Numan


> ---
>  utilities/ovn-nbctl.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/utilities/ovn-nbctl.c b/utilities/ovn-nbctl.c
> index 94e7eed..e441b7f 100644
> --- a/utilities/ovn-nbctl.c
> +++ b/utilities/ovn-nbctl.c
> @@ -6834,8 +6834,9 @@ server_loop(struct ovsdb_idl *idl, int argc, char
> *argv[])
>
>          if (ovsdb_idl_has_ever_connected(idl)) {
>              daemonize_complete();
> -            unixctl_server_run(server);
>          }
> +        unixctl_server_run(server);
> +
>          if (exiting) {
>              break;
>          }
> --
> 1.8.3.1
>
> _______________________________________________
> dev mailing list
> dev@openvswitch.org
> https://mail.openvswitch.org/mailman/listinfo/ovs-dev
>
>
diff mbox series

Patch

diff --git a/utilities/ovn-nbctl.c b/utilities/ovn-nbctl.c
index 94e7eed..e441b7f 100644
--- a/utilities/ovn-nbctl.c
+++ b/utilities/ovn-nbctl.c
@@ -6834,8 +6834,9 @@  server_loop(struct ovsdb_idl *idl, int argc, char *argv[])
 
         if (ovsdb_idl_has_ever_connected(idl)) {
             daemonize_complete();
-            unixctl_server_run(server);
         }
+        unixctl_server_run(server);
+
         if (exiting) {
             break;
         }