diff mbox series

[ovs-dev] Add dh-python to debian/control.

Message ID 1458201712849303@oabjfzlxttdsu7rh.sas.yp-c.yandex.net
State Accepted
Headers show
Series [ovs-dev] Add dh-python to debian/control. | expand

Checks

Context Check Description
ovsrobot/apply-robot success apply and check: success
ovsrobot/github-robot-_Build_and_Test success github build: passed
ovsrobot/github-robot-_ovn-kubernetes fail github build: failed

Commit Message

Igor Zhukov April 11, 2024, 3:28 p.m. UTC 
I tried to build OVN in a fresh Ubuntu 24.04 Docker container.

I only installed the Build-Depends.

I ran:

$ dpkg-buildpackage -us -uc -ui -b

And I received the following output:

dpkg-buildpackage: info: source package ovn
dpkg-buildpackage: info: source version 24.03.90-1
dpkg-buildpackage: info: source distribution unstable
dpkg-buildpackage: info: source changed by OVN team <dev@openvswitch.org>
dpkg-source --before-build .
dpkg-buildpackage: info: host architecture amd64
debian/rules clean
dh clean --with autoreconf,python3 --parallel
dh: warning: Compatibility levels before 10 are deprecated (level 9 in use)
dh: error: unable to load addon python3: Can't locate Debian/Debhelper/Sequence/python3.pm in @INC (you may need to install the Debian::Debhelper::Sequence::python3 module) (@INC entries checked: /etc/perl /usr/local/lib/x86_64-linux-gnu/perl/5.38.2 /usr/local/share/perl/5.38.2 /usr/lib/x86_64-linux-gnu/perl5/5.38 /usr/share/perl5 /usr/lib/x86_64-linux-gnu/perl-base /usr/lib/x86_64-linux-gnu/perl/5.38 /usr/share/perl/5.38 /usr/local/lib/site_perl) at (eval 12) line 1.
BEGIN failed--compilation aborted at (eval 12) line 1.

make: *** [debian/rules:25: clean] Error 255
dpkg-buildpackage: error: debian/rules clean subprocess returned exit status 2
debuild: fatal error at line 1184:
dpkg-buildpackage -us -uc -ui -b failed


After researching a solution, I discovered that we need to add dh-python to the Build-Depends in debian/control.

Signed-off-by: Igor Zhukov <fsb4000@yandex.ru>
---
 debian/control | 1 +
 1 file changed, 1 insertion(+)

--
2.43.0

Comments

Dumitru Ceara April 12, 2024, 11:49 a.m. UTC | #1 
On 4/11/24 17:28, Igor Zhukov wrote:
> I tried to build OVN in a fresh Ubuntu 24.04 Docker container.
> 
> I only installed the Build-Depends.
> 
> I ran:
> 
> $ dpkg-buildpackage -us -uc -ui -b
> 
> And I received the following output:
> 
> dpkg-buildpackage: info: source package ovn
> dpkg-buildpackage: info: source version 24.03.90-1
> dpkg-buildpackage: info: source distribution unstable
> dpkg-buildpackage: info: source changed by OVN team <dev@openvswitch.org>
> dpkg-source --before-build .
> dpkg-buildpackage: info: host architecture amd64
> debian/rules clean
> dh clean --with autoreconf,python3 --parallel
> dh: warning: Compatibility levels before 10 are deprecated (level 9 in use)
> dh: error: unable to load addon python3: Can't locate Debian/Debhelper/Sequence/python3.pm in @INC (you may need to install the Debian::Debhelper::Sequence::python3 module) (@INC entries checked: /etc/perl /usr/local/lib/x86_64-linux-gnu/perl/5.38.2 /usr/local/share/perl/5.38.2 /usr/lib/x86_64-linux-gnu/perl5/5.38 /usr/share/perl5 /usr/lib/x86_64-linux-gnu/perl-base /usr/lib/x86_64-linux-gnu/perl/5.38 /usr/share/perl/5.38 /usr/local/lib/site_perl) at (eval 12) line 1.
> BEGIN failed--compilation aborted at (eval 12) line 1.
> 
> make: *** [debian/rules:25: clean] Error 255
> dpkg-buildpackage: error: debian/rules clean subprocess returned exit status 2
> debuild: fatal error at line 1184:
> dpkg-buildpackage -us -uc -ui -b failed
> 
> 
> After researching a solution, I discovered that we need to add dh-python to the Build-Depends in debian/control.
> 
> Signed-off-by: Igor Zhukov <fsb4000@yandex.ru>
> ---

Hi Igor,

Thanks for the patch!

Frode, would you have some cycles by any chance to review this?

Thanks,
Dumitru

>  debian/control | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/debian/control b/debian/control
> index 6ee2192..d99b483 100644
> --- a/debian/control
> +++ b/debian/control
> @@ -9,6 +9,7 @@ Build-Depends: graphviz,
>                 bzip2,
>                 debhelper (>= 8),
>                 dh-autoreconf,
> +               dh-python,
>                 libssl-dev,
>                 libtool,
>                 openssl,
> --
> 2.43.0
> _______________________________________________
> dev mailing list
> dev@openvswitch.org
> https://mail.openvswitch.org/mailman/listinfo/ovs-dev
>
Numan Siddique April 25, 2024, 4:32 p.m. UTC | #2 
On Fri, Apr 12, 2024 at 7:49 AM Dumitru Ceara <dceara@redhat.com> wrote:
>
> On 4/11/24 17:28, Igor Zhukov wrote:
> > I tried to build OVN in a fresh Ubuntu 24.04 Docker container.
> >
> > I only installed the Build-Depends.
> >
> > I ran:
> >
> > $ dpkg-buildpackage -us -uc -ui -b
> >
> > And I received the following output:
> >
> > dpkg-buildpackage: info: source package ovn
> > dpkg-buildpackage: info: source version 24.03.90-1
> > dpkg-buildpackage: info: source distribution unstable
> > dpkg-buildpackage: info: source changed by OVN team <dev@openvswitch.org>
> > dpkg-source --before-build .
> > dpkg-buildpackage: info: host architecture amd64
> > debian/rules clean
> > dh clean --with autoreconf,python3 --parallel
> > dh: warning: Compatibility levels before 10 are deprecated (level 9 in use)
> > dh: error: unable to load addon python3: Can't locate Debian/Debhelper/Sequence/python3.pm in @INC (you may need to install the Debian::Debhelper::Sequence::python3 module) (@INC entries checked: /etc/perl /usr/local/lib/x86_64-linux-gnu/perl/5.38.2 /usr/local/share/perl/5.38.2 /usr/lib/x86_64-linux-gnu/perl5/5.38 /usr/share/perl5 /usr/lib/x86_64-linux-gnu/perl-base /usr/lib/x86_64-linux-gnu/perl/5.38 /usr/share/perl/5.38 /usr/local/lib/site_perl) at (eval 12) line 1.
> > BEGIN failed--compilation aborted at (eval 12) line 1.
> >
> > make: *** [debian/rules:25: clean] Error 255
> > dpkg-buildpackage: error: debian/rules clean subprocess returned exit status 2
> > debuild: fatal error at line 1184:
> > dpkg-buildpackage -us -uc -ui -b failed
> >
> >
> > After researching a solution, I discovered that we need to add dh-python to the Build-Depends in debian/control.
> >
> > Signed-off-by: Igor Zhukov <fsb4000@yandex.ru>
> > ---
>
> Hi Igor,
>
> Thanks for the patch!
>
> Frode, would you have some cycles by any chance to review this?

I went ahead and applied this patch to main and branch-24.03.

Thanks
Numan

>
> Thanks,
> Dumitru
>
> >  debian/control | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/debian/control b/debian/control
> > index 6ee2192..d99b483 100644
> > --- a/debian/control
> > +++ b/debian/control
> > @@ -9,6 +9,7 @@ Build-Depends: graphviz,
> >                 bzip2,
> >                 debhelper (>= 8),
> >                 dh-autoreconf,
> > +               dh-python,
> >                 libssl-dev,
> >                 libtool,
> >                 openssl,
> > --
> > 2.43.0
> > _______________________________________________
> > dev mailing list
> > dev@openvswitch.org
> > https://mail.openvswitch.org/mailman/listinfo/ovs-dev
> >
>
> _______________________________________________
> dev mailing list
> dev@openvswitch.org
> https://mail.openvswitch.org/mailman/listinfo/ovs-dev
>
Igor Zhukov April 25, 2024, 5:15 p.m. UTC | #3 
You're welcome.

> On Fri, Apr 12, 2024 at 7:49 AM Dumitru Ceara <dceara@redhat.com> wrote:
> 
>> On 4/11/24 17:28, Igor Zhukov wrote:
>>> I tried to build OVN in a fresh Ubuntu 24.04 Docker container.
>>>
>>> I only installed the Build-Depends.
>>>
>>> I ran:
>>>
>>> $ dpkg-buildpackage -us -uc -ui -b
>>>
>>> And I received the following output:
>>>
>>> dpkg-buildpackage: info: source package ovn
>>> dpkg-buildpackage: info: source version 24.03.90-1
>>> dpkg-buildpackage: info: source distribution unstable
>>> dpkg-buildpackage: info: source changed by OVN team <dev@openvswitch.org>
>>> dpkg-source --before-build .
>>> dpkg-buildpackage: info: host architecture amd64
>>> debian/rules clean
>>> dh clean --with autoreconf,python3 --parallel
>>> dh: warning: Compatibility levels before 10 are deprecated (level 9 in use)
>>> dh: error: unable to load addon python3: Can't locate Debian/Debhelper/Sequence/python3.pm in @INC (you may need to install the Debian::Debhelper::Sequence::python3 module) (@INC entries checked: /etc/perl /usr/local/lib/x86_64-linux-gnu/perl/5.38.2 /usr/local/share/perl/5.38.2 /usr/lib/x86_64-linux-gnu/perl5/5.38 /usr/share/perl5 /usr/lib/x86_64-linux-gnu/perl-base /usr/lib/x86_64-linux-gnu/perl/5.38 /usr/share/perl/5.38 /usr/local/lib/site_perl) at (eval 12) line 1.
>>> BEGIN failed--compilation aborted at (eval 12) line 1.
>>>
>>> make: *** [debian/rules:25: clean] Error 255
>>> dpkg-buildpackage: error: debian/rules clean subprocess returned exit status 2
>>> debuild: fatal error at line 1184:
>>> dpkg-buildpackage -us -uc -ui -b failed
>>>
>>>
>>> After researching a solution, I discovered that we need to add dh-python to the Build-Depends in debian/control.
>>>
>>> Signed-off-by: Igor Zhukov <fsb4000@yandex.ru>
>>> ---
>>
>> Hi Igor,
>>
>> Thanks for the patch!
>>
>> Frode, would you have some cycles by any chance to review this?
> 
> I went ahead and applied this patch to main and branch-24.03.
> 
> Thanks
> Numan
> 
>> Thanks,
>> Dumitru
>>
>>> debian/control | 1 +
>>> 1 file changed, 1 insertion(+)
>>>
>>> diff --git a/debian/control b/debian/control
>>> index 6ee2192..d99b483 100644
>>> --- a/debian/control
>>> +++ b/debian/control
>>> @@ -9,6 +9,7 @@ Build-Depends: graphviz,
>>> bzip2,
>>> debhelper (>= 8),
>>> dh-autoreconf,
>>> + dh-python,
>>> libssl-dev,
>>> libtool,
>>> openssl,
>>> --
>>> 2.43.0
>>> _______________________________________________
>>> dev mailing list
>>> dev@openvswitch.org
>>> https://mail.openvswitch.org/mailman/listinfo/ovs-dev
>>>
>>
>> _______________________________________________
>> dev mailing list
>> dev@openvswitch.org
>> https://mail.openvswitch.org/mailman/listinfo/ovs-dev
diff mbox series

Patch

diff --git a/debian/control b/debian/control
index 6ee2192..d99b483 100644
--- a/debian/control
+++ b/debian/control
@@ -9,6 +9,7 @@  Build-Depends: graphviz,
                bzip2,
                debhelper (>= 8),
                dh-autoreconf,
+               dh-python,
                libssl-dev,
                libtool,
                openssl,