mbox series

[ovs-dev,00/10] Fixes to Unit tests.

Message ID 20240212175537.1356073-1-xsimonar@redhat.com
Headers show
Series Fixes to Unit tests. | expand

Message

Xavier Simonart Feb. 12, 2024, 5:55 p.m. UTC
Check unit tests logs for errors.
Fix multiple unit tests issues highlighted when checking logs for errors.

Xavier Simonart (10):
  tests: Have tests fail when adding veth peer fails.
  tests: Fix typos in tests.
  tests: Fix flaky "options:requested-chassis ...".
  tests: Fix flaky "ovn-controller-vtep - binding 1".
  tests: Fix "ofctrl wait before clearing flows".
  tests: Fix "ovn-controller - Chassis other_config".
  tests: Fix "Load balancer incremental processing".
  tests: Fix "router port type update and then ...".
  tests: Speed up "multicast group buffer split".
  tests: Check unit tests logs for errors.

 tests/ovn-controller-vtep.at  |   2 +-
 tests/ovn-controller.at       | 108 +++++++++---
 tests/ovn-ic.at               |   4 +-
 tests/ovn-macros.at           |  61 +++++--
 tests/ovn-northd.at           |   2 +
 tests/ovn.at                  | 298 +++++++++++++++++++++++++++-------
 tests/system-common-macros.at |   2 +-
 7 files changed, 381 insertions(+), 96 deletions(-)

Comments

Ales Musil Feb. 13, 2024, 8:47 a.m. UTC | #1
On Mon, Feb 12, 2024 at 6:56 PM Xavier Simonart <xsimonar@redhat.com> wrote:

> Check unit tests logs for errors.
> Fix multiple unit tests issues highlighted when checking logs for errors.
>
> Xavier Simonart (10):
>   tests: Have tests fail when adding veth peer fails.
>   tests: Fix typos in tests.
>   tests: Fix flaky "options:requested-chassis ...".
>   tests: Fix flaky "ovn-controller-vtep - binding 1".
>   tests: Fix "ofctrl wait before clearing flows".
>   tests: Fix "ovn-controller - Chassis other_config".
>   tests: Fix "Load balancer incremental processing".
>   tests: Fix "router port type update and then ...".
>   tests: Speed up "multicast group buffer split".
>   tests: Check unit tests logs for errors.
>
>  tests/ovn-controller-vtep.at  |   2 +-
>  tests/ovn-controller.at       | 108 +++++++++---
>  tests/ovn-ic.at               |   4 +-
>  tests/ovn-macros.at           |  61 +++++--
>  tests/ovn-northd.at           |   2 +
>  tests/ovn.at                  | 298 +++++++++++++++++++++++++++-------
>  tests/system-common-macros.at |   2 +-
>  7 files changed, 381 insertions(+), 96 deletions(-)
>
> --
> 2.41.0
>
> _______________________________________________
> dev mailing list
> dev@openvswitch.org
> https://mail.openvswitch.org/mailman/listinfo/ovs-dev
>
>
The whole series looks good to me, thanks!

Acked-by: Ales Musil <amusil@redhat.com>
Mark Michelson Feb. 19, 2024, 8:31 p.m. UTC | #2
On 2/13/24 03:47, Ales Musil wrote:
> On Mon, Feb 12, 2024 at 6:56 PM Xavier Simonart <xsimonar@redhat.com> wrote:
> 
>> Check unit tests logs for errors.
>> Fix multiple unit tests issues highlighted when checking logs for errors.
>>
>> Xavier Simonart (10):
>>    tests: Have tests fail when adding veth peer fails.
>>    tests: Fix typos in tests.
>>    tests: Fix flaky "options:requested-chassis ...".
>>    tests: Fix flaky "ovn-controller-vtep - binding 1".
>>    tests: Fix "ofctrl wait before clearing flows".
>>    tests: Fix "ovn-controller - Chassis other_config".
>>    tests: Fix "Load balancer incremental processing".
>>    tests: Fix "router port type update and then ...".
>>    tests: Speed up "multicast group buffer split".
>>    tests: Check unit tests logs for errors.
>>
>>   tests/ovn-controller-vtep.at  |   2 +-
>>   tests/ovn-controller.at       | 108 +++++++++---
>>   tests/ovn-ic.at               |   4 +-
>>   tests/ovn-macros.at           |  61 +++++--
>>   tests/ovn-northd.at           |   2 +
>>   tests/ovn.at                  | 298 +++++++++++++++++++++++++++-------
>>   tests/system-common-macros.at |   2 +-
>>   7 files changed, 381 insertions(+), 96 deletions(-)
>>
>> --
>> 2.41.0
>>
>> _______________________________________________
>> dev mailing list
>> dev@openvswitch.org
>> https://mail.openvswitch.org/mailman/listinfo/ovs-dev
>>
>>
> The whole series looks good to me, thanks!
> 
> Acked-by: Ales Musil <amusil@redhat.com>
> 

Thanks Xavier and Ales. I pushed the entire series to main and 
branch-24.03. I then was able to cherry-pick all patches except for 
patches 7, 9, and 10 to branch-23.09, branch-23.06, branch-23.03, and 
branch-22.12. Once I started trying to backport to branch-22.09, I 
encountered conflicts I didn't feel comfortable trying to resolve on my 
own. If you think these should be backported further, please send 
backport patches for 22.09, 22.06, and 22.03.

22.03 is the current LTS, but it won't be for much longer, and since 
these are test fixes, they aren't necessarily essential to backport any 
further in my opinion. We're a few weeks away from 23.03 being the 
oldest supported branch for normal bug fixes, so do with that what you 
will :)