mbox series

[ovs-dev,v2,0/2] northd: Meter incremental processing.

Message ID 169228590905.3284801.8984407769211587248.stgit@dceara.remote.csb
Headers show
Series northd: Meter incremental processing. | expand

Message

Dumitru Ceara Aug. 17, 2023, 3:25 p.m. UTC 
Changes in V2:
- Refactored a bit the meter code and added that as first patch.

Dumitru Ceara (2):
      northd: Refactor meter code to avoid duplication.
      northd: Add a separate I-P node for handling meters.


 lib/stopwatch-names.h    |   1 +
 northd/automake.mk       |   2 +
 northd/en-lflow.c        |   5 +-
 northd/en-meters.c       | 281 +++++++++++++++++++++++++++++++++++++++
 northd/en-meters.h       |  44 ++++++
 northd/en-northd.c       |   6 -
 northd/inc-proc-northd.c |  14 +-
 northd/northd.c          | 235 ++------------------------------
 northd/northd.h          |   4 -
 northd/ovn-northd.c      |   3 +
 tests/ovn-northd.at      |  36 +++++
 11 files changed, 390 insertions(+), 241 deletions(-)
 create mode 100644 northd/en-meters.c
 create mode 100644 northd/en-meters.h

Comments

Ales Musil Aug. 21, 2023, 5:37 a.m. UTC | #1 
On Thu, Aug 17, 2023 at 5:25 PM Dumitru Ceara <dceara@redhat.com> wrote:

> Changes in V2:
> - Refactored a bit the meter code and added that as first patch.
>
> Dumitru Ceara (2):
>       northd: Refactor meter code to avoid duplication.
>       northd: Add a separate I-P node for handling meters.
>
>
>  lib/stopwatch-names.h    |   1 +
>  northd/automake.mk       |   2 +
>  northd/en-lflow.c        |   5 +-
>  northd/en-meters.c       | 281 +++++++++++++++++++++++++++++++++++++++
>  northd/en-meters.h       |  44 ++++++
>  northd/en-northd.c       |   6 -
>  northd/inc-proc-northd.c |  14 +-
>  northd/northd.c          | 235 ++------------------------------
>  northd/northd.h          |   4 -
>  northd/ovn-northd.c      |   3 +
>  tests/ovn-northd.at      |  36 +++++
>  11 files changed, 390 insertions(+), 241 deletions(-)
>  create mode 100644 northd/en-meters.c
>  create mode 100644 northd/en-meters.h
>
> _______________________________________________
> dev mailing list
> dev@openvswitch.org
> https://mail.openvswitch.org/mailman/listinfo/ovs-dev
>
>
Looks good to me, thanks!

Acked-by: Ales Musil <amusil@redhat.com>
Dumitru Ceara Aug. 30, 2023, 11:03 a.m. UTC | #2 
On 8/21/23 07:37, Ales Musil wrote:
> On Thu, Aug 17, 2023 at 5:25 PM Dumitru Ceara <dceara@redhat.com> wrote:
> 
>> Changes in V2:
>> - Refactored a bit the meter code and added that as first patch.
>>
>> Dumitru Ceara (2):
>>       northd: Refactor meter code to avoid duplication.
>>       northd: Add a separate I-P node for handling meters.
>>
>>
>>  lib/stopwatch-names.h    |   1 +
>>  northd/automake.mk       |   2 +
>>  northd/en-lflow.c        |   5 +-
>>  northd/en-meters.c       | 281 +++++++++++++++++++++++++++++++++++++++
>>  northd/en-meters.h       |  44 ++++++
>>  northd/en-northd.c       |   6 -
>>  northd/inc-proc-northd.c |  14 +-
>>  northd/northd.c          | 235 ++------------------------------
>>  northd/northd.h          |   4 -
>>  northd/ovn-northd.c      |   3 +
>>  tests/ovn-northd.at      |  36 +++++
>>  11 files changed, 390 insertions(+), 241 deletions(-)
>>  create mode 100644 northd/en-meters.c
>>  create mode 100644 northd/en-meters.h
>>
>> _______________________________________________
>> dev mailing list
>> dev@openvswitch.org
>> https://mail.openvswitch.org/mailman/listinfo/ovs-dev
>>
>>
> Looks good to me, thanks!
> 
> Acked-by: Ales Musil <amusil@redhat.com>
> 

Thanks, Ales and Mark, for the reviews.  I folded the agreed incremental
changes in patch 2 and pushed this to the main branch.

Regards,
Dumitru