| Message ID | owrt-patch-20151216-5@vittgam.net |
|---|---|
| State | Accepted |
| Headers | show |
Am 16.12.2015 um 05:42 schrieb Vittorio G (VittGam): > This patch configures the correct ath9k WLAN LED polarity for the TDW8970. > > Signed-off-by: Vittorio Gambaletta <openwrt@vittgam.net> > > --- > > The TDW8970 LED is active high, but I'm not sure about the TDW8980 as > I don't have one. If the TDW8980 LED is active high as well, this can > be added to TDW89X0.dtsi instead of TDW8970.dts. The TDW8980 2.4 GHz Wireless LED is active high as well and your patch fixed the inverse lighting. Would you please move the definition to the dtsi! > > --- a/target/linux/lantiq/dts/TDW8970.dts > +++ b/target/linux/lantiq/dts/TDW8970.dts > @@ -4,4 +4,8 @@ > > / { > model = "TDW8970 - TP-LINK TD-W8970"; > + > + ath9k_eep { > + ath,led-active-high; > + }; > }; > _______________________________________________ > openwrt-devel mailing list > openwrt-devel@lists.openwrt.org > https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel >
On 16 December 2015 22:12:15 CET, Mathias Kresin <openwrt@kresin.me> wrote: >The TDW8980 2.4 GHz Wireless LED is active high as well and your patch >fixed the inverse lighting. > >Would you please move the definition to the dtsi! Sure, I will update the patches then. Thanks for testing!
--- a/target/linux/lantiq/dts/TDW8970.dts +++ b/target/linux/lantiq/dts/TDW8970.dts @@ -4,4 +4,8 @@ / { model = "TDW8970 - TP-LINK TD-W8970"; + + ath9k_eep { + ath,led-active-high; + }; };
This patch configures the correct ath9k WLAN LED polarity for the TDW8970. Signed-off-by: Vittorio Gambaletta <openwrt@vittgam.net> --- The TDW8970 LED is active high, but I'm not sure about the TDW8980 as I don't have one. If the TDW8980 LED is active high as well, this can be added to TDW89X0.dtsi instead of TDW8970.dts.