| Message ID | ebb0b74e4c3079c25db2fef2610fda64e9735ce8.1637435434.git.sander@svanheule.net |
|---|---|
| State | Accepted |
| Delegated to: | Stijn Tintel |
| Headers | show
Return-Path: <openwrt-devel-bounces+incoming=patchwork.ozlabs.org@lists.openwrt.org> X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: bilbo.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=uytvU2Oq; dkim=fail reason="signature verification failed" (2048-bit key; secure) header.d=svanheule.net header.i=@svanheule.net header.a=rsa-sha256 header.s=mail1707 header.b=odUGL8Ov; dkim-atps=neutral Authentication-Results: ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.openwrt.org (client-ip=2607:7c80:54:e::133; helo=bombadil.infradead.org; envelope-from=openwrt-devel-bounces+incoming=patchwork.ozlabs.org@lists.openwrt.org; receiver=<UNKNOWN>) Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by bilbo.ozlabs.org (Postfix) with ESMTPS id 4HxNWS06qTz9sVc for <incoming@patchwork.ozlabs.org>; Sun, 21 Nov 2021 06:14:27 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=AnhPZPpDeVaG4S7+Lfd273FZvMFM9G5KdjjBbIeKoPI=; b=uytvU2OqxIJa5Y 8SoOtkmwQpRfMuZFCnghUHlInV+RTjMn7TXEdpMXmDx7Z1yioT+Ch2t7jX6JEqiUayhPzF4lYrID1 eISuwBedsDRNapNnPvX0XfdeqxGSemh+cn6p+oNwXRlpKeWOmgWWsuKnspEox0vhge8G51a2r6tCE KwmuvDjqw4FMI5p/UJdsxIDDg73O2IdLI3yz9xZBvcDuSxMKvqa/oNtTe6Ep7DYmWmrmINlST0QMN NPh9w0YdNZXbVZTtCxBqHQ6LCcpez4AlmZk1WJ92pytTqpvk9Z111LYoMwlLQs4+S2JJIPOFs3Zrr MfT98qbzPVxHMARMPHhw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1moVmO-00Cqj5-8F; Sat, 20 Nov 2021 19:12:04 +0000 Received: from polaris.svanheule.net ([2a00:c98:2060:a004:1::200]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1moVm8-00Cqh4-CT for openwrt-devel@lists.openwrt.org; Sat, 20 Nov 2021 19:11:49 +0000 Received: from terra.local.svanheule.net (unknown [IPv6:2a02:a03f:eafe:c901:46c2:4f7f:e9b0:8251]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: sander@svanheule.net) by polaris.svanheule.net (Postfix) with ESMTPSA id 1826E2748A7; Sat, 20 Nov 2021 20:11:46 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=svanheule.net; s=mail1707; t=1637435506; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=cgLYDotX6khSQEtadLfv+vDF7KoVpGPL2Ah0F2BIyNA=; b=odUGL8OvxFjie/+hD8r84+YYx+FdrREP6vTK1cZnUB/AZXjNuj2CfRCtpWf6utYO8dojYt PlT2RKJ7H/MBivCgZGaNaUJwYkzg8sLqm5GFG9ayDlZz7S+CgObv09zXAMIHy7DxHm5uqS KAzIHFyEhhgkb4nG8lE3MqNMIdzw64tbLz5i8WetEAd8MZ9WnL4FQQ03aAt/+cSFzRN2ph TPh9ujl+TXewU0ap0OUhoDd2YisVjgo1ZtEV9LBsCRgHxfVz6lwhxi8chtf37w0QgpRYZi CQuHZYxDeZE0poBpGL209mZLjPJ4y1zXQe5afAUx5RQTlXoRmMItwILaZKnxSg== From: Sander Vanheule <sander@svanheule.net> To: openwrt-devel@lists.openwrt.org Cc: Sander Vanheule <sander@svanheule.net>, INAGAKI Hiroshi <musashino.open@gmail.com> Subject: [PATCH v2 1/4] realtek: fix RTL8231 gpio count Date: Sat, 20 Nov 2021 20:11:31 +0100 Message-Id: <ebb0b74e4c3079c25db2fef2610fda64e9735ce8.1637435434.git.sander@svanheule.net> X-Mailer: git-send-email 2.33.1 In-Reply-To: <cover.1637435434.git.sander@svanheule.net> References: <cover.1637435434.git.sander@svanheule.net> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211120_111148_745558_E3565460 X-CRM114-Status: UNSURE ( 9.81 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -2.5 (--) X-Spam-Report: Spam detection software, running on the system "bombadil.infradead.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: The RTL8231's gpio_chip.ngpio was set to 36, which is the largest valid GPIO index. Fix the allowed number of GPIOs by setting ngpio to 37, the actual line count. Reported-by: INAGAKI Hiroshi <musashino.open@gmail.com> Signed-off-by: Sander Vanheule <sander@svanheule.net> --- target/linux/realtek/files-5.10/drivers/gpio/gpio-rtl8231.c | 2 +- 1 file changed, 1 i [...] Content analysis details: (-2.5 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at https://www.dnswl.org/, medium trust [2a00:c98:2060:a004:1:0:0:200 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record -0.0 SPF_HELO_PASS SPF: HELO matches SPF record -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain X-BeenThere: openwrt-devel@lists.openwrt.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: OpenWrt Development List <openwrt-devel.lists.openwrt.org> List-Unsubscribe: <https://lists.openwrt.org/mailman/options/openwrt-devel>, <mailto:openwrt-devel-request@lists.openwrt.org?subject=unsubscribe> List-Archive: <http://lists.openwrt.org/pipermail/openwrt-devel/> List-Post: <mailto:openwrt-devel@lists.openwrt.org> List-Help: <mailto:openwrt-devel-request@lists.openwrt.org?subject=help> List-Subscribe: <https://lists.openwrt.org/mailman/listinfo/openwrt-devel>, <mailto:openwrt-devel-request@lists.openwrt.org?subject=subscribe> Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "openwrt-devel" <openwrt-devel-bounces@lists.openwrt.org> Errors-To: openwrt-devel-bounces+incoming=patchwork.ozlabs.org@lists.openwrt.org |
| Series | realtek: RTL8231 refinements | expand |
diff --git a/target/linux/realtek/files-5.10/drivers/gpio/gpio-rtl8231.c b/target/linux/realtek/files-5.10/drivers/gpio/gpio-rtl8231.c index f4f5621e0c1b..f06c2d81df79 100644 --- a/target/linux/realtek/files-5.10/drivers/gpio/gpio-rtl8231.c +++ b/target/linux/realtek/files-5.10/drivers/gpio/gpio-rtl8231.c @@ -312,7 +312,7 @@ static int rtl8231_gpio_probe(struct platform_device *pdev) gpios->dev = dev; gpios->gc.base = 160; - gpios->gc.ngpio = 36; + gpios->gc.ngpio = 37; gpios->gc.label = "rtl8231"; gpios->gc.parent = dev; gpios->gc.owner = THIS_MODULE;
The RTL8231's gpio_chip.ngpio was set to 36, which is the largest valid GPIO index. Fix the allowed number of GPIOs by setting ngpio to 37, the actual line count. Reported-by: INAGAKI Hiroshi <musashino.open@gmail.com> Signed-off-by: Sander Vanheule <sander@svanheule.net> --- target/linux/realtek/files-5.10/drivers/gpio/gpio-rtl8231.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)