[02/20] package/lantiq: use make -C instead of `cd;`

Message ID	b13108024c88aca35681878762c17e16afbb8d6b.1700010289.git.ehem+openwrt@m5p.com
State	Not Applicable
Delegated to:	Petr Štetiar
Headers	show Return-Path: <openwrt-devel-bounces+incoming=patchwork.ozlabs.org@lists.openwrt.org> Message-Id: <b13108024c88aca35681878762c17e16afbb8d6b.1700010289.git.ehem+openwrt@m5p.com> In-Reply-To: <cover.1700010286.git.ehem+openwrt@m5p.com> References: <cover.1700010286.git.ehem+openwrt@m5p.com> From: Elliott Mitchell <ehem+openwrt@m5p.com> Date: Mon, 13 Nov 2023 14:38:31 -0800 Subject: [PATCH 02/20] package/lantiq: use make -C instead of `cd;` To: openwrt-devel@lists.openwrt.org preview: The effect is the same, but this reduces work by the shell. This is generally preferred unless multiple commands need to be run in the target directory. Signed-off-by: Elliott Mitchell <ehem+openwrt@m5p.com> --- package/kernel/lantiq/ltq-adsl-mei/Makefile \| 5 ++--- package/kernel/lantiq/ltq-atm/Makefile \| 5 ++--- package/kernel/lantiq/ltq-deu/Makefile [...] Content analysis details: (0.5 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 SPF_PASS SPF: sender matches SPF record 0.5 DATE_IN_PAST_24_48 Date: is 24 to 48 hours before SPF: HELO matches SPF record Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "openwrt-devel" <openwrt-devel-bounces@lists.openwrt.org> Errors-To: openwrt-devel-bounces+incoming=patchwork.ozlabs.org@lists.openwrt.org
Series	Kernel build fixups, split object directory off (partial WIP) \| expand [00/20] Kernel build fixups, split object directory off (partial WIP) [07/20] kernel: copy all built kernel modules to root filesystem image [06/20] kernel: remove drivers marked as modules [10/20,WIP] build: use dtc from $(LINUX_OBJ_DIR) [12/20,WIP] build: adjust include paths to use LINUX_SRC_DIR/LINUX_OBJ_DIR [13/20,WIP] build: point user_headers at $(LINUX_OBJ_DIR) [11/20,WIP] package/target: update to get modules from $(LINUX_OBJ_DIR) [19/20,WIP] build: point remainder at $(LINUX_SRC_DIR) [16/20,WIP] build: point kernel build tasks at $(LINUX_OBJ_DIR) [18/20,WIP] build: point remaining obvious cases at $(LINUX_SRC_DIR) [15/20,WIP] package: update packages with explicit make flags [14/20,WIP] build: update quilt references to use $(LINUX_SRC_DIR) [08/20] build: add make variables for kernel source and object directories [17/20,WIP] build: split kernel object directory from kernel source directory [01/20] ppp: make copy of compiler_types.h unconditional [20/20,TEST] TESTING: try separating build from sources [03/20] bcm27xx: fix device-tree support patch for split source/build dirs [02/20] package/lantiq: use make -C instead of `cd;` [09/20,WIP] build: split $(DTB_DIR) off of $(DTS_DIR) [04/20] patch: always backup files [05/20] build: merge Kernel/Prepare steps together

Message ID

b13108024c88aca35681878762c17e16afbb8d6b.1700010289.git.ehem+openwrt@m5p.com

State

Not Applicable

Delegated to:

Petr Štetiar

Headers

Message-Id: 
 <b13108024c88aca35681878762c17e16afbb8d6b.1700010289.git.ehem+openwrt@m5p.com>
In-Reply-To: <cover.1700010286.git.ehem+openwrt@m5p.com>
References: <cover.1700010286.git.ehem+openwrt@m5p.com>
From: Elliott Mitchell <ehem+openwrt@m5p.com>
Date: Mon, 13 Nov 2023 14:38:31 -0800
Subject: [PATCH 02/20] package/lantiq: use make -C instead of `cd;`
To: openwrt-devel@lists.openwrt.org
Precedence: list
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Sender: "openwrt-devel" <openwrt-devel-bounces@lists.openwrt.org>
Errors-To: 
 openwrt-devel-bounces+incoming=patchwork.ozlabs.org@lists.openwrt.org

Series

Kernel build fixups, split object directory off (partial WIP) | expand

Commit Message

Elliott Mitchell Nov. 13, 2023, 10:38 p.m. UTC

The effect is the same, but this reduces work by the shell.  This
is generally preferred unless multiple commands need to be run in the
target directory.

Signed-off-by: Elliott Mitchell <ehem+openwrt@m5p.com>
---
 package/kernel/lantiq/ltq-adsl-mei/Makefile | 5 ++---
 package/kernel/lantiq/ltq-atm/Makefile      | 5 ++---
 package/kernel/lantiq/ltq-deu/Makefile      | 5 ++---
 package/kernel/lantiq/ltq-ptm/Makefile      | 5 ++---
 4 files changed, 8 insertions(+), 12 deletions(-)

diff --git a/package/kernel/lantiq/ltq-adsl-mei/Makefile b/package/kernel/lantiq/ltq-adsl-mei/Makefile
index 31e671e53f..e9db785960 100644
--- a/package/kernel/lantiq/ltq-adsl-mei/Makefile
+++ b/package/kernel/lantiq/ltq-adsl-mei/Makefile
@@ -34,9 +34,8 @@  define Build/Configure
 endef
 
 define Build/Compile
-	cd $(LINUX_DIR); \
-		ARCH=mips CROSS_COMPILE="$(KERNEL_CROSS)" \
-		$(MAKE) BUILD_VARIANT=$(BUILD_VARIANT) M=$(PKG_BUILD_DIR)/ V=1 modules
+	ARCH=mips CROSS_COMPILE="$(KERNEL_CROSS)" \
+	$(MAKE) -C $(LINUX_DIR) BUILD_VARIANT=$(BUILD_VARIANT) M=$(PKG_BUILD_DIR)/ V=1 modules
 endef
 
 $(eval $(call KernelPackage,ltq-adsl-danube-mei))
diff --git a/package/kernel/lantiq/ltq-atm/Makefile b/package/kernel/lantiq/ltq-atm/Makefile
index b81f3bb293..af852e9a01 100644
--- a/package/kernel/lantiq/ltq-atm/Makefile
+++ b/package/kernel/lantiq/ltq-atm/Makefile
@@ -39,9 +39,8 @@  define Build/Configure
 endef
 
 define Build/Compile
-	cd $(LINUX_DIR); \
-		ARCH=mips CROSS_COMPILE="$(KERNEL_CROSS)" \
-		$(MAKE) $(KERNEL_MAKE_FLAGS) BUILD_VARIANT=$(BUILD_VARIANT) M=$(PKG_BUILD_DIR) V=1 modules
+	ARCH=mips CROSS_COMPILE="$(KERNEL_CROSS)" \
+	$(MAKE) -C $(LINUX_DIR) $(KERNEL_MAKE_FLAGS) BUILD_VARIANT=$(BUILD_VARIANT) M=$(PKG_BUILD_DIR) V=1 modules
 endef
 
 $(eval $(call KernelPackage,ltq-atm-danube))
diff --git a/package/kernel/lantiq/ltq-deu/Makefile b/package/kernel/lantiq/ltq-deu/Makefile
index 4e8127afab..4b8fae2766 100644
--- a/package/kernel/lantiq/ltq-deu/Makefile
+++ b/package/kernel/lantiq/ltq-deu/Makefile
@@ -34,9 +34,8 @@  define Build/Configure
 endef
 
 define Build/Compile
-	cd $(LINUX_DIR); \
-		ARCH=mips CROSS_COMPILE="$(KERNEL_CROSS)" \
-		$(MAKE) BUILD_VARIANT=$(BUILD_VARIANT) M=$(PKG_BUILD_DIR) V=1 modules
+	ARCH=mips CROSS_COMPILE="$(KERNEL_CROSS)" \
+	$(MAKE) -C $(LINUX_DIR) BUILD_VARIANT=$(BUILD_VARIANT) M=$(PKG_BUILD_DIR) V=1 modules
 endef
 
 $(eval $(call KernelPackage,ltq-deu-danube))
diff --git a/package/kernel/lantiq/ltq-ptm/Makefile b/package/kernel/lantiq/ltq-ptm/Makefile
index b726cb1560..a1fb2250d2 100644
--- a/package/kernel/lantiq/ltq-ptm/Makefile
+++ b/package/kernel/lantiq/ltq-ptm/Makefile
@@ -43,9 +43,8 @@  define Build/Configure
 endef
 
 define Build/Compile
-	cd $(LINUX_DIR); \
-		ARCH=mips CROSS_COMPILE="$(KERNEL_CROSS)" \
-		$(MAKE) $(KERNEL_MAKE_FLAGS) BUILD_VARIANT=$(BUILD_VARIANT) M=$(PKG_BUILD_DIR) V=1 modules
+	ARCH=mips CROSS_COMPILE="$(KERNEL_CROSS)" \
+	$(MAKE) -C $(LINUX_DIR) $(KERNEL_MAKE_FLAGS) BUILD_VARIANT=$(BUILD_VARIANT) M=$(PKG_BUILD_DIR) V=1 modules
 endef
 
 $(eval $(call KernelPackage,ltq-ptm-danube))

[02/20] package/lantiq: use make -C instead of `cd;`

Commit Message

Patch