Message ID | ME1PR01MB0817E64C8F3ED940FB369309D0D30@ME1PR01MB0817.ausprd01.prod.outlook.com |
---|---|
State | Superseded |
Delegated to: | Hauke Mehrtens |
Headers | show
Return-Path: <openwrt-devel-bounces+incoming=patchwork.ozlabs.org@lists.openwrt.org> X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.openwrt.org (client-ip=2001:8b0:10b:1231::1; helo=merlin.infradead.org; envelope-from=openwrt-devel-bounces+incoming=patchwork.ozlabs.org@lists.openwrt.org; receiver=<UNKNOWN>) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=outlook.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; secure) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=merlin.20170209 header.b=tiSxiGNV; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=outlook.com header.i=@outlook.com header.a=rsa-sha256 header.s=selector1 header.b=tT2VLGfa; dkim-atps=neutral Received: from merlin.infradead.org (merlin.infradead.org [IPv6:2001:8b0:10b:1231::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4D7pc53kC6z9sVb for <incoming@patchwork.ozlabs.org>; Sun, 3 Jan 2021 17:23:29 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-ID:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=TxU0b5gESUl+/+5X2io4In5AOwDqaaQS6DOwaCezP7Y=; b=tiSxiGNVJuhTvwIRZnP0nybEI 64OPNEmGYKK+iFXlPaiXYMlVp5ITNJMagO93nFM5hKIMygmwc8+PuAwHvnfrDcBPbN+erXP9eCZ1b ZwwZDTQLPAjkp2v3K5+AVUxtpyo/Rms7P34tTAQ9MwgMV0jq1vkYz/afzKn9Lbjoz9Cf1FqefGhwD XyjpABXPqMzAt/dScKnp34ftfGHxtGOFmsJO18wicOG7A08hp+cYn1I+UznfUdnU9o763OGhKgUwn IVxBeXDCOxaMlIwcddx6gpyXQakuV9N5IbPoXQoYOKOkj57sZu3uHcHsv/b3v0rYiu1jlxGxVKDsm +uPteSl7Q==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kvwk8-00066O-8k; Sun, 03 Jan 2021 06:19:56 +0000 Received: from mail-pu1apc01olkn081c.outbound.protection.outlook.com ([2a01:111:f400:febe::81c] helo=APC01-PU1-obe.outbound.protection.outlook.com) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kvwk3-00065d-Gk for openwrt-devel@lists.openwrt.org; Sun, 03 Jan 2021 06:19:52 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WkaNTVGfy/1117Dq8ePO7sTS/WVsfRoVeTs3PhBBJxIDrdRfLa9yyhqO+BaBE4zHG1tps5ppTa9W3QXh5p7gGiSS+FGwkrZu717J5Qcu98JKvZVbFGzcn/7yFK5h9AuBnQuOvTADbQRipEg5tUzKTyhCzzCV8Xmo9AhqbV+O+AP2+YUsBl8ucccfDINI8i0nOSfg85GcEf1thuBVPs9VoHLUn0YmgAuZVprA2Tk/o4No4btwM81hOpRKPu+7/+uJvn2szFBqjHIZIko3zGsp50QAMGKCkXtulzLuhhhOlpzkptmQG+mTNmIp+uWzTmIcVicFQqbT7Khv9Tx94zlw1g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=B3pT/lc+xxzAicvIGTz5hPDCCXF7YIjoxRmD3THRTnE=; b=dkkd4SoFmvrpjcliAmYdq5lLvPSjFjaTWfXgV+o2oOGGXIWJL0ZYdg9xoFdReEYYcWSHzk1mWjzd5lRRY9MroBVC0zhbI9xZYB/OrKrNWjzPgqat4DRiyrdPf3/LAtUh4CUI2EtguZ4vi2n+rsnKDurbMgx8LQq0RXGtS6KoEZ3gOHVruiubV4LqSK6BFo2vrr7ReWW/xL/VZ0mwWbA4vfYiYPlOMeLi/JUVh+LTjpF/ZuYMVZokdpmLpz/Eorf50wvFayGdr9AkjFmUKzy/iMCxHpNTH4+LM4nz2gIpWWWS9ejVwRW0BQ/FICt2n6MZpKXEDM6UeWRDkjggdJJndw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=B3pT/lc+xxzAicvIGTz5hPDCCXF7YIjoxRmD3THRTnE=; b=tT2VLGfa8m1/xwdBGuc3C5PmwF0AMkiw9prKqIbQkwztw0tjEja3H7udkWn+vE9ZokcO1sgdpFTxBVYoB/FekcN6F/1TlsYs9lV2rBgF3kLx2F48pm9S6MbVCAaB4Sjl+TxFtn5qtOrssou+o0+LWgAw+/wnppdd1GuBz1+0n/hGYxXBuiPqzzMWO5bHHBzNeJjFngxb6i02UxuQIFnqcrkR3v9iKGMvBNMEiWcuje1xNGNeOi7/Red5tHJT8o2JnLoB6TnMZnFeMJZyjIYollxxUPsZ0+VUTactxyvGvqFufjbCDHGiFsaFLuNseqd2i+/nEbPrQVV/N5FbBbphMg== Received: from SG2APC01FT008.eop-APC01.prod.protection.outlook.com (2a01:111:e400:7ebd::48) by SG2APC01HT051.eop-APC01.prod.protection.outlook.com (2a01:111:e400:7ebd::387) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3721.20; Sun, 3 Jan 2021 06:19:35 +0000 Received: from ME1PR01MB0817.ausprd01.prod.outlook.com (2a01:111:e400:7ebd::48) by SG2APC01FT008.mail.protection.outlook.com (2a01:111:e400:7ebd::99) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3721.20 via Frontend Transport; Sun, 3 Jan 2021 06:19:35 +0000 X-IncomingTopHeaderMarker: OriginalChecksum:A9E2C853EC7E88D89384372E0E673D910F3B8B009D688C586DBD183995DC319B; UpperCasedChecksum:D8191FD12F4C384993F309310C8F7222E2203AAFA1CE2354F48A5CB6ED014DAA; SizeAsReceived:7372; Count:47 Received: from ME1PR01MB0817.ausprd01.prod.outlook.com ([fe80::f1e8:5c17:6812:9ca3]) by ME1PR01MB0817.ausprd01.prod.outlook.com ([fe80::f1e8:5c17:6812:9ca3%12]) with mapi id 15.20.3721.024; Sun, 3 Jan 2021 06:19:34 +0000 From: yeholmes@outlook.com To: daniel@makrotopia.org Subject: [PATCH] state: check return value of chown Date: Sun, 3 Jan 2021 14:19:19 +0800 Message-ID: <ME1PR01MB0817E64C8F3ED940FB369309D0D30@ME1PR01MB0817.ausprd01.prod.outlook.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <X/CdNGPUFc1a4IQ3@makrotopia.org> References: <X/CdNGPUFc1a4IQ3@makrotopia.org> X-TMN: [xN+gKKWYWappR4gokf0dCYpk3+uMPScM] X-ClientProxiedBy: TYAPR01CA0075.jpnprd01.prod.outlook.com (2603:1096:404:2c::15) To ME1PR01MB0817.ausprd01.prod.outlook.com (2603:10c6:200:9::10) X-Microsoft-Original-Message-ID: <20210103061919.14184-1-yeholmes@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from localhost.localdomain (91.240.128.101) by TYAPR01CA0075.jpnprd01.prod.outlook.com (2603:1096:404:2c::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3721.20 via Frontend Transport; Sun, 3 Jan 2021 06:19:32 +0000 X-MS-PublicTrafficType: Email X-IncomingHeaderCount: 47 X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-Correlation-Id: 8d3c620d-fd37-495b-947d-08d8afaf8a09 X-MS-Exchange-SLBlob-MailProps: kw4jv30d2ySyfmZ9e940FKMLhKfWIqhvNxzCH3ln2BgV1vylSLJ/mGtlw748U+JaQ89ssdbZLc2IckNZ34FiFOFjrN99GCBz4z/uFuDzGtwlAiLNVjweKaCxvcTorJNdOzzEz+CjAHl+y4G7kGXnVEfSkkE3QKUUlLjKDVBGDok/VIsI1nleKsi4pez4yY5d7VZ9Z4Aaip3VgkInFwk8IjEO4iCwBpBXFQEFpj2E4djkpPFaS+vY0bZh3e2TEVw/t5Lw6ZI7Wye5knvN/lh5liG+lnGSN+GfjZhRlPvtQD2sg0y7MAz9shlFbR2zqTsy0YotCP0On/OoQynai6ksmcx5Uh7RV5kTIa1CaDaIfvfH1HroBishEkpTnND4Zqi3atJ5Q2q7InMoK3kWSXHR3aRXoPQyokqc+1YK7H+UOcPtTvDqeMDn6bXhhRPlDhfeSq8a9o7NL8ZFBj+oXEX3sSk8UPfVVNWizzgiLNXpx+ChAL4emJRMutWB1iolSWgT0o+UGUXpp/r7ZL8OVdZWIFwxRXAC7O64nLlwsxpSIsmsvCgAp8X5pKBHKSwGVdjglDHz/N+Aae+vXnZ1dtji+gEtsV80hUiX/IUpO1LXuTgmF2H6ekDk28WxC4BAuckANORTTi3I8lpcp46SScwlfv/GoZKhA5VKY5q9dP+gW6E= X-MS-TrafficTypeDiagnostic: SG2APC01HT051: X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: lb5HOt6rqXiW2800GXEMOAhoIpBlaI+NaO8icw/HChiT184tDEQmja2tspCjzURrX2JwROyu3/2BWmMN4mSTDbwQUd7U9piXKrtcZiV8D3QOpxHnbuGN9imzI9h1GgwH+r12GtL7u8JSZEUrBkJ5kvwfuYGe8mOjRehwbLEOsdPuXKJmAxUBnSMmuY3+5Gk76L97BQpnK4NCzD4lepW/bcV5HMDt25kw/FGbUiaEVWm2zscos+pEGn1SYSpL3yWw X-MS-Exchange-AntiSpam-MessageData: wQEOagDqe0EW7dCw12+iRpF56gPWPGDvLQSDJ2n6YXqpYGWdqi5zwyGP68EKchDG3XOM7q5XhUxd4K77NAMrrCCnTYXeQyqhIewotxvGOGac78q5a85tPXNuzR7i1zOeDpZEvpFmfnb7eLFTdT2WaA== X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Jan 2021 06:19:34.2456 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-Network-Message-Id: 8d3c620d-fd37-495b-947d-08d8afaf8a09 X-MS-Exchange-CrossTenant-AuthSource: SG2APC01FT008.eop-APC01.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: Internet X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: SG2APC01HT051 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210103_011951_703988_5DDDF15E X-CRM114-Status: GOOD ( 15.99 ) X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider [yeholmes[at]outlook.com] -0.0 SPF_PASS SPF: sender matches SPF record -0.0 SPF_HELO_PASS SPF: HELO matches SPF record 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain 0.0 MSGID_FROM_MTA_HEADER Message-Id was added by a relay X-BeenThere: openwrt-devel@lists.openwrt.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: OpenWrt Development List <openwrt-devel.lists.openwrt.org> List-Unsubscribe: <https://lists.openwrt.org/mailman/options/openwrt-devel>, <mailto:openwrt-devel-request@lists.openwrt.org?subject=unsubscribe> List-Archive: <http://lists.openwrt.org/pipermail/openwrt-devel/> List-Post: <mailto:openwrt-devel@lists.openwrt.org> List-Help: <mailto:openwrt-devel-request@lists.openwrt.org?subject=help> List-Subscribe: <https://lists.openwrt.org/mailman/listinfo/openwrt-devel>, <mailto:openwrt-devel-request@lists.openwrt.org?subject=subscribe> Cc: Ye Holmes <yeholmes@outlook.com>, openwrt-devel@lists.openwrt.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "openwrt-devel" <openwrt-devel-bounces@lists.openwrt.org> Errors-To: openwrt-devel-bounces+incoming=patchwork.ozlabs.org@lists.openwrt.org |
Series |
state: check return value of chown
|
expand
|
diff --git a/state.c b/state.c index 44f56c6..e9f101f 100644 --- a/state.c +++ b/state.c @@ -12,6 +12,7 @@ * GNU General Public License for more details. */ +#include <assert.h> #include <fcntl.h> #include <pwd.h> #include <sys/reboot.h> @@ -144,7 +145,7 @@ static void state_enter(void) if (p) { LOG("- ubus -\n"); mkdir(p->pw_dir, 0755); - chown(p->pw_dir, p->pw_uid, p->pw_gid); + assert(chown(p->pw_dir, p->pw_uid, p->pw_gid) == 0); } else { LOG("- ubus (running as root!) -\n"); }