From patchwork Fri Oct 30 21:42:43 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Felix Fietkau X-Patchwork-Id: 538528 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from arrakis.dune.hu (arrakis.dune.hu [78.24.191.176]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id E83BA1402D0 for ; Sat, 31 Oct 2015 08:43:07 +1100 (AEDT) Received: from arrakis.dune.hu (localhost [127.0.0.1]) by arrakis.dune.hu (Postfix) with ESMTP id 8E368281091; Fri, 30 Oct 2015 22:41:05 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on arrakis.dune.hu X-Spam-Level: X-Spam-Status: No, score=-2.5 required=5.0 tests=ALL_TRUSTED,BAYES_00 autolearn=unavailable version=3.3.2 Received: from localhost (localhost [127.0.0.1]) by arrakis.dune.hu (Postfix) with ESMTP id 44C6F2807F4; Fri, 30 Oct 2015 22:41:00 +0100 (CET) X-Virus-Scanned: at arrakis.dune.hu Received: from nf.lan (p54895E8E.dip0.t-ipconnect.de [84.137.94.142]) by arrakis.dune.hu (Postfix) with ESMTPSA id A1E5228050D; Fri, 30 Oct 2015 22:40:58 +0100 (CET) To: =?UTF-8?Q?Petr_=c5=a0tetiar?= References: <1445862409-9132-1-git-send-email-ynezz@true.cz> <56338969.5090707@openwrt.org> <20151030212013.GX19674@ibawizard.net> From: Felix Fietkau Message-ID: <5633E453.9060106@openwrt.org> Date: Fri, 30 Oct 2015 22:42:43 +0100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <20151030212013.GX19674@ibawizard.net> Cc: openwrt-devel@lists.openwrt.org Subject: Re: [OpenWrt-Devel] [PATCH] image.mk: Add NOTPARALLEL flag to fix parallel build breakage X-BeenThere: openwrt-devel@lists.openwrt.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: OpenWrt Development List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: openwrt-devel-bounces@lists.openwrt.org Sender: "openwrt-devel" On 2015-10-30 22:20, Petr Štetiar wrote: > Felix Fietkau [2015-10-30 16:14:49]: > > Hi, > >> I'd like to find out where the real bug is - what target are you >> building where you hit this error? > > it's imx6 target, but probably kirkwood, lantiq, mxs and oxnas are affected > also (just by guessing by output from 'git grep Image/InstallKernel/Template'). > > I think, that the problem is lying in include/image.mk: > > 556 kernel_prepare: mkfs_prepare > 557 $(call Image/BuildKernel) > 558 $(if $(CONFIG_TARGET_ROOTFS_INITRAMFS),$(if $(IB),,$(call Image/BuildKernel/Initramfs))) > 559 $(call Image/InstallKernel) > 560 > 561 $(foreach device,$(TARGET_DEVICES),$(call Device,$(device))) > 562 $(foreach fs,$(TARGET_FILESYSTEMS) $(fs-subtypes-y),$(call BuildImage/mkfs,$(fs))) > > where probably Image/InstallKernel is run in parallel with BuildImage/mkfs and > Image/InstallKernel then touches $(TARGET_DIR)/boot which Image/mkfs/targz is > compressing in another job. Does this patch fix things for you? --- a/include/image.mk +++ b/include/image.mk @@ -282,7 +282,7 @@ endef define BuildImage/mkfs install: mkfs-$(1) .PHONY: mkfs-$(1) - mkfs-$(1): mkfs_prepare + mkfs-$(1): kernel_prepare $(Image/mkfs/$(1)) $(call Build/mkfs/default,$(1)) $(call Build/mkfs/$(1),$(1))