From patchwork Fri Apr 5 11:06:52 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Paul Donald X-Patchwork-Id: 1920217 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=r1u8ho2R; dkim=fail reason="signature verification failed" (2048-bit key; secure) header.d=infradead.org header.i=@infradead.org header.a=rsa-sha256 header.s=desiato.20200630 header.b=QHtaYfSh; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20230601 header.b=Af0FjfHL; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.openwrt.org (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org; envelope-from=openwrt-devel-bounces+incoming=patchwork.ozlabs.org@lists.openwrt.org; receiver=patchwork.ozlabs.org) Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4V9wn82R3Wz1yZM for ; Fri, 5 Apr 2024 22:12:28 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:To:From:Reply-To:Cc:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=KQ4RQwojaYy+yqoXbSCJztFwj+3TLYOl3znw5m3aXio=; b=r1u8ho2RgaYD0t lQ1AwQ9gPrana5bq8S6Qou4gPhc5mNqrktLu/zrqdG314oZabwgti223WL2GWw9jX7TdzDh/JVDJq WW33vH3lUrKDXajA6b4KhT1gU8WFY9NOndR+gKuDJ8L7GTSrm2zzmhfxZpKhDiTX0vsCIswo4aGvm KosYrvO8y7uPED4semrC8zNJ24RmrsoE58cWblr64uFcTdJAVhg9ZeNUeT12KmQY4fluwyF3kXqXX vESf5VwU8YDq4pYO0LJSqmh0T6vNm5/MMKtLourBlFuRNVEYheMfGa/qp5w0FI5nwhfL7vQD4LCF+ ++hcwnn4le//YiKZhEfw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rshTa-00000006c66-3c1o; Fri, 05 Apr 2024 11:11:18 +0000 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rshTF-00000006btW-1moH for openwrt-devel@bombadil.infradead.org; Fri, 05 Apr 2024 11:10:57 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=Content-Transfer-Encoding:MIME-Version :References:In-Reply-To:Message-ID:Date:Subject:To:From:Sender:Reply-To:Cc: Content-Type:Content-ID:Content-Description; bh=zS/p2Z3RYBewPWK7Ly6/Uv28U3F9M7the7+ArJijWLA=; b=QHtaYfSh6WyAnFAUTjV9HLlwgQ bsJ7NOigWkxDhY1kOY4S6/eA6RWilwriYsgLxQu9uIvR/GBU9jxx7vu3IuTuo8Ny+Oz+HFR1+ziiO SgwMGsQ3CifZjcwrhULHg5C5F3ouPcXhAtVXf8KfWiq24ekqr4Nd4Ts+maEMVNPSR/85R7ufcDt5J ncz/C8Acy+GwpSlA4n77ka7Rf8/EaGgLYbtcEoMBtYXTpjNr8QVP96EhG+MT1r2CqUmzvv9BSZwPe M3bSC6d1SsiAxN9CKjuDzTI/UsyUBbxXx4ZN0IIiVdctayHQlyJeUKPCJC2en0VRzGsbqRM5P8IOJ oQNiHWIg==; Received: from mail-lf1-x133.google.com ([2a00:1450:4864:20::133]) by desiato.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rshSz-00000005ZpH-3zTa for openwrt-devel@lists.openwrt.org; Fri, 05 Apr 2024 11:10:49 +0000 Received: by mail-lf1-x133.google.com with SMTP id 2adb3069b0e04-516d09bd434so1718857e87.1 for ; Fri, 05 Apr 2024 04:10:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1712315432; x=1712920232; darn=lists.openwrt.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:sender:from:to:cc:subject:date :message-id:reply-to; bh=zS/p2Z3RYBewPWK7Ly6/Uv28U3F9M7the7+ArJijWLA=; b=Af0FjfHLr913/EeVHdHUPnGMzPx0H4aVs+t2VqxUoRTk6CQyg++ozmEGCejvRrkHeA zEl3xh6aezzi1DU0Sxas41WQMXWuzhkBQv6FWqQc/hsz9b6VfjXoQrmX4MVim0mMi5Du SourXnQulzh5Eysci1vkVe7CeIYNurxysX2fI72xqZW2p3dFlNis/v8752VwOlLf6EAg 3X+UZqSBVtj4830dh784EENCT7oylGBv5pn/DaFhOdt0XeT9MysZBIatT3mXrhnBSPZW AMXzWs0AH09eBBZWxzNqVqVECjp9aktlXohPmsXrFBJKoD+yozqMnjxq/ea26X6xaodo tlTw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712315432; x=1712920232; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:sender:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=zS/p2Z3RYBewPWK7Ly6/Uv28U3F9M7the7+ArJijWLA=; b=psJPBiP4138gARcaEcYS60W/jIoMOJyWbNg7RrOayyx+RjL/jEyZWQQ0/pIuE9eNkA JViUwqaow2M/KUXqsnH+Ymx8KCuw5euRDpHfq6T46MC8pRj3ei0THThqLIFHsEU+giUK b27K2wyqqHjI5AvPG0hjy7QvCvrbRXLBlkOgoRO5ck8j0UoPthkCnUr+yhv6EXqAv8vx TOVco9oJwpHYWXS/vfr9t1MGxanHZYdNgib4+AuDyj1+Vi0xbp8TB409GDC1TrlRgqKz cSzB2LLmr7GGKXuUOmbYJybs3nWOqO7VAun9nRJByWvW/nFBklW/m/Mmex+Pv0tSmtM7 CPLA== X-Gm-Message-State: AOJu0YyTKG1WQbcNbd19VT4xcrqX7C3q3kmFLOUMP4RU1kydiKsBSPLG 17SHHoUVSGDHCuoRinTsJObUxIKIqdFBv8HiqUtM3bC4JAx2/fRUQ53flZusg5zw9Q== X-Google-Smtp-Source: AGHT+IGDe9VuKjtnX0vP/XAfKE8M3sjYIX/IZoenlqleA2TbLg3W7V5O1jp1uZ/sktvUkyqn7gFpkw== X-Received: by 2002:ac2:5612:0:b0:516:d414:c09d with SMTP id v18-20020ac25612000000b00516d414c09dmr882599lfd.4.1712315432135; Fri, 05 Apr 2024 04:10:32 -0700 (PDT) Received: from blackhol3 ([2001:9b0:40::cae3:cb03]) by smtp.gmail.com with ESMTPSA id g21-20020ac24d95000000b00516cdadf377sm163719lfe.137.2024.04.05.04.10.31 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Apr 2024 04:10:31 -0700 (PDT) From: Paul Donald To: OpenWrt Development List Subject: [PATCH v2 8/9] router: DNSRecursiveDNS and DNSSearchOpt Type comments Date: Fri, 5 Apr 2024 13:06:52 +0200 Message-ID: <20240405111025.26478-9-newtwen+github@gmail.com> X-Mailer: git-send-email 2.44.0 In-Reply-To: <20240405111025.26478-1-newtwen+github@gmail.com> References: <20240405005510.19778-1-newtwen+github@gmail.com> <20240405111025.26478-1-newtwen+github@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240405_121042_195719_BD57BD0D X-CRM114-Status: GOOD ( 11.22 ) X-Spam-Score: -0.2 (/) X-Spam-Report: Spam detection software, running on the system "desiato.infradead.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: From: Paul Donald Signed-off-by: Paul Donald Reviewed-by: Daniel Golle --- src/router.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/router.c b/src/router.c index 4239aa8..c87fd39 100644 --- a/src/router.c +++ b/src/router.c @@ -668,7 +668,7 @@ static int send_router_advert(struct interface *iface, const struct in6 [...] Content analysis details: (-0.2 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider [newtwen+github(at)gmail.com] -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:133 listed in] [list.dnswl.org] X-BeenThere: openwrt-devel@lists.openwrt.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: OpenWrt Development List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "openwrt-devel" Errors-To: openwrt-devel-bounces+incoming=patchwork.ozlabs.org@lists.openwrt.org From: Paul Donald Signed-off-by: Paul Donald Reviewed-by: Daniel Golle --- src/router.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/router.c b/src/router.c index 4239aa8..c87fd39 100644 --- a/src/router.c +++ b/src/router.c @@ -668,7 +668,7 @@ static int send_router_advert(struct interface *iface, const struct in6_addr *fr uint8_t *search_domain = iface->search; uint8_t search_buf[256]; - /* DNS Recursive DNS */ + /* DNS Recursive DNS aka RDNSS Type 25; RFC8106 */ if (iface->dns_cnt > 0) { dns_addr = iface->dns; dns_cnt = iface->dns_cnt; @@ -688,7 +688,7 @@ static int send_router_advert(struct interface *iface, const struct in6_addr *fr memcpy(dns->addr, dns_addr, sizeof(struct in6_addr)*dns_cnt); } - /* DNS Search options */ + /* DNS Search options aka DNSSL Type 31; RFC8106 */ if (!search_domain && !res_init() && _res.dnsrch[0] && _res.dnsrch[0][0]) { int len = dn_comp(_res.dnsrch[0], search_buf, sizeof(search_buf), NULL, NULL);