From patchwork Fri Apr 5 00:53:06 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Paul Donald X-Patchwork-Id: 1920014 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=f9GzAeki; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20230601 header.b=PFmmh7An; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.openwrt.org (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org; envelope-from=openwrt-devel-bounces+incoming=patchwork.ozlabs.org@lists.openwrt.org; receiver=patchwork.ozlabs.org) Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4V9g7H65cyz23vH for ; Fri, 5 Apr 2024 11:57:13 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:To:From:Reply-To: Cc:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=9Xrnth90b5Of2+69xf3Hby0S3sKEkkPcfDK6lTYGWEs=; b=f9GzAekiGm6N/zGTz53iqTma9M VtVxvYwjQpjQyxrZpD8HfBaemund/e9C3htK10hfTxLBCVhE0fDlB8YMJeY6Ug/khVYlNL0ZHXjT4 3QWDs4N1PclZAQ1TXe3ca9O7WsQpqQkKpjAzkOClhD8EUVIdc9HNTt2v1WAbFG2Vr24TwEYKIOwIy ppDWU4ZxRKzEJOphafA5pq5GnubnkNMDJsjrwStirdvECqN5LNX9vQQT+krR5Z/OQRcJGYEawYE/K +lJn0aBJr4SE9aI9NGLhDju6NDVlKNL+e5hIpbqqIIg2m2u6Q5OynRErdY+zlf/OuuQ4qC7317bIV eSUSVd6w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rsXrd-00000004kIV-26DT; Fri, 05 Apr 2024 00:55:29 +0000 Received: from mail-lj1-x22d.google.com ([2a00:1450:4864:20::22d]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rsXrQ-00000004kDB-1m3Q for openwrt-devel@lists.openwrt.org; Fri, 05 Apr 2024 00:55:19 +0000 Received: by mail-lj1-x22d.google.com with SMTP id 38308e7fff4ca-2d109e82bd0so18214851fa.3 for ; Thu, 04 Apr 2024 17:55:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1712278514; x=1712883314; darn=lists.openwrt.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:sender:from:to:cc:subject:date :message-id:reply-to; bh=74Uebden/znLTS9auSccUvMXAF9+gOsX9RxrTB2c39A=; b=PFmmh7AnvQ6dHwA+V6+ahjLMm4tC1tNuYqoiiwTQsCAfzvcV+1KAWJAD33s8hGkTXD riSbjidKtqDUTicrYvNK5nu4r6YGT5jX2M3phy/89mB4bcRFMxY18wnZbsmaXlGvJetu 1MtbclYoJDho3MszTucI6yMAz+K6mB1y1lOTWVPiq+HFqvnaOWD4VIorUprVVaEeqeiF UBmPTODony99vtQRsgWsOs3iI4rLCMmqym7ahmuWMWUvYNzGC6kMSKXu3jvJibWn61cf oxqAssj3LWvTEKZUGqwlpSjP4N78G2XQLSK6XZn+meLjRBMeprZNuc9qGUS7xbYoyolK Ojfg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712278514; x=1712883314; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:sender:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=74Uebden/znLTS9auSccUvMXAF9+gOsX9RxrTB2c39A=; b=DrN1IBBpU7Qcn3nmAzbcKkwLLlO1FjjspMsm591QA99bOInnakTzUWafe9Ya7OCWbe JSjpMK9EvTNY4QNlUs6dyOql/gCaWkkf5uutVh2gbLQncYYsg6fRVb1d1+QUGjcRYKID KlqEDETfx0kxqOIjStUxatLkTr7fqrx9YW4hmQVa0RLCh/ShVVOSRoOpQUhVUP1D2nNo uZQC3zA0RX+RWH8zZ0KKCpjHaFs/Of7Qv+M8Vv6n/biwJYp3nRhHOKcd2wvBVXBDf5L9 EBWQELH80vb/dNS9z0ylA5vNcsZlvhuiFxGn9PKJ2XK2uM/io4kLMcMLZq8qVX/2g2Bc 2b/w== X-Gm-Message-State: AOJu0Yw9aSURX7BEPZhROPibESIjUHTltYGP2/uyM6/kwA9vkQAFadAJ h7CtbDon41yZqN67jyQEFOimic1aFvSKrmqMm+uz6Ha90JPqUGOXRKPJ0MpLMOU= X-Google-Smtp-Source: AGHT+IFEp8cPRTd9rKVxQQZIXwq76+LkRdj+DA08Fn6+Rv402PF2fbPZXy48PNWOjujyPb8Gn2k6hw== X-Received: by 2002:a05:6512:536:b0:515:cf15:285a with SMTP id o22-20020a056512053600b00515cf15285amr677313lfc.61.1712278513614; Thu, 04 Apr 2024 17:55:13 -0700 (PDT) Received: from blackhol3 ([2001:9b0:40::cae3:cb03]) by smtp.gmail.com with ESMTPSA id a1-20020ac25201000000b00516c1bddfecsm46630lfl.182.2024.04.04.17.55.12 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 04 Apr 2024 17:55:12 -0700 (PDT) From: Paul Donald To: OpenWrt Development List Subject: [PATCH 3/9] various: Comment fixes Date: Fri, 5 Apr 2024 02:53:06 +0200 Message-ID: <20240405005510.19778-4-newtwen+github@gmail.com> X-Mailer: git-send-email 2.44.0 In-Reply-To: <20240405005510.19778-1-newtwen+github@gmail.com> References: <20240405005510.19778-1-newtwen+github@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240404_175516_535620_6E546DB5 X-CRM114-Status: GOOD ( 14.55 ) X-Spam-Score: -0.2 (/) X-Spam-Report: Spam detection software, running on the system "bombadil.infradead.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: From: Paul Donald Signed-off-by: Paul Donald --- src/dhcpv4.c | 2 +- src/dhcpv6-ia.c | 6 +++--- src/netlink.c | 2 +- src/router.c | 2 +- 4 files changed, 6 insertions(+), 6 deletions(-) diff --git a/src/dhcpv4.c b/src/dhcpv4.c index 3191ff2..cb0484f 100644 --- a/src/dhcpv4.c +++ b/src/dhcpv4.c @@ -893,7 +893,7 @@ void dhcpv4_handle_msg(void *addr, void *data, size_t len, struct arpre [...] Content analysis details: (-0.2 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider [newtwen+github(at)gmail.com] -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:22d listed in] [list.dnswl.org] X-BeenThere: openwrt-devel@lists.openwrt.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: OpenWrt Development List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "openwrt-devel" Errors-To: openwrt-devel-bounces+incoming=patchwork.ozlabs.org@lists.openwrt.org From: Paul Donald Signed-off-by: Paul Donald --- src/dhcpv4.c | 2 +- src/dhcpv6-ia.c | 6 +++--- src/netlink.c | 2 +- src/router.c | 2 +- 4 files changed, 6 insertions(+), 6 deletions(-) diff --git a/src/dhcpv4.c b/src/dhcpv4.c index 3191ff2..cb0484f 100644 --- a/src/dhcpv4.c +++ b/src/dhcpv4.c @@ -893,7 +893,7 @@ void dhcpv4_handle_msg(void *addr, void *data, size_t len, struct arpreq arp = {.arp_flags = ATF_COM}; /* - * send reply to the newly (in this proccess) allocated IP + * send reply to the newly (in this process) allocated IP */ dest.sin_addr = reply.yiaddr; dest.sin_port = htons(DHCPV4_CLIENT_PORT); diff --git a/src/dhcpv6-ia.c b/src/dhcpv6-ia.c index 39a316a..dde224d 100644 --- a/src/dhcpv6-ia.c +++ b/src/dhcpv6-ia.c @@ -1142,11 +1142,11 @@ static size_t build_ia(uint8_t *buf, size_t buflen, uint16_t status, } if (!INFINITE_VALID(a->valid_until)) - /* UINT32_MAX is considered as infinite leasetime */ + /* UINT32_MAX is RFC defined as infinite lease-time */ a->valid_until = (valid_lt == UINT32_MAX) ? 0 : valid_lt + now; if (!INFINITE_VALID(a->preferred_until)) - /* UINT32_MAX is considered as infinite leasetime */ + /* UINT32_MAX is RFC defined as infinite lease-time */ a->preferred_until = (preferred_lt == UINT32_MAX) ? 0 : preferred_lt + now; o_ia.t1 = htonl((preferred_lt == UINT32_MAX) ? preferred_lt : preferred_lt * 5 / 10); @@ -1570,7 +1570,7 @@ ssize_t dhcpv6_ia_handle_IAs(uint8_t *buf, size_t buflen, struct interface *ifac /* Set error status */ status = (is_pd) ? DHCPV6_STATUS_NOPREFIXAVAIL : DHCPV6_STATUS_NOADDRSAVAIL; else if (hdr->msg_type == DHCPV6_MSG_REQUEST && !dhcpv6_ia_on_link(ia, a, iface)) { - /* Send NOTONLINK staus for the IA */ + /* Send NOTONLINK status for the IA */ status = DHCPV6_STATUS_NOTONLINK; assigned = false; } else if (accept_reconf && assigned && !first && diff --git a/src/netlink.c b/src/netlink.c index c33e3ea..368e69c 100644 --- a/src/netlink.c +++ b/src/netlink.c @@ -213,7 +213,7 @@ static void refresh_iface_addr6(int ifindex) if (change) { /* - * Keep track on removed prefixes, so we could advertise them as invalid + * Keep track of removed prefixes, so we could advertise them as invalid * for at least a couple of times. * * RFC7084 § 4.3 : diff --git a/src/router.c b/src/router.c index 6a9e19d..335218f 100644 --- a/src/router.c +++ b/src/router.c @@ -709,7 +709,7 @@ static int send_router_advert(struct interface *iface, const struct in6_addr *fr iov[IOV_RA_SEARCH].iov_len = search_sz; if (iface->pref64_length) { - /* RFC 8781 § 4.1 rounding up lifetime to multiply of 8 */ + /* RFC 8781 § 4.1 rounding up lifetime to multiple of 8 */ uint16_t pref64_lifetime = lifetime < (UINT16_MAX - 7) ? lifetime + 7 : UINT16_MAX; uint8_t prefix_length_code; uint32_t mask_a1, mask_a2;