Message ID | 20240405005510.19778-10-newtwen+github@gmail.com |
---|---|
State | Superseded |
Headers | show
Return-Path: <openwrt-devel-bounces+incoming=patchwork.ozlabs.org@lists.openwrt.org> X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=jVi7JQOG; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20230601 header.b=iSMVg3vl; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.openwrt.org (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org; envelope-from=openwrt-devel-bounces+incoming=patchwork.ozlabs.org@lists.openwrt.org; receiver=patchwork.ozlabs.org) Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4V9g7H5bbmz23vG for <incoming@patchwork.ozlabs.org>; Fri, 5 Apr 2024 11:57:14 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:To:From:Reply-To:Cc:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=1No1TIHnJDKdiE+w+MLbAabNUv131y/2REWrBLrHkDg=; b=jVi7JQOGGHFRpk Jas1/31mKT9GEb5NKTawz2/OiGo+XotKqqwzh9W9ehUTtpJXMET9ebiZ0QLbve/gXPK964IPTmNtU 1i/Tu4XH+quUUd6iqJcQ+w9kkb36O690+9sU9fY63ibk3xy6Y7ON8z6RiJDeybkjDaTHym3LY+Qz6 FCBR4Z2dBqQUbJV1LLjDEsy2eFvSuu8ziQWh23ALndY7ZpqI7WqG+I0U2Gf/uPQU+2PlnwjdQnMAi duTdNO4FitA9+9Evpk6u22dURldCihzgKOmTt1t1ZCWwJO7qpdAkdfaVuDW7QutjzUujMQxCl/er4 UWJGIKaj17Sa9ie7q8sw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rsXrl-00000004kKn-0UHi; Fri, 05 Apr 2024 00:55:37 +0000 Received: from mail-lf1-x132.google.com ([2a00:1450:4864:20::132]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rsXrU-00000004kFT-3vzx for openwrt-devel@lists.openwrt.org; Fri, 05 Apr 2024 00:55:22 +0000 Received: by mail-lf1-x132.google.com with SMTP id 2adb3069b0e04-516c08c25e1so2185399e87.1 for <openwrt-devel@lists.openwrt.org>; Thu, 04 Apr 2024 17:55:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1712278519; x=1712883319; darn=lists.openwrt.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:sender:from:to:cc:subject:date :message-id:reply-to; bh=Vt6hG2s4vu2SDzBt+Mo0+6cbljt3YsJYB8uedjVJkaM=; b=iSMVg3vliLkNV0vonBnNeIbXph+ZYgFWCtRqVKqIycadp+X/gcDUY95l/Q4HE3zn5j 6/YAWI58EOdr+Qrc4obz7iuU2NzN10ExLX0/gRhdzgWvhDr25kZy0Dqr7S0836TCNqei 6y0y+LPTzS6fI8lC/PWB6sgkoU2lGxTOHY8nDrHyqWkI5QZgPn1XUJ6/hRA8m3jCOe2J 6A8bKN2K0trO4ML8s2UVcJQuNlmbvhhtrrN5MHgqofA90ngxSd7rNCzu7ijcqASlipZW nE6hS4zyijFZz2ZVE1Kz8zNk3H5s1FbtYGfeU/mUg0UH+jr5Voffq+qpiqIwGBfcHUbM aYYg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712278519; x=1712883319; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:sender:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=Vt6hG2s4vu2SDzBt+Mo0+6cbljt3YsJYB8uedjVJkaM=; b=T5grq+sU7VXZtxUxJqMp7kx7/HjoEcSMP5FN7BK/TDhUsfvrAezKQbpySnwRyu+ZV6 eMH+g28cYTvSs824AW34xgpuckpQXbbhOeQCDZ2CbO5Gcti2Fn5yUL60yLkt53eYfnYj zDX9Zz6hRnnVpLXOsx5T65t27iC+FzctcpU3PXaLtpAnsHZkjI83dUWu/KC4oehxKEEK f7YaJwu6zM81gpH7m+hnQwCbdOseH5JAalhyjSfOt7Jnji+Gx9iY+C/l/sw4Dj7o6khO n0+uQdF1s+PaCOnWsLGa0ov/ENamPiBee0urtNFyx6m6iAaHyg9MYPbc0FNq9fVlGQA6 nvGw== X-Gm-Message-State: AOJu0YzPNtUpdVxCo8KJnltDySlAT409ZIdTgQlqkJjmdOs3S+E7mmGS oRczU2WgJakAyvijIMO4oPu9iA8c2X04s3CuHODFvfFxCK9Lm1Uet5c8bG9tcTM= X-Google-Smtp-Source: AGHT+IESYgjM62AvGNNHhWw3pcIz2wAkhcXXlDFGfmVe4EmvzSxQfR9+gaR5ixabkZuZ7kJCLRvnhQ== X-Received: by 2002:a19:8c1b:0:b0:516:b4e1:9b12 with SMTP id o27-20020a198c1b000000b00516b4e19b12mr658148lfd.34.1712278519174; Thu, 04 Apr 2024 17:55:19 -0700 (PDT) Received: from blackhol3 ([2001:9b0:40::cae3:cb03]) by smtp.gmail.com with ESMTPSA id a1-20020ac25201000000b00516c1bddfecsm46630lfl.182.2024.04.04.17.55.17 for <openwrt-devel@lists.openwrt.org> (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 04 Apr 2024 17:55:18 -0700 (PDT) From: Paul Donald <newtwen+github@gmail.com> To: OpenWrt Development List <openwrt-devel@lists.openwrt.org> Subject: [PATCH 9/9] ndp: Comments Date: Fri, 5 Apr 2024 02:53:12 +0200 Message-ID: <20240405005510.19778-10-newtwen+github@gmail.com> X-Mailer: git-send-email 2.44.0 In-Reply-To: <20240405005510.19778-1-newtwen+github@gmail.com> References: <20240405005510.19778-1-newtwen+github@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240404_175521_041941_598DADD0 X-CRM114-Status: GOOD ( 10.61 ) X-Spam-Score: -0.2 (/) X-Spam-Report: Spam detection software, running on the system "bombadil.infradead.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: From: Paul Donald Signed-off-by: Paul Donald --- src/ndp.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/ndp.c b/src/ndp.c index dfbb111..0ec6fed 100644 --- a/src/ndp.c +++ b/src/ndp.c @@ -39,7 +39,7 @@ static void setup_addr_for_relaying(struct in6_addr *addr, struct interface *ifa stat [...] Content analysis details: (-0.2 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:132 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider [newtwen+github(at)gmail.com] X-BeenThere: openwrt-devel@lists.openwrt.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: OpenWrt Development List <openwrt-devel.lists.openwrt.org> List-Unsubscribe: <https://lists.openwrt.org/mailman/options/openwrt-devel>, <mailto:openwrt-devel-request@lists.openwrt.org?subject=unsubscribe> List-Archive: <http://lists.openwrt.org/pipermail/openwrt-devel/> List-Post: <mailto:openwrt-devel@lists.openwrt.org> List-Help: <mailto:openwrt-devel-request@lists.openwrt.org?subject=help> List-Subscribe: <https://lists.openwrt.org/mailman/listinfo/openwrt-devel>, <mailto:openwrt-devel-request@lists.openwrt.org?subject=subscribe> Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "openwrt-devel" <openwrt-devel-bounces@lists.openwrt.org> Errors-To: openwrt-devel-bounces+incoming=patchwork.ozlabs.org@lists.openwrt.org |
Series |
odhcpd patchset
|
expand
|
diff --git a/src/ndp.c b/src/ndp.c index dfbb111..0ec6fed 100644 --- a/src/ndp.c +++ b/src/ndp.c @@ -39,7 +39,7 @@ static void setup_addr_for_relaying(struct in6_addr *addr, struct interface *ifa static void handle_solicit(void *addr, void *data, size_t len, struct interface *iface, void *dest); -/* Filter ICMPv6 messages of type neighbor soliciation */ +/* Filter ICMPv6 messages of type neighbor solicitation */ static struct sock_filter bpf[] = { BPF_STMT(BPF_LD | BPF_B | BPF_ABS, offsetof(struct ip6_hdr, ip6_nxt)), BPF_JUMP(BPF_JMP | BPF_JEQ | BPF_K, IPPROTO_ICMPV6, 0, 3), @@ -343,7 +343,7 @@ static void handle_solicit(void *addr, void *data, size_t len, return; if (len < sizeof(*ip6) + sizeof(*req)) - return; // Invalid reqicitation + return; // Invalid total length if (IN6_IS_ADDR_LINKLOCAL(&req->nd_ns_target) || IN6_IS_ADDR_LOOPBACK(&req->nd_ns_target) ||