diff mbox series

[5/5] base-files: sysupgrade: rename add_*files() functions

Message ID 20240212105701.5812-5-zajec5@gmail.com
State Accepted
Delegated to: Rafał Miłecki
Headers show
Series [1/5] base-files: sysupgrade: replace UMOUNT_ETCBACKUP_DIR with a local variable | expand

Commit Message

Rafał Miłecki Feb. 12, 2024, 10:57 a.m. UTC 
From: Rafał Miłecki <rafal@milecki.pl>

Usage of word "add" was somehow misleading in those functions:
1. They don't really add (as in: append) anything. Result files are
   created from scratch.
2. It wasn't clear what adding files means. It could be understood as
   adding actual files somewhere (to existing archive?).

Also the word "add" was also a bit ambiguous.

Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
---
 package/base-files/files/sbin/sysupgrade | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
diff mbox series

Patch

diff --git a/package/base-files/files/sbin/sysupgrade b/package/base-files/files/sbin/sysupgrade
index e7de1f3446..1fcd44da2a 100755
--- a/package/base-files/files/sbin/sysupgrade
+++ b/package/base-files/files/sbin/sysupgrade
@@ -155,7 +155,7 @@  list_static_conffiles() {
 		\( -type f -o -type l \) $filter 2>/dev/null
 }
 
-add_conffiles() {
+build_list_of_backup_config_files() {
 	local file="$1"
 
 	( list_static_conffiles "$find_filter"; list_changed_conffiles ) |
@@ -163,7 +163,7 @@  add_conffiles() {
 	return 0
 }
 
-add_overlayfiles() {
+build_list_of_backup_overlay_files() {
 	local file="$1"
 
 	local packagesfiles=$1.packagesfiles
@@ -218,9 +218,9 @@  if [ $SAVE_OVERLAY = 1 ]; then
 		echo "Cannot find '/overlay/upper/etc', required for '-c'" >&2
 		exit 1
 	}
-	sysupgrade_init_conffiles="add_overlayfiles"
+	sysupgrade_init_conffiles="build_list_of_backup_overlay_files"
 else
-	sysupgrade_init_conffiles="add_conffiles"
+	sysupgrade_init_conffiles="build_list_of_backup_config_files"
 fi
 
 find_filter=""