| Message ID | 20230423134034.392771-1-openwrt@sebastianschaper.net |
|---|---|
| State | Accepted |
| Commit | 0601f7134d5f86f75997453eb30590b0f578cbfb |
| Headers | show |
| Series | ramips: fix green LED for D-Link DAP-X1860 | expand |
Reviewed-by: Philip Prindeville <philipp@redfish-solutions.com> > On Apr 23, 2023, at 7:40 AM, Sebastian Schaper <openwrt@sebastianschaper.net> wrote: > > It was found this device uses a single tri-color power/status LED > rather than individual red/orange LEDs, which also supports green. > > Add GPIO for green color and use with `boot` and `running` aliases. > > Signed-off-by: Sebastian Schaper <openwrt@sebastianschaper.net> > --- > .../linux/ramips/dts/mt7621_dlink_dap-x1860-a1.dts | 13 +++++++++---- > 1 file changed, 9 insertions(+), 4 deletions(-) > > diff --git a/target/linux/ramips/dts/mt7621_dlink_dap-x1860-a1.dts b/target/linux/ramips/dts/mt7621_dlink_dap-x1860-a1.dts > index 1aa3f7c91b..818d2d8c41 100644 > --- a/target/linux/ramips/dts/mt7621_dlink_dap-x1860-a1.dts > +++ b/target/linux/ramips/dts/mt7621_dlink_dap-x1860-a1.dts > @@ -15,9 +15,9 @@ > > aliases { > label-mac-device = &gmac0; > - led-boot = &led_power_orange; > + led-boot = &led_power_green; > led-failsafe = &led_power_red; > - led-running = &led_power_orange; > + led-running = &led_power_green; > led-upgrade = &led_power_red; > }; > > @@ -40,15 +40,20 @@ > leds { > compatible = "gpio-leds"; > > + led_power_green: power_green { > + label = "green:power"; > + gpios = <&gpio 3 GPIO_ACTIVE_LOW>; > + default-state = "on"; > + }; > + > led_power_red: power_red { > label = "red:power"; > gpios = <&gpio 7 GPIO_ACTIVE_LOW>; > }; > > - led_power_orange: power_orange { > + power_orange { > label = "orange:power"; > gpios = <&gpio 8 GPIO_ACTIVE_LOW>; > - default-state = "on"; > }; > > rssihigh { > -- > 2.34.1 > > > _______________________________________________ > openwrt-devel mailing list > openwrt-devel@lists.openwrt.org > https://lists.openwrt.org/mailman/listinfo/openwrt-devel
diff --git a/target/linux/ramips/dts/mt7621_dlink_dap-x1860-a1.dts b/target/linux/ramips/dts/mt7621_dlink_dap-x1860-a1.dts index 1aa3f7c91b..818d2d8c41 100644 --- a/target/linux/ramips/dts/mt7621_dlink_dap-x1860-a1.dts +++ b/target/linux/ramips/dts/mt7621_dlink_dap-x1860-a1.dts @@ -15,9 +15,9 @@ aliases { label-mac-device = &gmac0; - led-boot = &led_power_orange; + led-boot = &led_power_green; led-failsafe = &led_power_red; - led-running = &led_power_orange; + led-running = &led_power_green; led-upgrade = &led_power_red; }; @@ -40,15 +40,20 @@ leds { compatible = "gpio-leds"; + led_power_green: power_green { + label = "green:power"; + gpios = <&gpio 3 GPIO_ACTIVE_LOW>; + default-state = "on"; + }; + led_power_red: power_red { label = "red:power"; gpios = <&gpio 7 GPIO_ACTIVE_LOW>; }; - led_power_orange: power_orange { + power_orange { label = "orange:power"; gpios = <&gpio 8 GPIO_ACTIVE_LOW>; - default-state = "on"; }; rssihigh {
It was found this device uses a single tri-color power/status LED rather than individual red/orange LEDs, which also supports green. Add GPIO for green color and use with `boot` and `running` aliases. Signed-off-by: Sebastian Schaper <openwrt@sebastianschaper.net> --- .../linux/ramips/dts/mt7621_dlink_dap-x1860-a1.dts | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-)