| Message ID | 20221129111315.17005-1-arinc.unal@arinc9.com |
|---|---|
| State | New |
| Headers | show |
| Series | ramips: mt7621-dts: change DSA port labels to generic naming | expand |
Arınç ÜNAL <arinc.unal@arinc9.com> writes:
> Change the labels of the DSA ports to generic naming for switch ports.
Probably stupid question, but why?
The labels aren't required. Just drop them if no one depends on the
current default.
Bjørn
On 29.11.2022 14:35, Bjørn Mork wrote: > Arınç ÜNAL <arinc.unal@arinc9.com> writes: > >> Change the labels of the DSA ports to generic naming for switch ports. > > Probably stupid question, but why? Not stupid at all. > > The labels aren't required. Just drop them if no one depends on the > current default. I wouldn't prefer removing the labels altogether. Having labels for switch ports defined on the SoC devicetree is necessary for any device that would not have its own naming over it. Especially, evaluation or development boards (which their DTs are not necessarily on mainline Linux or OpenWrt) do this. Arınç
diff --git a/target/linux/ramips/dts/mt7621.dtsi b/target/linux/ramips/dts/mt7621.dtsi index 0eae4bb871..d4a920f8c4 100644 --- a/target/linux/ramips/dts/mt7621.dtsi +++ b/target/linux/ramips/dts/mt7621.dtsi @@ -529,31 +529,31 @@ port@0 { status = "disabled"; reg = <0>; - label = "lan0"; + label = "swp0"; }; port@1 { status = "disabled"; reg = <1>; - label = "lan1"; + label = "swp1"; }; port@2 { status = "disabled"; reg = <2>; - label = "lan2"; + label = "swp2"; }; port@3 { status = "disabled"; reg = <3>; - label = "lan3"; + label = "swp3"; }; port@4 { status = "disabled"; reg = <4>; - label = "lan4"; + label = "swp4"; }; port@6 {
Change the labels of the DSA ports to generic naming for switch ports. Signed-off-by: Arınç ÜNAL <arinc.unal@arinc9.com> --- I've made sure every devicetree which includes mt7621.dtsi has got its own label property. This won't break anything. Arınç --- target/linux/ramips/dts/mt7621.dtsi | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-)