diff mbox series

Addresses sed in-place without SELinux awareness

Message ID 20220501175404.182574-1-dominick.grift@defensec.nl
State Accepted
Delegated to: Daniel Golle
Headers show
Series Addresses sed in-place without SELinux awareness | expand

Commit Message

Dominick Grift May 1, 2022, 5:54 p.m. UTC 
sed(1) in busybox does not support this functionality:
https://git.savannah.gnu.org/cgit/sed.git/tree/sed/execute.c#n598

This causes /etc/group to become mislabeled when a package requests that a uid/gid be added on OpenWrt with SELinux

Signed-off-by: Dominick Grift <dominick.grift@defensec.nl>
---
 package/base-files/files/lib/functions.sh | 1 +
 1 file changed, 1 insertion(+)
diff mbox series

Patch

diff --git a/package/base-files/files/lib/functions.sh b/package/base-files/files/lib/functions.sh
index ee0c33845c..cb08f91d4f 100644
--- a/package/base-files/files/lib/functions.sh
+++ b/package/base-files/files/lib/functions.sh
@@ -387,6 +387,7 @@  group_add_user() {
 	[ -n "$IPKG_INSTROOT" ] || lock /var/lock/passwd
 	sed -i "s/$grp/$grp$delim$2/g" ${IPKG_INSTROOT}/etc/group
 	[ -n "$IPKG_INSTROOT" ] || lock -u /var/lock/passwd
+	selinuxenabled 2>/dev/null && restorecon /etc/group
 }
 
 user_add() {