diff mbox series

Revert "ipq40xx: document pcie wifi chip on the GL.Inet GL-B2200"

Message ID 20220417004248.131889-1-mrkiko.rs@gmail.com
State Superseded, archived
Delegated to: Christian Lamparter
Headers show
Series Revert "ipq40xx: document pcie wifi chip on the GL.Inet GL-B2200" | expand

Commit Message

Enrico Mioso April 17, 2022, 12:42 a.m. UTC
This reverts commit 80d34d9d593865248bf5a23794e9163895140de7.
This brings back the PCI Wi-Fi interface on the GL-B2200.

CC: Christian Lamparter <chunkeey@gmail.com>
Signed-off-by: Enrico Mioso <mrkiko.rs@gmail.com>
---
 .../files/arch/arm/boot/dts/qcom-ipq4019-gl-b2200.dts     | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

Comments

Rafał Miłecki April 27, 2022, 10:41 a.m. UTC | #1
On 17.04.2022 02:42, Enrico Mioso wrote:
> This reverts commit 80d34d9d593865248bf5a23794e9163895140de7.
> This brings back the PCI Wi-Fi interface on the GL-B2200.
> 
> CC: Christian Lamparter <chunkeey@gmail.com>
> Signed-off-by: Enrico Mioso <mrkiko.rs@gmail.com>

This description doesn't tell anything really. Please explain what
happens and why do we need this patch. How does it fix things.
Enrico Mioso April 27, 2022, 11:08 a.m. UTC | #2
Dear Rafał,
first of all, thanks a lot for taking the time and the patience to review this patch.

I explained the situation in more detail here:
http://lists.openwrt.org/pipermail/openwrt-devel/2022-April/038451.html

... admittedly, the subject was too generic.

Thanks!

Enrico
diff mbox series

Patch

diff --git a/target/linux/ipq40xx/files/arch/arm/boot/dts/qcom-ipq4019-gl-b2200.dts b/target/linux/ipq40xx/files/arch/arm/boot/dts/qcom-ipq4019-gl-b2200.dts
index 9d7259c354..754af7c820 100644
--- a/target/linux/ipq40xx/files/arch/arm/boot/dts/qcom-ipq4019-gl-b2200.dts
+++ b/target/linux/ipq40xx/files/arch/arm/boot/dts/qcom-ipq4019-gl-b2200.dts
@@ -219,7 +219,7 @@ 
 					reg = <0x5000 0x2f20>;
 				};
 
-				precal_art_9000: precal@9000 {
+				cal_art_9000: cal@9000 {
 					reg = <0x9000 0x2f20>;
 				};
 			};
@@ -361,11 +361,11 @@ 
 
 		wifi2: wifi@1,0 {
 			status = "okay";
-			/* Bootlog shows this is a 168c:0056 - QCA 9888v2 */
 			compatible = "qcom,ath10k";
 			reg = <0x00010000 0 0 0 0>;
-			nvmem-cell-names = "pre-calibration";
-			nvmem-cells = <&precal_art_9000>;
+			 /* vendor said 9886 wave-2? Is this correct? */
+			nvmem-cell-names = "calibration";
+			nvmem-cells = <&cal_art_9000>;
 			qcom,ath10k-calibration-variant = "GL-B2200";
 			ieee80211-freq-limit = <5450000 5900000>;
 		};