From patchwork Thu Aug 19 16:51:45 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jan Hoffmann X-Patchwork-Id: 1518755 X-Patchwork-Delegate: hauke@hauke-m.de Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.openwrt.org (client-ip=2607:7c80:54:e::133; helo=bombadil.infradead.org; envelope-from=openwrt-devel-bounces+incoming=patchwork.ozlabs.org@lists.openwrt.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; secure) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=TxzfDVCt; dkim=fail reason="signature verification failed" (2048-bit key; secure) header.d=3e8.eu header.i=@3e8.eu header.a=rsa-sha256 header.s=mail20170724 header.b=o7fTlyqv; dkim-atps=neutral Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4Gr9tQ51n1z9ssD for ; Fri, 20 Aug 2021 02:57:34 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=ofoHb2IGu5OmvHqMljeS296n4Pw+UQgOOaUFToSHoNQ=; b=TxzfDVCtA7G8fM 0DYGrt9AapqXwU1McheIjUB9mtOau/tyQBZxXnc4OeyAPlveD2Apv9nz4meSsIu7+PUzKWPTX4U8j RWyVFPBHbAqTTO2HQ5rQFLSHb3zMDJ+DB6F9qYMeYWMGtJcvzWapgOorSirckiqaWFgoIw1Po2WQP 98dmq4RJlbcbgE1GlZE/7g0/Iw82SyuBqXJkZ4hV5kOa14T4Ig0+BfVCqwbX/oUaJSJyB8rxDo2X4 f2kHZaMKVLLgFb6PxIf0EVZJVqnCohMAuZ8tL4MyiffO1GxWjqi4bcV3TyFcJJVFod+upFz6o8a2p WtBoURPCixBBvIOC4HNA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mGlHD-008zt4-9J; Thu, 19 Aug 2021 16:52:23 +0000 Received: from srv4.3e8.eu ([193.25.101.238]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mGlH6-008zsF-Tx for openwrt-devel@lists.openwrt.org; Thu, 19 Aug 2021 16:52:21 +0000 Received: from localhost.localdomain (p200300c6cf200aa073992dd77668eed5.dip0.t-ipconnect.de [IPv6:2003:c6:cf20:aa0:7399:2dd7:7668:eed5]) (using TLSv1.3 with cipher TLS_CHACHA20_POLY1305_SHA256 (256/256 bits)) (No client certificate requested) by srv4.3e8.eu (Postfix) with ESMTPSA id 157D4626AC; Thu, 19 Aug 2021 18:52:02 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=3e8.eu; s=mail20170724; t=1629391923; bh=xYEdd9oG7mUX7XIvMMkZOnluW8KvucvMBAOopulJMps=; h=From:To:Cc:Subject:Date:From; b=o7fTlyqvrSqKgvXS1HuJjNipw1/MtOyVl0TWxtAQGy8Xc2vzRMxtf+tVbqLsiDSDE kqd1nO0E8Vua+Fm/wclu4E8zs4QHAUzft3uVYqi1YdQHOCTkedjeQEwo6nxbqFDM8/ MeXPxjZIheT11wmW4LU5++zCFCluB7l0Y5JbR5vGmqOtQxK508V0QFVMFC+4/DIhIj 5O3HOZkh7kE3BHY3gOshqNepesapGvFRlRSZawCoAoybTZu0NE0x6q/OPwg1wOWASq 2IwTGjtCBg3utNMVoyqfbuF11UvqThwz2toE+Y1v31IwpkpMWEkxmajJ5gEMnKjydX h6T5ZYx1n87Hg== From: Jan Hoffmann To: openwrt-devel@lists.openwrt.org Cc: john@phrozen.org, Jan Hoffmann Subject: [PATCH] ltq-vdsl/ltq-vdsl-app: clean up configure args Date: Thu, 19 Aug 2021 18:51:45 +0200 Message-Id: <20210819165145.1729798-1-jan@3e8.eu> X-Mailer: git-send-email 2.32.0 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210819_095217_455802_63143F0A X-CRM114-Status: GOOD ( 12.74 ) X-Spam-Score: -0.2 (/) X-Spam-Report: Spam detection software, running on the system "bombadil.infradead.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: The userspace application now uses the model=full option to match the configuration of the kernel module. The source no longer contains SOAP support, which was the primary reason to build only typical [...] Content analysis details: (-0.2 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 SPF_NONE SPF: sender does not publish an SPF Record -0.0 SPF_HELO_PASS SPF: HELO matches SPF record -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain X-BeenThere: openwrt-devel@lists.openwrt.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: OpenWrt Development List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "openwrt-devel" Errors-To: openwrt-devel-bounces+incoming=patchwork.ozlabs.org@lists.openwrt.org The userspace application now uses the model=full option to match the configuration of the kernel module. The source no longer contains SOAP support, which was the primary reason to build only typical instead of full before. This makes several CLI commands, which were already supported in the kernel module, available in the userspace application. For example, this includes bbsg which allows to get information about VDSL2 bands. Some previously applied build options were redundant. Disabling ADSL MIB support is unnecessary, as it only applies to Danube. ADSL LED support is no longer included in the source. ReTx counters are already included with model type full. This increases the size of the userspace application by approximately 15 kB (uncompressed). The kernel module does not change at all. Signed-off-by: Jan Hoffmann --- If size is a concern, the option --enable-dsl-pm-optional-parameters=no could be added for both packages. Compared to the full build, this would remove support for several CLI commands (mostly related to PM thresholds and PM history stats), which were also previously unsupported in the application. Compared to the original build, the total size would then decrease by 18 kB (uncompressed, +4 kB for application, -22 kB for kernel module). package/kernel/lantiq/ltq-vdsl/Makefile | 13 +++++-------- package/network/config/ltq-vdsl-app/Makefile | 13 +++++-------- 2 files changed, 10 insertions(+), 16 deletions(-) diff --git a/package/kernel/lantiq/ltq-vdsl/Makefile b/package/kernel/lantiq/ltq-vdsl/Makefile index 229e2b577c..f45895ba33 100644 --- a/package/kernel/lantiq/ltq-vdsl/Makefile +++ b/package/kernel/lantiq/ltq-vdsl/Makefile @@ -9,7 +9,7 @@ include $(INCLUDE_DIR)/kernel.mk PKG_NAME:=ltq-vdsl-vr9 PKG_VERSION:=4.17.18.6 -PKG_RELEASE:=4 +PKG_RELEASE:=5 PKG_BASE_NAME:=drv_dsl_cpe_api PKG_SOURCE:=$(PKG_BASE_NAME)_vrx-$(PKG_VERSION).tar.gz @@ -55,17 +55,14 @@ CONFIGURE_ARGS += --enable-kernel-include="$(LINUX_DIR)/include" \ --enable-ifxos-include="-I$(STAGING_DIR)/usr/include/ifxos" \ --enable-driver-include="-I$(STAGING_DIR)/usr/include/vdsl" \ --enable-add-drv-cflags="-DMODULE -DINCLUDE_DSL_ATM_PTM_INTERFACE_SUPPORT" \ - --enable-adsl-led=no \ - --enable-adsl-mib=no \ - --enable-dsl-ceoc=no \ --enable-linux-26 \ --enable-kernelbuild="$(LINUX_DIR)" \ - --enable-debug-prints=no \ - --enable-dsl-pm-retx-counters \ - --enable-dsl-pm-retx-thresholds \ + --enable-debug-prints=no ARCH=mips -CONFIGURE_ARGS += --enable-model=full +CONFIGURE_ARGS += \ + --enable-model=full \ + --enable-dsl-ceoc=no #CONFIGURE_ARGS += --enable-model=lite #CONFIGURE_ARGS += --enable-model=footprint #CONFIGURE_ARGS += --enable-model=typical diff --git a/package/network/config/ltq-vdsl-app/Makefile b/package/network/config/ltq-vdsl-app/Makefile index 0823a0e7e9..6ea103de8d 100644 --- a/package/network/config/ltq-vdsl-app/Makefile +++ b/package/network/config/ltq-vdsl-app/Makefile @@ -9,7 +9,7 @@ include $(INCLUDE_DIR)/kernel.mk PKG_NAME:=ltq-vdsl-app PKG_VERSION:=4.17.18.6 -PKG_RELEASE:=8 +PKG_RELEASE:=9 PKG_BASE_NAME:=dsl_cpe_control PKG_SOURCE:=$(PKG_BASE_NAME)_vrx-$(PKG_VERSION).tar.gz PKG_SOURCE_URL:=@OPENWRT @@ -61,15 +61,12 @@ CONFIGURE_ARGS += \ --disable-dti \ --with-channels-per-line="1" -#CONFIGURE_ARGS += --enable-model=full +CONFIGURE_ARGS += \ + --enable-model=full \ + --enable-dsl-ceoc=no #CONFIGURE_ARGS += --enable-model=lite #CONFIGURE_ARGS += --enable-model=footprint -CONFIGURE_ARGS += \ - --enable-model=typical \ - --enable-dsl-pm-showtime \ - --disable-dsl-ceoc \ - --enable-dsl-pm-retx-counters \ - --enable-dsl-pm-retx-thresholds +#CONFIGURE_ARGS += --enable-model=typical #CONFIGURE_ARGS += --enable-model=debug define Package/ltq-vdsl-app/install