From patchwork Sun Jan 17 17:10:35 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hauke Mehrtens X-Patchwork-Id: 1427819 X-Patchwork-Delegate: hauke@hauke-m.de Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.openwrt.org (client-ip=2001:8b0:10b:1231::1; helo=merlin.infradead.org; envelope-from=openwrt-devel-bounces+incoming=patchwork.ozlabs.org@lists.openwrt.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; secure) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=merlin.20170209 header.b=Gu3ZXF7W; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=hauke-m.de header.i=@hauke-m.de header.a=rsa-sha256 header.s=MBO0001 header.b=OSCrMZlx; dkim-atps=neutral Received: from merlin.infradead.org (merlin.infradead.org [IPv6:2001:8b0:10b:1231::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4DJhVW2kq6z9sVk for ; Mon, 18 Jan 2021 04:19:31 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=D4uLvP1WRoFGeq8wjmalt0RDkXc8lKIjsy5W85PdLCU=; b=Gu3ZXF7WuaCICThnRdjo/VoAf BCPAEShym1hAVoJoPJj0KK9IAXl4mpDWZFZW2YZK2QQsTeTa630G4DFSN7FuaN4zgJEtIHkQR4mlq ZxkWo+JIfalWgR/vj9O41jRy1EBTUzNc+77HHxuhat+EvhLCKQxgjQ9VV98ibtijgkZFKQvm2UtcH qtpmBZpI1V0x/QIbaR7nnULN+woXRxkSNbX8tJWmyzmZDZCwflDy4Eq6m3Wsnbm8MpVdbNVvjrCe2 Pnps3M/cH+6jPgm1SEVCvkmj550bZuDP0/+NFkG48wwBK/+FpMAwSV//975KnT8jcu6NJoDrHKKiG a9F6of43g==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l1Bgb-0000xl-3C; Sun, 17 Jan 2021 17:17:57 +0000 Received: from mout-p-201.mailbox.org ([80.241.56.171]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1l1BgU-0000vr-1b for openwrt-devel@lists.openwrt.org; Sun, 17 Jan 2021 17:17:51 +0000 Received: from smtp1.mailbox.org (smtp1.mailbox.org [IPv6:2001:67c:2050:105:465:1:1:0]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-201.mailbox.org (Postfix) with ESMTPS id 4DJhJc0MlszQlXk; Sun, 17 Jan 2021 18:10:56 +0100 (CET) X-Virus-Scanned: amavisd-new at heinlein-support.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hauke-m.de; s=MBO0001; t=1610903453; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9z+mPa0577EVAam01n5XYVqHBTQgFZID8nquxXFQYOw=; b=OSCrMZlxCYSw0tlP3DYldocmqpW/dX/wRVm03xcmUXOjb5OLVKun+xlHqOqIRMJFkBOiCz Gezwnow0wLXFVtMqtLivQcVQGlOJl78ytMOEVd9xNeuaxmNpyzEkQZaKhaVeN8KTFBZYz6 wuLBNLbJBnyvUxRM2fsw+kdtuBvChmlzD7RyUpq2XPZDMbJSncnnSpZnDobZVQ1ioNr0nw I3/zottAwwphoSSFsr49eppCsvbbUmSg5N2brEWbujj2z93GJ0YKAAeLiTSHnU3O/8RqTU 5gA2Amo4BaXJPyqGnnjX0n0XA7V0R4NZJq6spsUW6Bt97/ni4FtH/JRbuVDbyQ== Received: from smtp1.mailbox.org ([80.241.60.240]) by spamfilter01.heinlein-hosting.de (spamfilter01.heinlein-hosting.de [80.241.56.115]) (amavisd-new, port 10030) with ESMTP id wAr_-NR6dqTV; Sun, 17 Jan 2021 18:10:52 +0100 (CET) From: Hauke Mehrtens To: openwrt-devel@lists.openwrt.org Subject: [RFC PATCH 1/2] Workaround recursive error Date: Sun, 17 Jan 2021 18:10:35 +0100 Message-Id: <20210117171036.30931-2-hauke@hauke-m.de> In-Reply-To: <20210117171036.30931-1-hauke@hauke-m.de> References: <20210117171036.30931-1-hauke@hauke-m.de> MIME-Version: 1.0 X-MBO-SPAM-Probability: X-Rspamd-Score: -5.85 / 15.00 / 15.00 X-Rspamd-Queue-Id: E7E9E184C X-Rspamd-UID: 194d86 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210117_121750_309734_61520D1F X-CRM114-Status: GOOD ( 15.45 ) X-Spam-Score: -0.9 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.9 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at https://www.dnswl.org/, low trust [80.241.56.171 listed in list.dnswl.org] -0.0 RCVD_IN_MSPIKE_H3 RBL: Good reputation (+3) [80.241.56.171 listed in wl.mailspike.net] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.0 RCVD_IN_MSPIKE_WL Mailspike good senders X-BeenThere: openwrt-devel@lists.openwrt.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: OpenWrt Development List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Hauke Mehrtens Sender: "openwrt-devel" Errors-To: openwrt-devel-bounces+incoming=patchwork.ozlabs.org@lists.openwrt.org It looks like there is a bug in our configuration system when we add the additional dependencies in PKG_DEFAULT_DEPENDS we get these recursive errors: ---------------------------- tmp/.config-package.in:19514:error: recursive dependency detected! tmp/.config-package.in:19514: symbol PACKAGE_kmod-cfg80211 depends on PACKAGE_kmod-cfg80211 For a resolution refer to Documentation/kbuild/kconfig-language.rst subsection "Kconfig recursive dependency limitations" tmp/.config-package.in:19115:error: recursive dependency detected! tmp/.config-package.in:19115: symbol PACKAGE_kmod-b43 depends on PACKAGE_kmod-b43 For a resolution refer to Documentation/kbuild/kconfig-language.rst subsection "Kconfig recursive dependency limitations" tmp/.config-package.in:18681:error: recursive dependency det ---------------------------- Just remove the dependency on iw. --- package/kernel/mac80211/Makefile | 2 +- package/network/utils/iw/Makefile | 11 ++++++++--- 2 files changed, 9 insertions(+), 4 deletions(-) diff --git a/package/kernel/mac80211/Makefile b/package/kernel/mac80211/Makefile index 096225754c31..2e4a4d4019ea 100644 --- a/package/kernel/mac80211/Makefile +++ b/package/kernel/mac80211/Makefile @@ -98,7 +98,7 @@ PKG_CONFIG_DEPENDS += \ define KernelPackage/cfg80211 $(call KernelPackage/mac80211/Default) TITLE:=cfg80211 - wireless configuration API - DEPENDS+= +iw +wireless-regdb + DEPENDS+= +wireless-regdb ABI_VERSION:=$(PKG_VERSION)-$(PKG_RELEASE) FILES:= \ $(PKG_BUILD_DIR)/compat/compat.ko \ diff --git a/package/network/utils/iw/Makefile b/package/network/utils/iw/Makefile index 6eb10c837fde..6a551004c9fe 100644 --- a/package/network/utils/iw/Makefile +++ b/package/network/utils/iw/Makefile @@ -27,13 +27,18 @@ define Package/iw URL:=http://wireless.kernel.org/en/users/Documentation/iw DEPENDS:= +libnl-tiny VARIANT:=tiny + PROVIDES:=iw + CONFLICTS:=iw-full endef define Package/iw-full - $(Package/iw) - TITLE += (full version) - VARIANT:=full + SECTION:=net + CATEGORY:=Network + TITLE:=cfg80211 interface configuration utility (full version) + URL:=http://wireless.kernel.org/en/users/Documentation/iw + DEPENDS:= +libnl-tiny PROVIDES:=iw + VARIANT:=full endef define Build/Configure