diff mbox series

firewall3: fix duplicate defaults section detection

Message ID 20201018222858.238814-1-rsalvaterra@gmail.com
State Accepted
Headers show
Series firewall3: fix duplicate defaults section detection | expand

Commit Message

Rui Salvaterra Oct. 18, 2020, 10:28 p.m. UTC 
The flag was initialised and tested, but actually never set when a duplicate
section was found.

Signed-off-by: Rui Salvaterra <rsalvaterra@gmail.com>
---
 defaults.c | 2 ++
 1 file changed, 2 insertions(+)

Comments

Jo-Philipp Wich Dec. 6, 2020, 1:48 p.m. UTC | #1 
Merged into project/firewall3.git, branch master at
http://git.openwrt.org/?p=project/firewall3.git.

Thank you!
diff mbox series

Patch

diff --git a/defaults.c b/defaults.c
index 0580bfc..bd48958 100644
--- a/defaults.c
+++ b/defaults.c
@@ -151,6 +151,8 @@  fw3_load_defaults(struct fw3_state *state, struct uci_package *p)
 			continue;
 		}
 
+		seen = true;
+
 		if(!fw3_parse_options(&state->defaults, fw3_flag_opts, s))
 			warn_elem(e, "has invalid options");