From patchwork Tue Sep 8 08:26:34 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: David Woodhouse X-Patchwork-Id: 1359601 X-Patchwork-Delegate: daniel@makrotopia.org Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.openwrt.org (client-ip=2001:8b0:10b:1231::1; helo=merlin.infradead.org; envelope-from=openwrt-devel-bounces+incoming=patchwork.ozlabs.org@lists.openwrt.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; secure) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=merlin.20170209 header.b=i1Z8jS9J; dkim-atps=neutral Received: from merlin.infradead.org (merlin.infradead.org [IPv6:2001:8b0:10b:1231::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4BlywD57ctz9sSJ for ; Tue, 8 Sep 2020 18:28:28 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe :List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:To:From: Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=t6nnhdLNJ8S7j6yq8O7lJdagKpq3tUMp0zD7/nzi7i4=; b=i1Z8jS9JzLGuoc+bX27q/poRmC /uxxPDRwePd1+LS4Jkc9LFMpOiUYiKQTE2BhWnR7rvuajlggIh3TFc7yHKVgC1jv1VvKM2Tg7ACZp CepZQkxK8KcsXqqrk4LNK+AD3hoZEcB8R6WVTOLBpUnz7Mx4LrdH60lPEAygaxnqX5ejGOebd4Ljh CSuZEOzkMrBbB7gmPWSLlEHGwurE6J3SRl5qUfPOOKUQ1GPStRpttdPOVcayU8a6tvSCFKzYWqNmj DPJ2ufo4RaAya8SfDT90uh1IHzsWqoY1WQQa63rslgDzGWZ2OUvOaeEIvc/e1WkjXrjxowASRLVIi KTVlfHow==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kFYxb-0006MC-Kp; Tue, 08 Sep 2020 08:26:39 +0000 Received: from i7.infradead.org ([2001:8b0:10b:1:21e:67ff:fecb:7a92]) by merlin.infradead.org with esmtpsa (Exim 4.92.3 #3 (Red Hat Linux)) id 1kFYxX-0006LF-6s for openwrt-devel@lists.openwrt.org; Tue, 08 Sep 2020 08:26:35 +0000 Received: from dwoodhou by i7.infradead.org with local (Exim 4.93 #3 (Red Hat Linux)) id 1kFYxW-007zHg-5g for openwrt-devel@lists.openwrt.org; Tue, 08 Sep 2020 09:26:34 +0100 From: David Woodhouse To: openwrt-devel@lists.openwrt.org Subject: [PATCH 3/3] mediatek: mt7623: use bash for generating bootable images Date: Tue, 8 Sep 2020 09:26:34 +0100 Message-Id: <20200908082634.1898371-3-dwmw2@infradead.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200908082634.1898371-1-dwmw2@infradead.org> References: <20200908082634.1898371-1-dwmw2@infradead.org> MIME-Version: 1.0 X-BeenThere: openwrt-devel@lists.openwrt.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: OpenWrt Development List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "openwrt-devel" Errors-To: openwrt-devel-bounces+incoming=patchwork.ozlabs.org@lists.openwrt.org It turns out that 'echo -e' isn't portable; it doesn't work in the dash builtin echo and Ubuntu users are complaining. I can't even get octal (specified by POSIX) to work consistently because those variants of 'echo' which *do* support -e don't seem to interpret octalwithout it. I could switch to /bin/echo but using -e with that isn't actually portable *either* even though it works today. For now just stick with bash, and use its builtin. We may end up using something else entirely; perhaps perl. Signed-off-by: David Woodhouse --- target/linux/mediatek/image/gen_mtk_mmc_img.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/linux/mediatek/image/gen_mtk_mmc_img.sh b/target/linux/mediatek/image/gen_mtk_mmc_img.sh index ea8a9c63a1..2dacb9019d 100755 --- a/target/linux/mediatek/image/gen_mtk_mmc_img.sh +++ b/target/linux/mediatek/image/gen_mtk_mmc_img.sh @@ -1,4 +1,4 @@ -#!/bin/sh +#!/bin/bash # # Copyright © 2019 Alexey Loukianov # Copyright © 2020 David Woodhouse