From patchwork Tue Jul 28 18:47:35 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Adrian Schmutzler X-Patchwork-Id: 1337962 X-Patchwork-Delegate: freifunk@adrianschmutzler.de Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.openwrt.org (client-ip=2001:8b0:10b:1231::1; helo=merlin.infradead.org; envelope-from=openwrt-devel-bounces+incoming=patchwork.ozlabs.org@lists.openwrt.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=adrianschmutzler.de Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; secure) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=merlin.20170209 header.b=lo9LWXdr; dkim-atps=neutral Received: from merlin.infradead.org (merlin.infradead.org [IPv6:2001:8b0:10b:1231::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4BGQj610dxz9sSy for ; Wed, 29 Jul 2020 04:50:17 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=ZJQLM1F4vKLHOMOznVrR/+LA/AlngeVX6ljPxEXsHLk=; b=lo9LWXdrrEmmMmAvZFT/khOxE aLkJYGlqBZ57EItvb3VTNusrIKwuKTthm0mvf3UmBguqDd/eyLP3lDEWAGLbQxab5aaYkeOJQfUew if9OYgDI7rW4Q3TTQ467gVQdpMImJwaE1t4xGAymax2/CtC1AeTkZ5kI0nZM2hP2SZ1jOB4J1MOnK brwxwkBIcmaUWkC1RLdLJNLma3DMKFnqpHvg/OJhd0mQ8qtc9nQ5eL300eh4l664AJ7hbGvrATdcp stYDutyboJPfHe3w7xKyijPn6IXsSw+/dKG85MDvvIIAeoCXRro3y/EqSrFEk2QEIT3cXC27+pvqp Vy9ydQsVQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1k0UeY-0000qM-5F; Tue, 28 Jul 2020 18:48:42 +0000 Received: from mout.kundenserver.de ([217.72.192.75]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1k0UeT-0000ol-PM for openwrt-devel@lists.openwrt.org; Tue, 28 Jul 2020 18:48:38 +0000 Received: from buildfff.adridolf.com ([188.192.134.246]) by mrelayeu.kundenserver.de (mreue109 [212.227.15.183]) with ESMTPSA (Nemesis) id 1MGi6m-1jwach3Yqg-00Dm3W; Tue, 28 Jul 2020 20:48:29 +0200 From: Adrian Schmutzler To: openwrt-devel@lists.openwrt.org Subject: [PATCH 3/3] treewide: mark devices as BROKEN instead of commenting out Date: Tue, 28 Jul 2020 20:47:35 +0200 Message-Id: <20200728184735.44206-3-freifunk@adrianschmutzler.de> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200728184735.44206-1-freifunk@adrianschmutzler.de> References: <20200728184735.44206-1-freifunk@adrianschmutzler.de> MIME-Version: 1.0 X-Provags-ID: V03:K1:7Fu5e37u0sDoZERdtFyWYjsGf/yEhqJFkUXOQ31tzrqwDZ2+RVv 6UeIj8hGsxHV5r8AdoaHBTMJofQvzyT2qdg5lMi1M5zH+/Nbn53iZCAp5MpxNAt83y4h6Nz wRzs2BWkfhuehe/OnXQCevMoOPCwQz49Bg0pkZRlPqJeFnddL+/x3gsOFU2g5PzFigu6Btx M86tqva8jnNVFvW7C3umQ== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:W+DoNPzv9eE=:gT3EvN88rnFOQjM3qMH//A Ty+2pAAntvhwjDThhebhL/DoorB3Vnyh5UeyhTW2ZbFPrwmro6v+zpxyZxNnzKm30BU4YZCZH 6p6D5q7Iwd4s0QUfY0W2Dgf7f2G4wlOgv4em+BxbBHMReisfWai13EztNdHDduI2xA5BzDKkV FuqDpn0rHZrlNuPoGy400Hy+fdgpOZ0FLtZ96dSOHKkuQc1+8lj7Yl290DVUBcddcXTPoRzc7 rbKEXSw3DQRNXElRM3Tap4G3LGHU5djPAmpxF9leHHxbuYS2St/UtrwMYjcrhFtAKcDjYyavc TUR73A5dheP+P8uWX0VGEyCKDiBv8x970Lmw93UrEk7CVF+/8j/yxLdSp++uA2kk4Nblvikog JAN7t8qEm6zQlIvzmtSqVvKvZalQbxXqgPI6WFCcEhkVyhEUJRf0+R/Q6Xe753kWVovruusQV Vw5P3hEYu5U7EQuKVx52lq+a4oWebByLtOFwBavJK9EdDUKykxmg6JQ3qG5LUznOtyAM+wF5v TCXELUsruzVSxWjDFCiQsOwxUDWO/+hpvbBDzakjxoEdPDHVCDVHXzY2qWEra1IYi5TvpCSK2 nB57z6bwEnJH3QvPAV41/BCJiO8gdwmNRCVxVTfLSc+dm21jBguUidUjkyUcD7KvIwdSk5wU6 GB4FQWg4YM5147Hg5cPutg/cOluod9JxmiGPCY4g3/vs3IZ8F18et2jkQSsnsQAXlEHmfG63D Fm6z126kMy78LQzM9V/0XnQhV0spaP2Og+xDR3FaqFpAoKSnvjZZQjylLRKsRfr/iMWyoCotO 4xrlGOU+KDbewU03gmjWq75GyOozxPbebXKClGif7DzfOc3V5fQbQuBczbn0S6u5Jl2b3xamy dC1/jbaLN/QL5Lmn+REA== X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200728_144838_087279_A5DAA130 X-CRM114-Status: GOOD ( 11.91 ) X-Spam-Score: -0.0 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.0 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [217.72.192.75 listed in wl.mailspike.net] -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [217.72.192.75 listed in list.dnswl.org] X-BeenThere: openwrt-devel@lists.openwrt.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: OpenWrt Development List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?utf-8?q?Petr_=C5=A0tetiar?= Sender: "openwrt-devel" Errors-To: openwrt-devel-bounces+incoming=patchwork.ozlabs.org@lists.openwrt.org From: Petr Štetiar This adds the newly introduced BROKEN flag to a bunch of devices that previously just had TARGET_DEVICES commented out. By this, we can select them in make menuconfig when BROKEN developer config option is selected, instead of having to edit the code. In contrast to DEFAULT := n, this is meant to cover devices that don't boot or don't compile at all. ath25: np25g, wpe53g both disabled during kernel bump 3.18->4.4 without reason given f89a20a89aeb ("ath25: update kernel from 3.18 to 4.4") bcm53xx: linksys-ea6300-v1, linksys-ea9200, linksys-ea9500 broken due to insufficient/broken TRX support 55ff15cfd509 ("bcm53xx: disable building Linksys EA6300 V1 image") cd0f9900a4cd ("bcm53xx: parepare for building more Linksys images") bcm63xx: tplink-archer-c5-v2, tplink-archer-c9-v1 disabled when kernel 5.4 support was added, probably broken 50c6938b95a0 ("bcm53xx: add v5.4 support") Signed-off-by: Petr Štetiar [limit to subset of devices, use BROKEN, adjust commit message/title] Signed-off-by: Adrian Schmutzler --- target/linux/ath25/image/Makefile | 6 ++++-- target/linux/bcm53xx/image/Makefile | 15 ++++++++++----- 2 files changed, 14 insertions(+), 7 deletions(-) diff --git a/target/linux/ath25/image/Makefile b/target/linux/ath25/image/Makefile index e1ebb159cd..8066ba61a8 100644 --- a/target/linux/ath25/image/Makefile +++ b/target/linux/ath25/image/Makefile @@ -99,15 +99,17 @@ define Device/np25g DEVICE_MODEL := NP25G KERNEL := kernel-bin | gzip-kernel IMAGE/sysupgrade.bin := append-rootfs | pad-rootfs | pad-to 128k | mkmylofw np25g + BROKEN := y endef -#TARGET_DEVICES += np25g +TARGET_DEVICES += np25g define Device/wpe53g DEVICE_VENDOR := Compex DEVICE_MODEL := WPE53G KERNEL := kernel-bin | gzip-kernel IMAGE/sysupgrade.bin := append-rootfs | pad-rootfs | pad-to 128k | mkmylofw wpe53g + BROKEN := y endef -#TARGET_DEVICES += wpe53g +TARGET_DEVICES += wpe53g $(eval $(call BuildImage)) diff --git a/target/linux/bcm53xx/image/Makefile b/target/linux/bcm53xx/image/Makefile index 5d4ae08513..a117e02a45 100644 --- a/target/linux/bcm53xx/image/Makefile +++ b/target/linux/bcm53xx/image/Makefile @@ -250,8 +250,9 @@ define Device/linksys-ea6300-v1 DEVICE_MODEL := EA6300 DEVICE_VARIANT := v1 DEVICE_PACKAGES := $(B43) $(USB3_PACKAGES) + BROKEN := y endef -# TARGET_DEVICES += linksys-ea6300-v1 +TARGET_DEVICES += linksys-ea6300-v1 define Device/linksys-ea6500-v2 DEVICE_VENDOR := Linksys @@ -266,16 +267,18 @@ define Device/linksys-ea9200 DEVICE_MODEL := EA9200 DEVICE_VARIANT := v1 DEVICE_PACKAGES := $(BRCMFMAC_43602A1) $(USB3_PACKAGES) + BROKEN := y endef -# TARGET_DEVICES += linksys-ea9200 +TARGET_DEVICES += linksys-ea9200 define Device/linksys-ea9500 DEVICE_VENDOR := Linksys DEVICE_MODEL := EA9500 DEVICE_PACKAGES := $(BRCMFMAC_4366C0) $(USB3_PACKAGES) DEVICE_DTS := bcm47094-linksys-panamera + BROKEN := y endef -# TARGET_DEVICES += linksys-ea9500 +TARGET_DEVICES += linksys-ea9500 define Device/luxul DEVICE_VENDOR := Luxul @@ -410,8 +413,9 @@ define Device/tplink-archer-c5-v2 IMAGES := bin IMAGE/bin := append-rootfs | bcm53xx-tplink-safeloader TPLINK_BOARD := ARCHER-C5-V2 + BROKEN := y endef -#TARGET_DEVICES += tplink-archer-c5-v2 +TARGET_DEVICES += tplink-archer-c5-v2 define Device/tplink-archer-c9-v1 DEVICE_VENDOR := TP-LINK @@ -421,7 +425,8 @@ define Device/tplink-archer-c9-v1 IMAGES := bin IMAGE/bin := append-rootfs | bcm53xx-tplink-safeloader TPLINK_BOARD := ARCHERC9 + BROKEN := y endef -#TARGET_DEVICES += tplink-archer-c9-v1 +TARGET_DEVICES += tplink-archer-c9-v1 $(eval $(call BuildImage))