| Message ID | 20200719082811.2304-2-todorcolov@abv.bg |
|---|---|
| State | Rejected |
| Headers | show |
| Series | Fix WiFi button off function - fix for bug report FS#3236 | expand |
> -----Original Message----- > From: openwrt-devel [mailto:openwrt-devel-bounces@lists.openwrt.org] > On Behalf Of Todor Colov > Sent: Sonntag, 19. Juli 2020 10:28 > To: openwrt-devel@lists.openwrt.org > Cc: Todor Colov <todorcolov@abv.bg> > Subject: [PATCH 1/1] Fix Wifi Button - off function not working This one looks valid from first look, however I wonder why it was working for me so far. Anyway, please adjust based on formal requirement, e.g. format title properly and add a commit message. Best Adrian > > Signed-off-by: Todor Colov <todorcolov@abv.bg> > --- > package/base-files/files/etc/rc.button/rfkill | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/package/base-files/files/etc/rc.button/rfkill b/package/base- > files/files/etc/rc.button/rfkill > index fbdda40ed5..2d4f0f86ff 100755 > --- a/package/base-files/files/etc/rc.button/rfkill > +++ b/package/base-files/files/etc/rc.button/rfkill > @@ -27,6 +27,6 @@ case "${TYPE}" in > esac > config_foreach wifi_rfkill_set wifi-device uci commit wireless -wifi up > +wifi > > return 0 > -- > 2.27.0 > > > _______________________________________________ > openwrt-devel mailing list > openwrt-devel@lists.openwrt.org > https://lists.openwrt.org/mailman/listinfo/openwrt-devel
> config_foreach wifi_rfkill_set wifi-device > uci commit wireless I've always hated this "uci commit" in the wifi on/off button handling, it causes FLASH wear for no good reason IMHO. But that is orthogonal to this patch, of course.
> -----Original Message----- > From: openwrt-devel [mailto:openwrt-devel-bounces@lists.openwrt.org] > On Behalf Of Henrique de Moraes Holschuh > Sent: Montag, 20. Juli 2020 00:51 > To: openwrt-devel@lists.openwrt.org > Subject: Re: [PATCH 1/1] Fix Wifi Button - off function not working > > > config_foreach wifi_rfkill_set wifi-device > > uci commit wireless > > I've always hated this "uci commit" in the wifi on/off button handling, it > causes FLASH wear for no good reason IMHO. > > But that is orthogonal to this patch, of course. Yes, but as you say it, I wonder whether we really need wifi here or reload_config if we touch uci config anyway. Refering to your actual subject, for me pressing WiFi button has always been an extremely rare case, so I'm not too concerned about that flash wear personally. Best Adrian > > -- > Henrique de Moraes Holschuh > > _______________________________________________ > openwrt-devel mailing list > openwrt-devel@lists.openwrt.org > https://lists.openwrt.org/mailman/listinfo/openwrt-devel
diff --git a/package/base-files/files/etc/rc.button/rfkill b/package/base-files/files/etc/rc.button/rfkill index fbdda40ed5..2d4f0f86ff 100755 --- a/package/base-files/files/etc/rc.button/rfkill +++ b/package/base-files/files/etc/rc.button/rfkill @@ -27,6 +27,6 @@ case "${TYPE}" in esac config_foreach wifi_rfkill_set wifi-device uci commit wireless -wifi up +wifi return 0
Signed-off-by: Todor Colov <todorcolov@abv.bg> --- package/base-files/files/etc/rc.button/rfkill | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)