From patchwork Thu Jul 16 15:52:24 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arjun AK X-Patchwork-Id: 1330372 X-Patchwork-Delegate: ynezz@true.cz Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.openwrt.org (client-ip=2001:8b0:10b:1231::1; helo=merlin.infradead.org; envelope-from=openwrt-devel-bounces+incoming=patchwork.ozlabs.org@lists.openwrt.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; secure) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=merlin.20170209 header.b=1s9pWykV; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20161025 header.b=ut8L3kHQ; dkim-atps=neutral Received: from merlin.infradead.org (merlin.infradead.org [IPv6:2001:8b0:10b:1231::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4B6zMg6SNpz9sRW for ; Fri, 17 Jul 2020 01:54:23 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:To:From: Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender :Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Owner; bh=oXx2e6ch/P3OxtB0vzbMM/jdV1oGU5K5dCeGCXrEhSg=; b=1s9pWykV6za2sxEXu1zaTxxFk0 DTKu5EIKpF0G/D51LPDSRh2GnR7rQ8aU7JaUVQH045Rr5DDX22jEIkLqroL+s8ePW2icpFVJCmUDy JVfoXyl41lQ2JxjEW/NRaeoGROgpVG8YWb7AcUFraNxVl73s/BxJ3gH2RQjG7x4vl1mofQs19lVH+ 2I4Lh51wlKhtzy1hxOAjiMvefYS6t2yQMNl7xfpoHryuAuH0obkb6l265ehC7ZxbX2TefQBdb3bq9 x8mA2SIQOlr2E2WfNESeN2e3pXcUWos2uZdlwvUQFncr4HTqoGbj+ZYJBdQ8IwiBGEIbkp+nKH94I 4tp10owA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jw6BZ-0004MP-E7; Thu, 16 Jul 2020 15:52:37 +0000 Received: from mail-pl1-x643.google.com ([2607:f8b0:4864:20::643]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jw6BX-0004Ls-BM for openwrt-devel@lists.openwrt.org; Thu, 16 Jul 2020 15:52:36 +0000 Received: by mail-pl1-x643.google.com with SMTP id x8so4040664plm.10 for ; Thu, 16 Jul 2020 08:52:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=ZWJ4BRbKg+FZ3LGcVKu1RO4cvlkxk7hJMps4SGsyVTs=; b=ut8L3kHQoxO88yaKn5ym5ETPMMv0iTwHFYBRfkXR+dhCxyvYEE2gs8RXA5Kx8F8dV2 y7EpZc+z/wsrq4t84t9JaNVljrHQ9Ux+rNOSNDGAqjE7j0kOHZLzrI2D8WybO+PeBZGp TOdETy4kcdhiF/96HmovMkhgusGN0MYj6Ocp9uA2wq1k0gyelTiBxwjjrYjCAzclhQSp I9XYXouzw1HLoBRZYROV9WJVn1ymUPvK0EyzGn/AEOLVTSDjTbBHCr85+I6fAbOY08ZZ Mn5gwFBltUr3A+1P0yIMfpaN/+A1/4XXv3abJ14tpSY7Hc9wvD6uAlidk73M86TiM9dL H+ng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=ZWJ4BRbKg+FZ3LGcVKu1RO4cvlkxk7hJMps4SGsyVTs=; b=WoCuuLvAzQDLHhd1o3FUWUKwFX20cSJ7hvoLfPV0wpAkHcIPRtzif4zb7L7n6ANyMz AZJsPXeFKSPGwH76AYvSkX7Ym+lZgT6qsrvpHn3C2cYJDtBrOUFCFHuCRN4VtzvllvE8 bsVWp0q594R2HFLHJG4bn/buW5hLNtIvb+MsDnBKnaNQQgw+2G0dNveOAOAPBuSjfSV7 Bk3iJfQ0AbQXalEIkVj0ZQobbzmP3Sr29k1bLAFmEiwO4PB/5mAAjwWtwbRpm2M0rLE7 XOGgg4xpTbIFD45efWAjaPW3NJ4U6qAZ9yE3DJOSwFsE/N2RV5oRGAnpNnplyirVCfNy goqA== X-Gm-Message-State: AOAM531EeyZqSx7vaAByItNifGSUtZKHP2VVy85qUMmSfioZZ+Uigkpi cvHoNNGWrhhHDz+4YWanTHU9Ewve/Rc= X-Google-Smtp-Source: ABdhPJwOFBvy2TeFffs3budMex/yxRbY0orQKmKXLA49TrmPUmW7YMUSu8XuCYafgdlCOIWjuISmSg== X-Received: by 2002:a17:902:fe85:: with SMTP id x5mr4201409plm.282.1594914751851; Thu, 16 Jul 2020 08:52:31 -0700 (PDT) Received: from localhost.localdomain ([49.206.10.229]) by smtp.gmail.com with ESMTPSA id r17sm5399489pfg.62.2020.07.16.08.52.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Jul 2020 08:52:31 -0700 (PDT) From: Arjun AK To: openwrt-devel@lists.openwrt.org Subject: [PATCH] package/comgt: Handle bind/unbind events Date: Thu, 16 Jul 2020 21:22:24 +0530 Message-Id: <20200716155224.9671-1-arjunak234@gmail.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200716_115235_417182_71A276AA X-CRM114-Status: UNSURE ( 8.18 ) X-CRM114-Notice: Please train this message. X-Spam-Score: 0.1 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (0.1 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2607:f8b0:4864:20:0:0:0:643 listed in] [list.dnswl.org] 0.2 FREEMAIL_ENVFROM_END_DIGIT Envelope-from freemail username ends in digit [arjunak234[at]gmail.com] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider [arjunak234[at]gmail.com] 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature X-BeenThere: openwrt-devel@lists.openwrt.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: OpenWrt Development List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Arjun AK Sender: "openwrt-devel" Errors-To: openwrt-devel-bounces+incoming=patchwork.ozlabs.org@lists.openwrt.org This script was expecting only add/remove events which has not been the case since Kernel 4.12 (which added bind/unbind). Bind events were getting treated as remove events which would cause hotplugged 3g modems to not work. More info: https://lkml.org/lkml/2018/12/23/128 https://github.com/systemd/systemd/issues/8221 Signed-off-by: Arjun AK --- package/network/utils/comgt/files/3g.usb | 2 ++ 1 file changed, 2 insertions(+) diff --git a/package/network/utils/comgt/files/3g.usb b/package/network/utils/comgt/files/3g.usb index 8f0d62ca83..9c7d07a0e6 100644 --- a/package/network/utils/comgt/files/3g.usb +++ b/package/network/utils/comgt/files/3g.usb @@ -23,6 +23,8 @@ find_3g_iface() { fi } +[ "$ACTION" = add ] || [ "$ACTION" = remove ] || exit 0 + case "$DEVICENAME" in tty*) [ -e "/dev/$DEVICENAME" ] || [ "$ACTION" = remove ] || exit 0