diff mbox series

[OpenWrt-Devel] lantiq: fritz7312: set maximum speed to 100 mbit on 5.4

Message ID 20200618094858.1929-1-freifunk@adrianschmutzler.de
State Accepted
Delegated to: Adrian Schmutzler
Headers show
Series [OpenWrt-Devel] lantiq: fritz7312: set maximum speed to 100 mbit on 5.4 | expand

Commit Message

Adrian Schmutzler June 18, 2020, 9:48 a.m. UTC
The fritz 7312 does not support 1000 gbit. Advertising it makes it
worse. Some NIC will change to 1000 gibt and turn off and on again for
ever.

The previous patch in 36f628910b8b was only applied to the 4.19 file.

Cc: Alexander Couzens <lynxis@fe80.eu>
Signed-off-by: Adrian Schmutzler <freifunk@adrianschmutzler.de>
---
 .../files-5.4/arch/mips/boot/dts/lantiq/ar9_avm_fritz7312.dts    | 1 +
 1 file changed, 1 insertion(+)

Comments

Martin Blumenstingl June 18, 2020, 8:25 p.m. UTC | #1
The sender domain has a DMARC Reject/Quarantine policy which disallows
sending mailing list messages using the original "From" header.

To mitigate this problem, the original message has been wrapped
automatically by the mailing list software.
Hi Adrian,

On Thu, Jun 18, 2020 at 11:49 AM Adrian Schmutzler
<freifunk@adrianschmutzler.de> wrote:
>
> The fritz 7312 does not support 1000 gbit. Advertising it makes it
> worse. Some NIC will change to 1000 gibt and turn off and on again for
> ever.
>
> The previous patch in 36f628910b8b was only applied to the 4.19 file.
according to [0] the 7312 has a 10/100Mbit/s Atheros AR8030-A PHY.
Do you know why it's advertising Gbit/s capabilities nevertheless?

I won't say "no" to this patch
If it's a hardware issue then more boarding will benefit from a fix in
the ar803x PHY driver.


Best regards,
Martin


[0] https://boxmatrix.info/wiki/FRITZ!Box_7312
Adrian Schmutzler June 18, 2020, 8:39 p.m. UTC | #2
> -----Original Message-----
> From: Martin Blumenstingl [mailto:martin.blumenstingl@googlemail.com]
> Sent: Donnerstag, 18. Juni 2020 22:26
> To: Adrian Schmutzler <freifunk@adrianschmutzler.de>
> Cc: openwrt-devel@lists.openwrt.org; Alexander Couzens <lynxis@fe80.eu>
> Subject: Re: [OpenWrt-Devel] [PATCH] lantiq: fritz7312: set maximum speed
> to 100 mbit on 5.4
> 
> Hi Adrian,
> 
> On Thu, Jun 18, 2020 at 11:49 AM Adrian Schmutzler
> <freifunk@adrianschmutzler.de> wrote:
> >
> > The fritz 7312 does not support 1000 gbit. Advertising it makes it
> > worse. Some NIC will change to 1000 gibt and turn off and on again for
> > ever.
> >
> > The previous patch in 36f628910b8b was only applied to the 4.19 file.
> according to [0] the 7312 has a 10/100Mbit/s Atheros AR8030-A PHY.
> Do you know why it's advertising Gbit/s capabilities nevertheless?
> 
> I won't say "no" to this patch
> If it's a hardware issue then more boarding will benefit from a fix in the
> ar803x PHY driver.

Hi,

I don't have any clue at all about the problem itself.

I just found the inconsistency and want to align 4.19 and 5.4, as currently it is effectively a regression.

If you want to address this differently, go for it, but don't ask me anything about it ;-)

Best

Adrian

> 
> 
> Best regards,
> Martin
> 
> 
> [0] https://boxmatrix.info/wiki/FRITZ!Box_7312
Alexander 'lynxis' Couzens June 21, 2020, 12:34 p.m. UTC | #3
> Hi,
> 
> I don't have any clue at all about the problem itself.
> 
> I just found the inconsistency and want to align 4.19 and 5.4, as
> currently it is effectively a regression.
> 
> If you want to address this differently, go for it, but don't ask me
> anything about it ;-)

i tested it before commiting the patch. it did a difference. i might
have time next weekend to look over it and do additional tests.

Please push the commit.

Best,
lynxis
diff mbox series

Patch

diff --git a/target/linux/lantiq/files-5.4/arch/mips/boot/dts/lantiq/ar9_avm_fritz7312.dts b/target/linux/lantiq/files-5.4/arch/mips/boot/dts/lantiq/ar9_avm_fritz7312.dts
index aa825abd9f..0f635127f8 100644
--- a/target/linux/lantiq/files-5.4/arch/mips/boot/dts/lantiq/ar9_avm_fritz7312.dts
+++ b/target/linux/lantiq/files-5.4/arch/mips/boot/dts/lantiq/ar9_avm_fritz7312.dts
@@ -108,6 +108,7 @@ 
 		phy0: ethernet-phy@0 {
 			reg = <0>;
 			reset-gpios = <&gpio 34 GPIO_ACTIVE_LOW>;
+			max-speed = <100>;
 		};
 	};
 };